variable not initialized

[solus hoo]

sorry guys, keep getting the varible not initialized output from the compiler, and was wondering if anyone could help, program is as follows.
any suggestions? can anyone explain the nature of the error to me as well?

public class p4 {
    public static void main(String[]args){
        double actualprice, discountprice;
        double luxurytax, gst, coe;
        double category;
        double totalcost;
        
        System.out.println("Enter the price of the car: ");
        actualprice = ConsoleIn.readlnDouble();
        System.out.println("Enter the category of the car: ");
        category = ConsoleIn.readlnDouble();
        
        discountprice = 0.9*actualprice;
        gst = 0.03*discountprice;
        
        {if (discountprice > 100000)
            luxurytax = 0.1*discountprice;
        else 
            luxurytax = 0;
        }
        
        if (category == 1)
            coe = 30000;
         else if (category == 2)
            coe = 35000;
         else if (category == 3)
            coe = 23000;
         else if (category == 4)
            coe = 600;
          
 
         totalcost = discountprice + luxurytax + gst + coe;
 
        
        System.out.println("The total cost of the car is " +totalcost);
        
        }
}

[ Jess added UBB [code] tags to perserve whitespace ]
[ August 23, 2004: Message edited by: Jessica Sant ]

[Layne Lund]

The error means exactly what it says. You need to give an intial value for all variables that you declare. One way to fix this is to set them to zero. For example:

double actualprice = 0.0;

Another possible solution is to declare the variable when you make the calculations:

System.out.println("Enter the price of the car: ");
double actualprice = ConsoleIn.readlnDouble();
System.out.println("Enter the category of the car: ");
double category = ConsoleIn.readlnDouble();
 
double discountprice = 0.9*actualprice;
double gst = 0.03*discountprice
// etc.

HTH

Layne

[Alain Boucher]

If you declare a variable in the class section, the initialization of those variables are automatic. but in a method it's not. Look this:

Ex:
public class MyClass{
public int classVariable
public static void main(String args[]){
int int1;
Object object1;

System.out.println(""+classVariable); //Display 0
System.out.println(""+int1); //Crash
System.out.println(object1); //Diaplay Null
}
}

This is java 101 man ; )

[Junilu Lacar]

Originally posted by Alain Boucher:
This is java 101 man ; )

Which is why this forum's name has "(beginner)" in it...

[Er.Ashish Gupta]

variables declared inside the main functions are 'local' to the main function.local variables are need to be explicitly initialized ; instance variables or static variables on the other need not be explicitly initialized, they get implicitly initialized to there default vales....

[Dirk Schreckmann]

Another possible solution is to declare the variable when you make the calculations

This is a good practice, the benefits of which Peter den Haan explained in a recent thread.

[Vlado Zajac]

Only coe variable might not be initailized before it is read. Other variables should be ok.

[Tony Morris]

public class MyClassd
{
  public int classVariable
 
  public static void main(String args[])
  {
    int int1;
    Object object1;
 
    System.out.println(""+classVariable); //Display 0
    System.out.println(""+int1); //Crash
    System.out.println(object1); //Diaplay Null
  }
}

There are several problems with this code, all of which I feel do not belong in a beginner's forum (gotta teach them the right way).

Let's correct them to save confusion:
- "public int classVariable" should end with a semi-colon.
- It should also be declared static because it is referenced from within a static context (a compile-time error will result otherwise).
- It is poor form to use the String concatenation operator in the way it has been.
- The assertion that "System.out.println(object1);" will display null is incorrect - it fails to compile.

Here is the revised code:

public class MyClass
{
  public static int classVariable;
 
  public static void main(String args[])
  {
    int int1;
    Object object1;
 
    System.out.println(classVariable); //Display 0
    // System.out.println(int1); //compile-time error when uncommented
    // System.out.println(object1); //compile-time error when uncommented
  }
}

What this code sample attempts to do is distinguish between initialization of fields versus method-locals (a method-local is a variable declared within a method - and a field is one declared inside a class). When you attempt to use a local, the compiler enforces that it has been assigned. However, fields have a default value assigned during object initialization (note that this is distinct from object instantiation - but that's another story ).

Hope this helps.

[solus hoo]

why is variable 'coe' not initialised? i keep getting that particular compiler error. and i'm sorry guys, i'm an absolute beginner.

[Joyce Lee]

Originally posted by solus hoo:
why is variable 'coe' not initialised? i keep getting that particular compiler error. and i'm sorry guys, i'm an absolute beginner.

Hello Solus. This is a rule given in Java Language Specification under 4.5.4 Initial Values of Variables. Only instance variable or array component is initialized with a default value.

Joyce
[ August 23, 2004: Message edited by: Joyce Lee ]

[Dirk Schreckmann]

er...

Static class members are also automatically initialized.

I like to think about it thus: All members are automatically initialized. That's class members, instance members, and array members.

[fred rosenberger]

Solus... let me try...

when you make a class, there basically are two things it can have - instance variables, and methods. instance variables are variables that are not declared inside any method. Your class has none of those since every variable is inside your only method - main() has actualprice, discountprice, etc.

ANY variable declared inside a method is NOT initialized. it has NO value until you GIVE it one. so, you could fix your problem by writing:

double actualprice = 0.0;
double discountprice = 0.0;

etc.

The other thing people are talking about are instance variables. These are variable that ARE defined in the class, but NOT in a method. These DO get a default value (usually 0 or some form thereof). So, the other way to fix your problem is to declare your variables OUTSIDE of your main() method, but INSIDE the class...

public class p4{
   //these variables are NOT in any method, but in the class
   double actualprice, discountprice;
   double luxurytax, gst, coe;
   double category;
   double totalcost;
 
 public static void main(String [] args){
...
}    //ends the main() method
}    //ends the class

Does that help?

[Jay Will]

An easy way for beginners to remember about variable/object initialization is like this. If the variable/object is declared inside of the class but outside of a method (this includes the main method) then it has a default value. If it is declared inside of a method (including the main method) then it has to be manually initialized. Basiclly all of your variables were declared inside of the main method so they have to be manually initialized.

[Layne Lund]

Originally posted by Vlado Zajac:
Only coe variable might not be initailized before it is read. Other variables should be ok.

In the original code, none of the variables are initialized before use. That is what the OP got a compiler error. The example I gave should give the OP the idea how to initialize the rest of the variables correctly.