So far...

[Stephen Foy]

So far the object of my project is to produce a program that will roll 3 dice, and print out three random values. And display the highest and ask you if you want to keep it, if not it will roll again (2 rolls max). You keep ur value then roll 2 dice, and then 1 dice and keep the highest values and add them together at end.

So far my program looks like.

Am i going in the right direction? Criticism welcomed!

import java.math.*;
import java.util.*;
 
class dice {
 
int[] Highest = new int[3];
 

 int rollDice() {
 
double number = (int)(Math.random() * 6) + 1;
int realnum = (int)number;
return realnum;
 
}
 
void run() {
 
dice roller = new dice();
int largest = Integer.MIN_VALUE;
boolean loop = false;
 
while (!loop) {
for (int i = 0;i < Highest.length;i++) {
Highest[i] = roller.rollDice();
System.out.print(Highest[i]+" | ");
}
for (int i = 0;i < Highest.length;i++) {
if (Highest[i] > largest) {
largest = Highest[i];
}
}
System.out.print("\nThe largest number is "+largest+" would you like to keep it or roll again? y or n: ");
Scanner in = new Scanner(System.in);
String answer = in.nextLine();
 
if (answer.length() == 1 && answer.charAt(0)=='y') {
int counter = 0; counter++;
loop = false;
} else if (answer.length() == 1 && answer.charAt(0)=='n') { loop = true; }
 
}
System.out.println(" ");
}
 

 

// Methods will be defined above.
 
public static void main(String[] args) {
 
dice roller = new dice();
 
try {
 
System.out.print("Roll one: ");roller.run();
 
} catch (Exception ex) { System.out.println ("\nThis isnt a valid number \n"); }
 

}
 
}

[Junilu Lacar]

One thing I could suggest is to re-organize your code/logic a little bit. Writing a program is a lot like writing a story. In a good story, sentences, paragraphs, and chapters are organized so that there is a continuous flow in the story. Similarly, you should write code so that somebody reading it will be able understand the purpose of the program.

Compare these two snippets:

// version 1
while (!loop) {
   ...
}
  
// version 2
while (playerWantsToRollAgain()) {
   ...
}

Which version makes its purpose clearer? Reading code should be like reading a story.

public DiceGame {
    public static void main(String[] args) {
        DiceGame game = new DiceGame();
        game.play();
    }
    
    public void play() {
        Dice[] dice = createDice(2);
        ...
        rollDice(dice, 3);
    } 
   
    /**
     * Creates an array of diceCount dice
     * @param diceCount the number of dice to create
     * @returns an array containing the dice created.
     */
    private Dice[] createDice(int diceCount) {
        ...
    }
  
    /**
     * Rolls the given set of dice and returns an array of 
     * integers representing the highest rolls picked by 
     * the player.
     * 
     * @param dice the set of dice to use 
     * @param howManyToPick the number of rolls that the 
     *           player gets to pick to try to win this game
     * @returns an array containing the values of the rolls 
     *           that the player picked.
     */
    private int[] rollDice(Dice[] dice, int howManyToPick) {
        ...
    }
   
    // ... and so on 
}
  
class Dice {
    public Dice(...) {
       ...
    }
 
    public int roll() {
       return ...
    }
}

If you read the code above from top to bottom, there is a natural progression from high level to low level ideas. Just as a paragraph revolves around a central idea, a method should also revolve around a central singular purpose and each statement in the method should be written towards achieving that single purpose. Don't be afraid to write many methods. Use comments to clarify the purpose of each method but strive to write code that reads the way it is intended to work.

Also, try to follow standard coding conventions. In particular, class names should be start with a capital letter (you declared a class named dice), variables should start with lowercase (you declared a variable name Highest).

Sorry if this seems a bit much for a beginner but hopefully you can see the benefits of such practices.

[Stephen Foy]

Na its great advice, thanks alot.

[Adam Richards]

Tip: Try to use more specific subject lines. The more meaningful your subject, the more meaningful your replies.