No getter method for property

[Vijay Chandran]

Dear friends,

Kindly help me in resolving this exception!

The following is my Action class:

    
package com.example.web;

import com.example.model.Expert;
import java.io.IOException;
import java.io.PrintWriter;
import java.util.List;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;

public class SelectAction extends Action
{
    @Override
    public ActionForward execute(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws IOException
    {
        // Cast the form to the application-specific form
        SelectForm myForm = (SelectForm) form;
       
        // Process the business logic
        Expert be = new Expert();
        List<String> result = be.getBrands(myForm.getColor());

        // Forward to the Results view
        // (and store the data in the request scope)
        request.setAttribute("styles", result);
        return mapping.findForward("show_results");
    }
}

This is my ActionForm class:

package com.example.web;

import java.util.ArrayList;
import java.util.List;
import javax.servlet.http.HttpServletRequest;
import org.apache.struts.action.ActionErrors;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionMapping;
import org.apache.struts.action.ActionMessage;

public class SelectForm extends ActionForm
{
    private String color = null;
    private static final String VALID_COLORS = "amber,dark,light,brown";
    public List<String> brands = new ArrayList<String>();

    public List<String> getBrands()
    {
        return brands;
    }

    public void setBrands(List<String> brands)
    {
        this.brands = brands;
    }

    public String getColor()
    {
        return color;
    }

    public void setColor(String color)
    {
        this.color = color;
    }

    public ActionErrors validate(ActionMapping mapping, HttpServletRequest request)
    {
        ActionErrors errors = new ActionErrors();
        if(VALID_COLORS.indexOf(color) == -1)
        {
            errors.add("color", new ActionMessage("errors.colorField.invalid"));
        }
        return errors;
    }
}

This is a simple model class:

package com.example.model;

import java.util.ArrayList;
import java.util.List;

public class Expert
{
    public List<String> getBrands(String color)
    {
        List<String> brands = new ArrayList<String>();
        if(color.equals("amber"))
        {
            brands.add("Amberlin");
            brands.add("RRBest");
        }
        else if(color.equals("light"))
        {
            brands.add("Too Light");
        }
        else if(color.equals("dark"))
        {
            brands.add("Dark");
            brands.add("Gray");
        }
        else
        {
             brands.add("OtherColor");
             brands.add("OtherBrand");
        }
        return brands;
    }
}

This is my struts-config.xml

<struts-config>
    <form-beans>
        <form-bean name="selectFormOne" type="com.example.web.SelectForm" />
    </form-beans>
 <action-mappings>
        <action name="selectFormOne" path="/SelectColor" type="com.example.web.SelectAction" scope="request" validate="true" input="/form.jsp">
            <forward name="show_results" path="/result.jsp" />
        </action>
    </action-mappings>
<message-resources parameter="com/myapp/struts/ApplicationResource"/>
</struts-config>

This is my input JSP: "form.jsp"

<%@taglib prefix="html" uri="http://jakarta.apache.org/struts/tags-html" %>

<html:html>
    <html:form action="/SelectColor">
        Select Color:
        <html:select property="color">
            <html:option value="light">light</html:option>
            <html:option value="amber">amber</html:option>
            <html:option value="dark">dark</html:option>
            <html:option value="brown">brown</html:option>
            <html:option value="red">red</html:option>
        </html:select>
         <html:submit />
    </html:form>
</html:html>

This is the output JSP: "result.jsp"

<%@ taglib uri="http://jakarta.apache.org/struts/tags-bean" prefix="bean" %>
<%@ taglib uri="http://jakarta.apache.org/struts/tags-html" prefix="html" %>
<%@ taglib uri="http://jakarta.apache.org/struts/tags-logic" prefix="logic" %>

<html:html>
    <title><bean:message key="welcome.title"/></title>
    <logic:iterate name="styles" id="Types" scope="request">
        <bean:write name="Types" property="brands" />
    </logic:iterate>
</html:html>

And the Exception stacktrace is:
javax.servlet.ServletException: No getter method for property: "brands" of bean: "Types"
org.apache.jasper.runtime.PageContextImpl.doHandlePageException(PageContextImpl.java:841)
org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:774)
org.apache.jsp.result_jsp._jspService(result_jsp.java:134)
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:331)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:329)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
org.apache.struts.action.RequestProcessor.doForward(RequestProcessor.java:1085)
org.apache.struts.tiles.TilesRequestProcessor.doForward(TilesRequestProcessor.java:263)
org.apache.struts.action.RequestProcessor.processForwardConfig(RequestProcessor.java:398)
org.apache.struts.tiles.TilesRequestProcessor.processForwardConfig(TilesRequestProcessor.java:318)
org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:241)
org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196)
org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:432)
javax.servlet.http.HttpServlet.service(HttpServlet.java:647)
javax.servlet.http.HttpServlet.service(HttpServlet.java:729)

Kindly help me in resolving the issue.

Thanks & Regards,
Vijay

[Balagopal Kannampallil]

I can see that in your execute method you are creating a List of String

List<String> result = be.getBrands(myForm.getColor()); //List of Strings

and putting this list into request. In the resultant jsp you are trying to get this list (which contains only Strings) from request and trying to access a property brands from it which the list of Strings has no clue of.

    
<logic:iterate name="styles" id="Types" scope="request">   //styles=List of String for which you are giving an id Types
     <bean:write name="Types" property="brands" />   //Oops Types is a list of String...I don't have a property brands
</logic:iterate>