Stylistic Question

[Alex Birmingham]

Hey All -

Re-creating a class in my MUD, and looking for stylistic suggestions and general feedback on my code before I convert ~30 legacy children. The class is called ActionEvent, and essentially represents any kind of action - such as an attack - in the game. ActionEvent objects deal with action mechanics (which sometimes contain sub-events, IE component ActionEvents) and narratives.

Here's one child I have converted so far:

/* Basic attack.
 * - Model for composition of rest of ActionEvents. */
package navea.actionEvents;

import java.util.ArrayList;
import navea.actionClasses.ActionEvent;
import navea.actionClasses.Narrative;
import navea.mobs.Mob;
import navea.system.Targetable;

public class AttackEvent extends ActionEvent {

	private static int roundTime = 5;
	private static boolean roundTimeEffected = true;
	
	public AttackEvent(Mob actor, Targetable target) {
		super(actor, target);
	}
	
	protected void logic() {
		// Numbers
		String weapon = actor.stats().weapon(); 		// Temp
		int attackStrength = actor.stats().attackStrength();
		int defenseStrength = ((Mob) target).stats().defenseStrength();
		int dRoll = (int) (100*Math.random()) + 1;
		int endRoll = attackStrength - defenseStrength + 30 + dRoll;
		int damage = endRoll - 100;
		
		// Sub-Events
		addEvent(new LoseHealthEvent((Mob) target, damage));
		addEvent(new RoundTimeEvent(actor, roundTime));
		
		// Narratives
		addNarrative(new Narrative(actor, "You swing " + weapon + " at " + target.name() + "!\n"));
		addNarrative(new Narrative(actor, "AS: +" + attackStrength + " vs DS: +" + defenseStrength + " with AvD: +30 +d100 roll: +" + dRoll + " = " + endRoll));
		addNarrative(new Narrative(actor, "A clean miss!")); 		// Temp
		
		addNarrative(new Narrative((Mob) target, actor.name() + " swings " + weapon + " at you!\n"));
		addNarrative(new Narrative((Mob) target, "AS: +" + attackStrength + " vs DS: +" + defenseStrength + " with AvD: +30 +d100 roll: +" + dRoll + " = " + endRoll));
		addNarrative(new Narrative((Mob) target, "A clean miss!")); //  Temp
		
		ArrayList<Mob> thirdPersons = new ArrayList<Mob>(actor.getMobs());
		thirdPersons.remove(target);
		for(Mob m: thirdPersons) {
			addNarrative(new Narrative(m, actor.name() + " swings " + weapon + " at you!\n"));
			addNarrative(new Narrative(m, "AS: +" + attackStrength + " vs DS: +" + defenseStrength + " with AvD: +30 +d100 roll: +" + dRoll + " = " + endRoll));
			addNarrative(new Narrative(m, "A clean miss!")); 		//  Temp
		}
	}
}

...and component class RoundTimeEvent...

/* Adds round time to a mob */
package navea.actionEvents;

import navea.actionClasses.ActionEvent;
import navea.actionClasses.Narrative;
import navea.mobs.Mob;

public class RoundTimeEvent extends ActionEvent {

	private int seconds;
	
	public RoundTimeEvent(Mob target, int seconds) {
		super(target, target);
	}
	
	protected void logic() {
		actor.addRoundTime(seconds);
		addNarrative(new Narrative(actor, "Roundtime: " + seconds + " sec."));
	}
	
}

PS - Apologies for the screen widening effect, wanted to convey exactly how it's coded. Most sincere thanks in advance!

[Campbell Ritchie]

Alex Birmingham wrote:. . . Apologies for the screen widening effect . . . Most sincere thanks in advance!

Apologies accepted

But it is good style to put line breaks (and additional indentation) in such long lines.

[Martijn Verburg]

One really quick thing, you seem to have some repeated strings in the code. Also, if you want your MUD to be international then you're going to have to thing about externalising those strings

Some javadoc might also assist other developers as to what's going on (although most of it is pretty clear), I think the thirdPersons bit could do with a comment as to 'what' they are.

Can't really comment on the architecture, but it looks like you're queuing up events and narratives, seems like a reasonable thing to do, as long as thos data structures don't get corrupted (I assume this is all multithreaded...)