Show only one record instead of specific record when onclick

[Loh Peggie]

Hey guys, i am facing a huge problem in my update form:(

Like when I click on 1101, it show the records of 1101 to be updated.
But when I click on 1102, it still show the 1101 record instead of 1102. Which mean whatever product I click on it will still be the same 1101 record:(
My servlets codes are:

package sg.edu.nyp.feppz;

import java.io.IOException;
import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.PreparedStatement;



import javax.servlet.RequestDispatcher;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import sg.edu.nyp.feppz.user.User;



public class EditProductsAdmin extends HttpServlet {
	private static final long serialVersionUID = 1L;
       
  
    public EditProductsAdmin() {
        super();
        // TODO Auto-generated constructor stub
    }

	/**
	 * @see HttpServlet#doGet(HttpServletRequest request, HttpServletResponse response)
	 */
	protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
		// TODO Auto-generated method stub
	}

	/**
	 
	 * @see HttpServlet#doPost(HttpServletRequest request, HttpServletResponse response)
	 */



protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {

	//Retreive the user data from the session object
	User user = (User)request.getSession().getAttribute("USER_DATA");

	//Retrieve the user data from the session object
	
	
	//retrieve the feedback text from the form in the CreateNewItem.jsp file
	if(request.getParameter("ProductId") == null || request.getParameter("ProductName").equals(""))
	if(request.getParameter("ProdColor") == null || request.getParameter("ProdDesc").equals(""))
	if(request.getParameter("UnitPrice") == null || request.getParameter("Quantity").equals(""))
	if(request.getParameter("ProdCatId") == null || request.getParameter("UserId").equals(""))	
	
	if(request.getParameter("ProdImage") == null || request.getParameter("").equals(""))	
	{
		//if it is null => something is wrong, send the browser back to the
		//CreateNewItem.jsp file
		request.setAttribute("ERROR_MESSAGE", "");
		RequestDispatcher rd = request.getRequestDispatcher("EditProductsAdmin.jsp");
		rd.forward(request, response);		}
	
	//Connect to database
	try {
		//Ensure the the driver class is loaded.
		Class.forName("com.mysql.jdbc.Driver");
		//Create a connection to our database.
		//localhost = server name
		//feppz = database name
		//root = user name, password = empty
		Connection con = DriverManager.getConnection("jdbc:mysql://localhost/feppz", "root", "");
		//create an SQL statement, ? marks denote values that we will add later
		PreparedStatement update = con.prepareStatement("UPDATE products set ProductId=? ,ProdName= ?, ProdColor=?, ProdDesc=?, UnitPrice=?, Quantity=?, ProdCatId=?, UserId=?, ProdImage=?   WHERE ProductId = ? ");
		
                //replace first ? mark with values from the feedbackText text box
		update.setInt(1, Integer.parseInt(request.getParameter("ProductId")));
		
                    
                    


                   //replace second ? mark with user's id
		update.setString(2, request.getParameter("ProdName"));
		
                    //replace second ? mark with user's id
		update.setString(3, request.getParameter("ProdColor"));
		
                     //replace second ? mark with user's id
		update.setString(4, request.getParameter("ProdDesc"));
		
                    //replace second ? mark with user's id
		update.setFloat(5, Float.parseFloat(request.getParameter("UnitPrice")));
		
                    //replace second ? mark with user's id
		update.setString(6, request.getParameter("Quantity"));
		
                    //replace second ? mark with user's id
		update.setInt(7, Integer.parseInt(request.getParameter("ProdCatId")));
		
                   
		
                    //replace second ? mark with user's id
		update.setInt(8, user.getUserId());
		
		
		
                     update.setString(9, request.getParameter("ProdImage"));
		
		// Execute to insert into the database
		update.setString(10, request.getParameter("ProductId"));
		update.executeUpdate();
		//close connection
		con.close();
		//redirect user to FeedbackSuccess.jsp page
		response.sendRedirect("EditProductsAdminS(A).jsp");
		
	}  catch (Exception e) {
		//Some error has occurred, save an error message into the request
		//object, this will be displayed in the login.jsp file
		e.printStackTrace();
		request.setAttribute("ERROR_MESSAGE", "Please fill up all the fields.");
		RequestDispatcher rd = request.getRequestDispatcher("EditProductsAdmin(A).jsp");
		rd.forward(request, response);
		return;
	}
	
}

}

My jsp code is:

<p>     
          <%   
            //1. Retrieve all products from database   
               
            //1a.  Load the Driver   
            Class.forName("com.mysql.jdbc.Driver");   
            //1b.  Get a connection to the database   
            Connection con = DriverManager.getConnection("jdbc:mysql://localhost/feppz", "root", "");   
            //1c. Construct our SQL statement   
            PreparedStatement update = con.prepareStatement("SELECT * FROM products");   
            //1d.  Execute and retrieve our result   
            ResultSet rs = update.executeQuery();   
               
            //2. Base on the results returned, construct a table   
        %>   
        </p>   
        
        <fieldset height="145" width="145">   
 
<%
int RecordCounter = 0; //initialize currentrow counter
int numcolumns = 1; //columns you want
%>

 
        <table border="0">
        <tr>    
        <td> Item </td>  
        </tr>
         <%     
            
if(rs.next()) {        
  // for making sure you dont miss the first record.      
//while(rs.next())      
//{     }                   // opening while loop brackets.      
     
         %>        
       
    
    <div align="center">
    <p align="left"> 
     <form method="post" action="./EditProductsAdmin ">
    <table class="coll" align="center" width="645" height="219" border="0">
       
     <tr>
     <td> ProductId :          <input type="" readonly id="ProductId" name="ProductId" value="<%=rs.getInt("ProductId")%>"/></td>  
     </tr>
     <tr>
     <td> ProdName Name :      <input type="text" id = "ProdName" name="ProdName" value="<%=rs.getString("ProdName") %>"/></td>  
     </tr>
     <tr>
     <td> Product Color :  <input type="text" id = "ProdColor" name="ProductColor" value="<%=rs.getString("ProdColor") %> "/></td>  
     </tr> 
     <tr>
     <td> Product Description :       <input type="text" id = "ProdDesc" name="ProdDesc" value="<%=rs.getString("ProdDesc") %> "/></td>  
     </tr>
     
     <tr>
     <td> Unit Price :       <input type="text" id = "Unit Price" name="UnitPrice" value="<%=String.format("$%.2f",rs.getDouble("UnitPrice"))+"\t" %> "/></td>  
     </tr>
     
      <tr>
     <td> Quantity :       <input type="text" id = "Quantity" name="Quantity" value="<%=rs.getString("Quantity") %> "/></td>  
     </tr>
     
      <tr>
     <td>Product Category Id :       <input type="text" id = "ProdCatId" name="ProdCatId" value="<%=rs.getInt("ProdCatId") %> "/></td>  
     </tr>
     
      <tr>
     <td>User Id :       <input type="text" id = "UserId" name="UserId" value="<%=rs.getInt("UserId") %> "/></td>  
     </tr>
     
     <tr>
     <td>Product Image :       <input type="text" id = "ProdImage" name="ProdImage" value="<%=rs.getString("ProdImage") %> "/></td>  
     </tr>
     
     <%} 
         
     rs.beforeFirst();
     %>
     <%if(rs.next()){ %>
     
		          <%} %>
</table>
<div align="center">
     <br></br><input type="submit" value="Update" /></form>
    </div></td>
</tr>   	

My database attribitues are:
ProductId
ProdName
ProdColor
ProdDesc
UnitPrice
Quantity
ProdCatId
UserId
ProductImage

Thanks:)

I need it urgently.
You guys are a great help to me!
Really:D

[Jeanne Boyarsky]

Loh,
I don't see a where clause in your JSP. Doesn't that just make it always write out the first record in the database?

As an aside, it's not considered good practice to have JDBC code in a JSP.

[Loh Peggie]

I see i see.
But when I change the statement to :SELECT * FROM products where ProductId = '?' "

The text field will be empty:(

[Jeanne Boyarsky]

SELECT * FROM products where ProductId = '?'

I can think of a couple causes:
1) You shouldn't have the single quotes around the '?'. PreparedStatements take care of that for you and it could cause the database confusing.
2) Is there whitespace in the id in the database? If so, you'll need to call trim() in your SQL statement.

Also, does that query return no data for record 1001 as well or just 1002? The answer will narrow down the field of problems a bit.