Pass bean from one action to another in strust2

[Deeps Mistry]

Hi,

I have a form wherein i fill in the details and click on Save button.
I do the validation of one of the fields in my action class.
If my validation returns true i redirect it to another action class to save the form data into database.
If my validation fails i redirect it to the jsp page.

My jsp:

<s:form action="/customer/validateCustomer" method="POST">
			  <s:actionerror/>
			  <table width="496" height="110" border="0" cellpadding="0" cellspacing="0">
                <tr>
                  <td colspan="2">
                      <label for="CID">Customer ID:</label>
                      <s:textfield maxlength="3" value="" id="cid" name="custInfo.cid" size="3"/>                   
                   	  	<span style="FONT-SIZE:9px;"> (Enter upto 3 characters)</span>
                      <label for="CNAME">Customer Name</label>
                      <s:textfield id="cname" name="custInfo.name" size="30"/>
                      <label for="ADD1">Address Line1</label>
                      <s:textfield id="add1" name="custInfo.addr1" size="50"/>
                      <label for="ADD2">Address Line2</label>
                      <s:textfield id="add2" name="custInfo.addr2" size="50"/>
                      <label for="CCITY">City</label>
                      <s:textfield id="city" name="custInfo.city"/>
                      <label for="CPIN">PIN Code</label>
                      <s:textfield maxlength="6" id="pin" name="custInfo.pin" size="6"/>
                      <br/>
                  </td>
            	</tr>
            		<tr>
            			<td width="11%">         
                    	    <s:submit value="Save" onclick="return submitForm();" align="left"/>
                       	</td>
                    	<td>
                      		<s:reset value="Reset" onclick="clearForm();" align="left"/>
                        </td>
                </tr>
              </table>
              </s:form>

actions.xml:

<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE struts PUBLIC
        "-//Apache Software Foundation//DTD Struts Configuration 2.0//EN"
        "http://struts.apache.org/dtds/struts-2.0.dtd">

<struts>

	

	<package name="customer" namespace="/customer" extends="struts-default">


		<action name="addCustomer">
			<result type="redirect">CustomerActions.action</result>
			
		</action>
		
		<action name="CustomerActions" method="getCustomerInfo" class="ActionClass.CustomerAction">
			<result>/pages/addcustomer.jsp</result>
			
		</action>
		
		<action name="validateCustomer" method="validateCustomer" class="ActionClass.AuthenticateCIDAction">
			[color=red]<result type="redirect">SaveCustomer.action</result>[/color]   
			<result name="error">/pages/addcustomer.jsp</result>
			
		</action>
		
		<action name="SaveCustomer" method="addCustomer" class="ActionClass.CustomerAction">
			<result type="redirect">CustomerActions.action</result>
		</action>
		
		
	</package>
</struts>

Action class:
1) CustomerAction

package ActionClass;

import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.Statement;
import java.util.List;
import java.util.Map;

import org.apache.struts2.components.ActionError;

import ActionForm.AddCustomerForm;
import ActionForm.CustomerInfoBean;

import com.opensymphony.xwork2.ActionContext;
import com.opensymphony.xwork2.ActionSupport;

import dao.CustomerService;

public class CustomerAction extends ActionSupport {

	public String execute() throws Exception {

			return SUCCESS;
	}

	//for customer info
	private CustomerInfoBean custInfo;
	private List lstCustInfo = null;
	
	
	
	

	public List getLstCustInfo() {
		return lstCustInfo;
	}


	public void setLstCustInfo(List lstCustInfo) {
		this.lstCustInfo = lstCustInfo;
	}


	public CustomerInfoBean getCustInfo() {
		return custInfo;
	}


	public void setCustInfo(CustomerInfoBean custInfo) {
		this.custInfo = custInfo;
	}



	public String getCustomerInfo() throws Exception {
		
	
		List lstCustInfo = CustomerService.getCustomerInfo();
		setLstCustInfo(lstCustInfo);
			
		return execute();
	}
	
	

	public String addCustomer() throws Exception {
	
	[color=red]System.out.println("CID:" + custInfo.getCid());[/color]   //getting null pointer exception over here.
	CustomerService.addCustomerInfo();
	return execute();
	}


}
   

2)AuthenticateCIDAction:

  package ActionClass;

import java.util.Map;

import ActionForm.CustomerInfoBean;

import com.opensymphony.xwork2.ActionContext;
import com.opensymphony.xwork2.ActionSupport;

import dao.CustomerService;

public class AuthenticateCIDAction extends ActionSupport {

	public String execute() throws Exception {

		if(isAuthenticate())
			return SUCCESS;
		else{
				addActionError("Customer ID already exists");
	        return ERROR;
		}

	}
	
	private boolean authenticate;
	private CustomerInfoBean custInfo;

	
	public boolean isAuthenticate() {
		return authenticate;
	}

	public void setAuthenticate(boolean authenticate) {
		this.authenticate = authenticate;
	}
	
	public CustomerInfoBean getCustInfo() {
		return custInfo;
	}

	public void setCustInfo(CustomerInfoBean custInfo) {
		this.custInfo = custInfo;
	}
	
	
	public String validateCustomer() throws Exception {
		
		
		setAuthenticate(CustomerService.validateCID(custInfo));
		Map session = ActionContext.getContext().getSession();
		session.put("custInfo", custInfo);
		return execute();
	}



}
  

3)Dao:

 package dao;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.ArrayList;
import java.util.Map;


import javax.servlet.http.HttpServletRequest;



import com.opensymphony.xwork2.ActionContext;

import org.apache.catalina.Session;
import org.apache.struts.action.ActionError;
import org.apache.struts.action.ActionErrors;
import ActionClass.DBInformation;
import ActionForm.AddCustomerForm;
import ActionForm.CustomerInfoBean;


public class CustomerService {
	
	public static boolean validateCID(CustomerInfoBean custInfo) throws Exception {
		PreparedStatement pstatement = null;
		Connection con = null;
		Statement stmt = null;
		ResultSet rs = null;
		HttpServletRequest request;
		boolean authenticate = true;
		System.out.println("in validate action");
		try {
			
			Class.forName(DBInformation.DRIVER);
			String url = DBInformation.URL;
			con = DriverManager.getConnection(url,
					DBInformation.USER, DBInformation.PASSWORD);
			
			
				String strQuery = "select CID from CustomerInfo";
		        stmt = con.createStatement();
		     
		      rs = stmt.executeQuery(strQuery);
		      
		      ActionErrors actionErrors = new ActionErrors();
		      while(rs.next())
		      {
		    	  if(rs.getString(1).equals(custInfo.getCid()))
		    	  {
		    		 authenticate = false;
		    	  }
		    	 
		      }
		

		}
		catch (SQLException objSQLException) {
			System.err.println("Exception in authneticate CID: "+objSQLException.getMessage());
		}
		catch (Exception e) {
			throw e;

		}
		finally
		{
			con.close();
		}
		return authenticate;
	}
	
	public static void addCustomerInfo() throws Exception {
		PreparedStatement pstatement = null;
		Connection con = null;
		Statement stmt = null;
		ResultSet rs = null;
		HttpServletRequest request;
		boolean authenticate = true;
		System.out.println("in add customer action");
		try {
			
			Class.forName(DBInformation.DRIVER);
			String url = DBInformation.URL;
			con = DriverManager.getConnection(url,
					DBInformation.USER, DBInformation.PASSWORD);
			Map session = ActionContext.getContext().getSession();
			
			CustomerInfoBean custInfo = (CustomerInfoBean) session.get("custInfo");
				String strQuery = "Insert into CustomerInfo values(?,?,?,?,?,?)";
		     
				pstatement = con.prepareStatement(strQuery);
				pstatement.setString(1, custInfo.getCid());
				pstatement.setString(2, custInfo.getName());
				pstatement.setString(3,custInfo.getAddr1());
				pstatement.setString(4, custInfo.getAddr2());
				pstatement.setString(5, custInfo.getCity());
				pstatement.setString(6, custInfo.getPin());
		      
				pstatement.executeUpdate();
		

		} 
		catch (SQLException objSQLException) {
			System.err.println("Exception in Add Customer: "+objSQLException.getMessage());
		}
		catch (Exception e) {
			throw e;

		}
		finally
		{
			con.close();
		}
		
	}
	
	
	public static ArrayList getCustomerInfo() throws Exception {
		PreparedStatement pstatement = null;
		Statement stmt = null;
		Connection con = null;
		ResultSet rs = null;
		ArrayList<Object> arrCustInfo = null;
		CustomerInfoBean objCustomerInfoBean = null;
		try {
			

			Class.forName(DBInformation.DRIVER);
			String url = DBInformation.URL;
			con = DriverManager.getConnection(url,
					DBInformation.USER, DBInformation.PASSWORD);
			
			stmt = con.createStatement();
 			  rs= stmt.executeQuery("select * from CustomerInfo");
 			  
 			arrCustInfo = new ArrayList<Object>();
				while(rs.next())
				{
					objCustomerInfoBean = new CustomerInfoBean();
					objCustomerInfoBean.setCid(rs.getString(1));
					objCustomerInfoBean.setName(rs.getString(2));
					String strAddr = rs.getString(3)+" "+ rs.getString(4)+" "+ rs.getString(5)+" "+ rs.getString(6);
					System.out.println("ADDR::"+strAddr);
					objCustomerInfoBean.setAddr(strAddr);
					
					arrCustInfo.add(objCustomerInfoBean);
				
				}

				

		} 
		catch (SQLException objSQLException) {
			System.err.println("Exception in Get Customer List: "+objSQLException.getMessage());
		}
		catch (Exception e) {
			throw e;
		}
		finally
		{
			con.close();
		}
		return arrCustInfo;
	}

}
   

What am i doing wrong?

Thanks

[David Newton]

You don't say what the problem is.

[Deeps Mistry]

David Newton wrote:You don't say what the problem is.

I want to retrieve the form information in my CustomerAction class.

I am getting null pointer exception as shown above.

Thanks

[David Newton]

"As shown above"? Really? I'm supposed to spot the line that looks the same as all the other lines with a comment in it?!

If you redirect anything in the action will be lost: actions are created per-request.

[Deeps Mistry]

David Newton wrote:"As shown above"? Really? I'm supposed to spot the line that looks the same as all the other lines with a comment in it?!

If you redirect anything in the action will be lost: actions are created per-request.

Hey..
I am sorry for that "as shown above thing".

   public String addCustomer() throws Exception {  
     [color=red]System.out.println("CID:" + custInfo.getCid());[/color]   //getting null pointer exception over here.  
    CustomerService.addCustomerInfo();  
     return execute();  
    }    

If not redirect, how else can i call my action class such that the bean info remains intact?
Currently i am putting my bean in the session. But by doing this i am going anti-struts.

Thanks

[David Newton]

There's nothing "anti-Struts" about using the session; that's what the session is there for.

Why do you redirect to the form page on a validation error? If you forwarded there wouldn't be an issue.

[Deeps Mistry]

David Newton wrote:There's nothing "anti-Struts" about using the session; that's what the session is there for.

Why do you redirect to the form page on a validation error? If you forwarded there wouldn't be an issue.

I tried <result type="forward">, but i get an error saying "forward" is not recognised..

Thanks

[Deeps Mistry]

Deeps Mistry wrote:

David Newton wrote:There's nothing "anti-Struts" about using the session; that's what the session is there for.

Why do you redirect to the form page on a validation error? If you forwarded there wouldn't be an issue.

I tried <result type="forward">, but i get an error saying "forward" is not recognised..

Thanks

I also tried <result="dispatcher">, but i get an error message saying "The Requested resource is not available". Is it it that i can only dispatch it to a jsp and not an action?

Any help would be highly appreciated.

Thanks

[Deeps Mistry]

Deeps Mistry wrote:

Deeps Mistry wrote:

David Newton wrote:There's nothing "anti-Struts" about using the session; that's what the session is there for.

Why do you redirect to the form page on a validation error? If you forwarded there wouldn't be an issue.

I tried <result type="forward">, but i get an error saying "forward" is not recognised..

Thanks

I also tried <result="dispatcher">, but i get an error message saying "The Requested resource is not available". Is it it that i can only dispatch it to a jsp and not an action?

Any help would be highly appreciated.

Thanks

Hi,



Here is the code:

  <action name="validateCustomer" method="validateCustomer" class="ActionClass.AuthenticateCIDAction">
			<result type="chain">SaveCustomer.action</result>
			<result name="error">/pages/addcustomer.jsp</result>
		</action>
		
		<action name="SaveCustomer" method="addCustomer" class="ActionClass.CustomerAction">
			<result type="redirect">CustomerActions.action</result>
		</action>  

I validate the form fields using AuthenticateCIDAction. If success, then i add the information to the db. So i forward it to my next action class CustomerAction.
I want the form data intact, so i cannot use "redirect " as my result type.
Hence i used "chain" result type.

I tried using chain result type. But getting an error saying "The requested resource (There is no Action mapped for namespace /customer and action name SaveCustomer.action.) is not available.

Is there a problem with the syntax? or am i missing something?

Thanks.

[Jayaraj Jaganathan]

I too have the same issue. i am looking for a answer :(

I hope that we have done mistake in interceptors

https://coderanch.com/t/475156/Struts/Application-Frameworks/Struts-Chain-Result-Type