Table size is coming as a full size of a frame when i used gridlayout, please Help me

[Karan Das]

JFrame newFrame= new JFrame();

newFrame.setLayout(new GridLayout(7, 1));
String[] pId = {"2008-10-05", "2009-10-09", "2009-01-01"};
prptCombo = new JComboBox(pId);
pIdlabel = new JLabel("PrppertyId");
ownerLabel = new JLabel("Owner Details");
ownerTextArea = new JTextArea();
ownerTextArea.setColumns(20);
ownerTextArea.setRows(5);
JPanel newPanel1 = new JPanel();
JPanel newPanel2 = new JPanel();
JPanel newPanel3 = new JPanel();
JPanel newPanel4 = new JPanel();
JPanel newPanel5 = new JPanel();
JPanel newPanel6 = new JPanel();
JPanel newPanel7 = new JPanel();
taxLabel = new JLabel("Tax");


//Adding table area
JTable jTable1 = new JTable();

String[] columnNames = {"2000-01",
"2001-02",
"2002-03",
"2003-04",
"2004-05",
"2005-06",
"2006-07",
"2007-08",
"2008-09",
"2009-10"};

Object[][] data = {
{null, null,
null, null, null, null, null, null, null, null}
};



final JTable table = new JTable(data, columnNames);

table.setPreferredScrollableViewportSize(new Dimension(500, 500));
table.setFillsViewportHeight(true);
JScrollPane scrollPane = new JScrollPane(table);
JScrollPane scrollPane1 = new JScrollPane(ownerTextArea);

//Adding values are panel
newPanel1.add(pIdlabel);
newPanel1.add(prptCombo);
newPanel2.add(ownerLabel);
newPanel2.add(scrollPane1);
//newPanel5.add(taxLabel);


newPanel3.setLayout(new GridLayout(2,1));
scrollPane.setPreferredSize(new Dimension(200, 100));
newPanel3.add(taxLabel);
newPanel3.add(scrollPane);


JFrame frame2=new JFrame();
//adding panels to the frame
newFrame.add(newPanel4);
newFrame.add(newPanel1);
newFrame.add(newPanel2);
// newFrame.add(newPanel7);
// newFrame.add(newPanel5);
newFrame.add(newPanel3);
newFrame.add(newPanel6);

[Lou Caudell]

I didn't notice it in your code here, but it sounds as if you are setting the gbc fill to expand to available space.

[pete stein]

Don't use GridLayout here as it's not a good fit. There are many other layouts available, and I suggest that you practice using them all if you want to make your apps look better. For instance:

import java.awt.*;
import javax.swing.*;

public class SwingFoo {
  private static JComboBox prptCombo;
  private static JTextArea ownerTextArea;

  public static void main(String[] args) {
    SwingUtilities.invokeLater(new Runnable() {
      public void run() {
        createAndShowGUI();
      }
    });
  }
  public static void createAndShowGUI() {
    String[] pId = { "2008-10-05", "2009-10-09",
        "2009-01-01" };
    prptCombo = new JComboBox(pId);
    ownerTextArea = new JTextArea(5, 20);

    String[] columnNames = { "2000-01", "2001-02",
        "2002-03", "2003-04", "2004-05", "2005-06",
        "2006-07", "2007-08", "2008-09", "2009-10" };

    Object[][] data = { { null, null, null, null, null,
        null, null, null, null, null } };

    final JTable table = new JTable(data, columnNames);

    table.setPreferredScrollableViewportSize(new Dimension(800, 500));
    table.setFillsViewportHeight(true);

    JScrollPane tableScrollPane = new JScrollPane(table);
    JPanel tablePanel = new JPanel(new BorderLayout());
    tablePanel.add(new JLabel("Tax", SwingConstants.LEFT), BorderLayout.NORTH);
    tablePanel.add(tableScrollPane, BorderLayout.CENTER);

    JPanel detailsPanel = new JPanel(new BorderLayout());
    detailsPanel.add(new JLabel("Owner Details", SwingConstants.LEFT), BorderLayout.NORTH);
    detailsPanel.add(new JScrollPane(ownerTextArea));
    
    JPanel propertyIDPanel = new JPanel();
    propertyIDPanel.setLayout(new BoxLayout(propertyIDPanel, BoxLayout.PAGE_AXIS));
    JLabel propLabel = new JLabel("Property ID:", SwingConstants.LEFT);
    JPanel propLabelPanel = new JPanel(new FlowLayout(FlowLayout.LEFT, 0, 0));
    propLabelPanel.add(propLabel);
    propLabelPanel.setMaximumSize(new Dimension(1000, propLabelPanel.getPreferredSize().height));
    propertyIDPanel.add(propLabelPanel);
    prptCombo.setMaximumSize(new Dimension(1000, prptCombo.getPreferredSize().height));
    propertyIDPanel.add(prptCombo);
    propertyIDPanel.add(Box.createVerticalGlue());
    
    JPanel bottomPanel = new JPanel();
    bottomPanel.setLayout(new BoxLayout(bottomPanel, BoxLayout.LINE_AXIS)); 
    bottomPanel.add(detailsPanel);
    bottomPanel.add(Box.createHorizontalStrut(10));
    bottomPanel.add(propertyIDPanel);

    
    JPanel mainPanel = new JPanel(new BorderLayout(10, 10));
    mainPanel.setBorder(BorderFactory.createEmptyBorder(10, 10, 10, 10));
    mainPanel.add(tablePanel, BorderLayout.CENTER);
    mainPanel.add(bottomPanel, BorderLayout.SOUTH);
    
    JFrame newFrame = new JFrame();
    newFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    newFrame.getContentPane().add(mainPanel);
    newFrame.pack();
    newFrame.setLocationRelativeTo(null);
    newFrame.setVisible(true);

  }
}

[Rob Spoor]

Karan, next time please Use Code Tags.