FTP Woes! -Solved

[Jaz Chana]

Hi Guys,

So I'm using the apache commons classes and have created the following ftp method;

    

	public static void main(String argv[]) throws IOException {

		FTPClient client = new FTPClient();
		FileInputStream fis = null;

		client.connect("server");
		client.login("username", "pass");
		client.makeDirectory("testDir");
		client.changeWorkingDirectory("testDir");
		
		File file = new File("/Desktop/testDir");
		
		File[] fileArray = file.listFiles();

		client.setFileType(org.apache.commons.net.ftp.FTP.BINARY_FILE_TYPE);
		
		for(int i = 0; i < fileArray.length; i++){
			fis = new FileInputStream(fileArray[i]);
			client.storeFile(fileArray[i].getAbsolutePath(), fis);
			System.out.println("upload "+client.getReplyCode());
		}

		client.logout();
		client.disconnect();
	}

I ran the piece of code on a windows machine and no problems. I then ran the code on my mac and for some reason it doesn't work, to specify; the client logs in, it creates the testDir, but it doesn't upload any files. To make things worse theres little indication as to why it doesn't work. There is no stack trace, no error message, I've checked the permissions of the directory and its contents and they all seem to be readable and writable by all. I even created a FileOutputStream to write the contents of the FileInputStream on to the desktop so that I can verify that its actually working. And the files are written correctly, without any corruption. The only thing that indicates anything is wrong is the return code of the method getReplyCode(). After every attempt to upload I get the 500 response, so I looked this up and it means "Syntax error, command unrecognized. This may include errors such as command line too long". That's not very helpful unfortunately.


I'm at a loss here, because the same piece of code works fine on a windows machine. Is there anything that I could be missing?

Cheers

[Jaz Chana]

Okay so I figured out what the problem was. Basically I needed to set the following on my instance of ftp client;

  

client.setFileType(org.apache.commons.net.ftp.FTP.BINARY_FILE_TYPE);

because I'm uploading images not text files. And the following;

client.enterLocalPassiveMode();

I'm not 100% but i believe its because I'm behind a firewall. Also I found adding this piece of code really helps the debugging process;

  

client.addProtocolCommandListener(new PrintCommandListener(new PrintWriter(System.out)));

It basically outputs to the console everything that the server replies with.