How close am I in getting this program right?

[bue curt]

First of all, Happy new year!!!

  import java.io.*;

public class Main {
    public static void main(String[] args) {
        
          int input = 0;
          
           switch (input) {
            case 1:
                System.out.print("one ");
                break;
            case 2:
                System.out.print("two ");
                break;
            case 3:
                System.out.print("three ");
                break;
            case 4:
                System.out.print("four ");
                break;
            case 5:
                System.out.print("five ");
                break;
            case 6:
                System.out.print("six ");
                break;
            case 7:
                System.out.print("seven ");
                break;
            case 8:
                System.out.print("eight ");
                break;
            case 9:
                System.out.print("nine ");
                break;
        }
           
           
            switch (input) {
            case 11:
                System.out.print(" eleven");
                break;
            case 12:
                System.out.print(" twelve");
                break;
            case 13:
                System.out.print(" thirteen");
                break;
            case 14:
                System.out.print(" fourteen");
                break;
            case 15:
                System.out.print(" fifteen");
                break;
            case 16:
                System.out.print(" sixteen");
                break;
            case 17:
                System.out.print(" seventeen");
                break;
            case 18:
                System.out.print(" eighteen");
                break;
            case 19:
                System.out.print(" nineteen");
                break;
        }
          switch (input) {
            case 1:
                System.out.print(" ten ");
            case 2:
                System.out.print(" twenty ");
                break;
            case 3:
                System.out.print(" thirty ");
                break;
            case 4:
                System.out.print(" forty ");
                break;
            case 5:
                System.out.print(" fifty ");
                break;
            case 6:
                System.out.print(" sixty ");
                break;
            case 7:
                System.out.print(" seventy ");
                break;
            case 8:
                System.out.print(" eighty ");
                break;
            case 9:
                System.out.print(" ninety ");
                break;
        }
          switch (input) {
            case 1:
                System.out.print("one hundred ");
                break;
            case 2:
                System.out.print("two hundred ");
                break;
            case 3:
                System.out.print("three hundred ");
                break;
            case 4:
                System.out.print("four hundred ");
                break;
            case 5:
                System.out.print("five hundred ");
                break;
            case 6:
                System.out.print("six hundred ");
                break;
            case 7:
                System.out.print("seven hundred ");
                break;
            case 8:
                System.out.print("eight hundred ");
                break;
            case 9:
                System.out.print("nine hundred ");
                break;
        }
      
          
          System.out.print("Enter a number between 0 and 999: ");
                
          BufferedReader BR = new BufferedReader(new InputStreamReader(System.in));
           String n = "";
            int p = Integer.parseInt(n);
                  
                   if (p > 99 && p < 1000) {
                     int h = p/100;
                        System.out.println(h);
                      int x = p % 100;        
                      if (x > 10 && x < 20) {  
                        System.out.println(x);   
                   }
                  
                     if (x > 0 && x < 100) {
                        int y = x / 10;   
                         System.out.println(y);         

                         int z = x % 10;  
                          System.out.println(z);        
            }
        }
                      if ( p > 19 && p < 100) {
                        int t = p / 10;    
                          System.out.println(t);                
                        int u = p % 10;    
                          System.out.println(u);  
        }
                        if (p > 10 && p < 20) { 
                           System.out.println(p);        
        }
                        if (p < 10) {           
                            System.out.println(p);          
        }
    }
}
  

Hi, I'm beginner learning programming . The goal of this java program is to convert an integer ranging from 0-999 to its word equivalent, and it should ask the user if he/she still wants to enter a new number(I have no idea how can I make that possible )
I'm not even sure of this codes are close enough to attain that goal.

Can you point out my errors? What should I change? Am I getting there?

Any help is appreciated.

Have a nice day!

[Campbell Ritchie]

For repetition until somebody writes "stop" try this old thread and see if you can get it faster than Robin did.

[bue curt]

Campbell Ritchie wrote:For repetition until somebody writes "stop" try this old thread and see if you can get it faster than Robin did.

We are not allowed to use that code.
Switch,if,if else,while,do while,for loop are the only allowed method.

[Henry Wong]

bue curt wrote:
I'm not even sure of this codes are close enough to attain that goal.

Can you point out my errors? What should I change? Am I getting there?

Does it compile? And if it doesn't what is the error?

Does it run? And if it does, what happens?


Generally, the easiest way to find an error is to figure out what is wrong first.

Henry

[bue curt]

Does it compile? And if it doesn't what is the error?

Does it run? And if it does, what happens?


Generally, the easiest way to find an error is to figure out what is wrong first.

Henry

The build is successful but it does not run.

  Exception in thread "main" java.lang.NumberFormatException: For input string: ""
        at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
        at java.lang.Integer.parseInt(Integer.java:470)
Enter a number between 0 and 999: 
        at java.lang.Integer.parseInt(Integer.java:499)
        at javaapplication2.Main.main(Main.java:133)
Java Result: 1
BUILD SUCCESSFUL (total time: 1 second)
  

[Harold Lime]

The code you have is overly complicated IMO.

I'd break down how you would do this on paper first, then figure out how to do that with Java.

Something like:

- Read input
- Is it a number?
- Is it the specified range?
- Is is a 3 digit number?
- Does it end with a number below 21?


Or you could just create a 1000 element array and fill it with all the answers.

[Ashish Schottky]

Can you provide me with an example of the output.
e.g. 1500 can be 'Fifteen Hundred' or One Thousand Five Hundered.
So if you give me the desired out put may be I can help you.

[Henry Wong]

bue curt wrote:

  Exception in thread "main" java.lang.NumberFormatException: For input string: ""
        at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
        at java.lang.Integer.parseInt(Integer.java:470)
Enter a number between 0 and 999: 
        at java.lang.Integer.parseInt(Integer.java:499)
        at javaapplication2.Main.main(Main.java:133)
Java Result: 1
BUILD SUCCESSFUL (total time: 1 second)
  

Well... What do you think this error message is saying? For a beginner, it may be daunting, but take a shot at it... It is actually quite easy. Getting comfortable with reading these errors messages, is needed in getting good at finding the errors.

Henry

[Harold Lime]

The build is successful but it does not run.

  Exception in thread "main" java.lang.NumberFormatException: For input string: ""
        at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
        at java.lang.Integer.parseInt(Integer.java:470)
Enter a number between 0 and 999: 
        at java.lang.Integer.parseInt(Integer.java:499)
        at javaapplication2.Main.main(Main.java:133)
Java Result: 1
BUILD SUCCESSFUL (total time: 1 second)
  

I've removed what I first wrote.

Check this: http://java.sun.com/javase/6/docs/api/java/io/BufferedReader.html to see how you might go about getting input from the user.

[bue curt]

Ashish Schottky wrote:Can you provide me with an example of the output.
e.g. 1500 can be 'Fifteen Hundred' or One Thousand Five Hundered.
So if you give me the desired out put may be I can help you.

The range of number is 0-999 only.
so
124 will be one hundred twenty four

Or you could just create a 1000 element array and fill it with all the answers.

That is my last option. I hope I would never do it

[bue curt]

I have the working code, but instead of word equivalent it prints numbers.

   import java.io.*;

public class Main {
    public static void main(String[] args) {
       
          int input = 0;
         
           switch (input) {
            case 1:
                System.out.print("one ");
                break;
            case 2:
                System.out.print("two ");
                break;
            case 3:
                System.out.print("three ");
                break;
            case 4:
                System.out.print("four ");
                break;
            case 5:
                System.out.print("five ");
                break;
            case 6:
                System.out.print("six ");
                break;
            case 7:
                System.out.print("seven ");
                break;
            case 8:
                System.out.print("eight ");
                break;
            case 9:
                System.out.print("nine ");
                break;
        }
           
           
            switch (input) {
            case 11:
                System.out.print(" eleven");
                break;
            case 12:
                System.out.print(" twelve");
                break;
            case 13:
                System.out.print(" thirteen");
                break;
            case 14:
                System.out.print(" fourteen");
                break;
            case 15:
                System.out.print(" fifteen");
                break;
            case 16:
                System.out.print(" sixteen");
                break;
            case 17:
                System.out.print(" seventeen");
                break;
            case 18:
                System.out.print(" eighteen");
                break;
            case 19:
                System.out.print(" nineteen");
                break;
        }
          switch (input) {
            case 1:
                System.out.print(" ten ");
            case 2:
                System.out.print(" twenty ");
                break;
            case 3:
                System.out.print(" thirty ");
                break;
            case 4:
                System.out.print(" forty ");
                break;
            case 5:
                System.out.print(" fifty ");
                break;
            case 6:
                System.out.print(" sixty ");
                break;
            case 7:
                System.out.print(" seventy ");
                break;
            case 8:
                System.out.print(" eighty ");
                break;
            case 9:
                System.out.print(" ninety ");
                break;
        }
          switch (input) {
            case 1:
                System.out.print("one hundred ");
                break;
            case 2:
                System.out.print("two hundred ");
                break;
            case 3:
                System.out.print("three hundred ");
                break;
            case 4:
                System.out.print("four hundred ");
                break;
            case 5:
                System.out.print("five hundred ");
                break;
            case 6:
                System.out.print("six hundred ");
                break;
            case 7:
                System.out.print("seven hundred ");
                break;
            case 8:
                System.out.print("eight hundred ");
                break;
            case 9:
                System.out.print("nine hundred ");
                break;
        }
     
         
          System.out.print("Enter a number between 0 and 999: ");
               
          BufferedReader BR = new BufferedReader(new InputStreamReader(System.in));
          String n = "";
         
          try {
              n = BR.readLine();
            }
          catch(IOException ioe) {
              System.out.println("Couldn't read input" +ioe.getMessage());
            }
           
            int p = 0;
           
            try {
                p = Integer.parseInt(n);
            }
            catch(NumberFormatException nfe) {
                System.out.println(n + " needs to equal a number e.g. 1\n" + nfe.getMessage());
            }
                 
                   if (p > 99 && p < 1000) {
                     int h = p/100;
                        System.out.println(h);
                      int x = p % 100;        
                      if (x > 10 && x < 20) {  
                        System.out.println(x);  
                   }
                 
                     if (x > 0 && x < 100) {
                        int y = x / 10;  
                         System.out.println(y);        

                         int z = x % 10;  
                          System.out.println(z);        
            }
        }
                      if ( p > 19 && p < 100) {
                        int t = p / 10;    
                          System.out.println(t);                
                        int u = p % 10;    
                          System.out.println(u);  
        }
                        if (p > 10 && p < 20) {
                           System.out.println(p);        
        }
                        if (p < 10) {          
                            System.out.println(p);          
        }
    }
}
 

Here is the output for this program, w/c is incorrect

  Enter a number between 0 and 999:
453
4
5
3
BUILD SUCCESSFUL (total time: 3 seconds)
  

Any reply will be appreciated, thank you

[Harold Lime]

I'd start again, maybe with the code below, I think that all those switch statements are sending you in the wrong direction.

And as I said earlier, the code should probably be doing something like:

- Read input (done)
- Is it a number? (done)
- Is it the specified range? (easy)
- Is is a 3 digit number? (easy)
- Does it end with a number below 21? (easy, why is this important though?)

import java.io.*;

public class Main {
	public static void main(String[] args) {

		System.out.print("Enter a number between 0 and 999: ");

		BufferedReader BR = new BufferedReader(new InputStreamReader(System.in));
		String input = "";
		int number = 0;

		try {
			input = BR.readLine();
			number = Integer.parseInt(input);
		} catch(IOException ioe) {
			System.out.println("Couldn't read input" +ioe.getMessage());
		} catch(NumberFormatException nfe) {
			System.out.println(input + " needs to equal a number e.g. 1\n" + nfe.getMessage());
		}

		//more code here

	}
}

[David Newton]

@Harold: Please be very careful when providing complete or even partial solutions. One of our goals here is to get people to do all of their own work, experience their own triumphs and failures, learn how to learn, and so on. I'm leaving your code (someone else may not), but it's on the edge of what I'd consider "too much information". (I'm also a bit more draconian about this than some here.)

[Harold Lime]

David Newton wrote:@Harold: Please be very careful when providing complete or even partial solutions. One of our goals here is to get people to do all of their own work, experience their own triumphs and failures, learn how to learn, and so on. I'm leaving your code (someone else may not), but it's on the edge of what I'd consider "too much information". (I'm also a bit more draconian about this than some here.)

Fair point, although it's really a rejigged (and condensed) version of the code originally posted - I didn't actually add anything.

[Campbell Ritchie]

bue curt wrote: . . .
We are not allowed to use that code.
Switch,if,if else,while,do while,for loop are the only allowed method.

As far as I can remember, it was simply a while loop . . . once Robin got her act together to read the thread.

[Misha van Tol]

If you're allowed to use array's you don't need the switch / case structure. And no, I don't mean one array of a thousand items. Three array's of nine items should be enough.

[bue curt]

Misha van Tol wrote:If you're allowed to use array's you don't need the switch / case structure. And no, I don't mean one array of a thousand items. Three array's of nine items should be enough.

meh, arrays aren't allowed. Just woke up, I'm trying make t work

[bue curt]

I've have finished the program, thanks everyone. It can output the world equivalent of numbers from 0-9999. But, I've rechecked my notes and it says that it should output numbers from -9999 to 9999. do i have to make new switch statements for the negative numbers? or I could simply do -number * -1= number then print with word negative?
Is that possible?

[Campbell Ritchie]

Well done getting the positive numbers to work

For negative values, use the word "minus" . . .

[salvin francis]

Unrelated to the solution,

Why do you have restrictions to use switch,arrays etc. ?
I personally feel the program is much simpler than what you are going for ...

[fred rosenberger]

Sometimes, assignments are given to get the student to learn how to use certain features, like case statements, or for loops, or certain data structures. By limiting what they are allowed to use, the instructor can better show the strength and weaknesses of various data types or control structures.

[salvin francis]

fred rosenberger wrote:Sometimes, assignments are given to get the student to learn how to use certain features, like case statements, or for loops, or certain data structures. By limiting what they are allowed to use, the instructor can better show the strength and weaknesses of various data types or control structures.

Given that the assignments are properly choosen which in my opinion, is not for the OP's question.