problem in converting string to byte array.

[Pramod P Deore]

Hello everybody,

I am developing an application in that I want to upload image to the server. If image is less than 900 kb then application run fine. but when image is more than 900kb then it throws exception as java.lang.OutOfMemoryError.

my code is as follows

public class ImageUp1 extends Activity
{
	String existingFileName = "/sdcard/Images/test.jpg";  
	String strLine,str,str1;
	
    /** Called when the activity is first created. */
    @Override
    public void onCreate(Bundle savedInstanceState)
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);
        upImage();
        sendToPage(str1);
    }
    
    public void upImage()
    { 
    	File uploadFile = new File(existingFileName);
    	
    	int i = (int)uploadFile.length();
    	
    	
    	try
    	{ 
    		FileInputStream fstream = new FileInputStream(uploadFile);
    		
    		DataInputStream in = new DataInputStream(fstream);
    		
    		BufferedReader br = new BufferedReader(new InputStreamReader(in));
    		
    	    			
    			byte[] b = new byte[i];
    			int len=  in.read(b,0,i);
    	   			
	    		str1 = Base64.encode(b);
	    	  		
    	}
      
		catch ( Exception ioe)
		{
			ioe.printStackTrace();
		}
	}
    
    public void sendToPage(String str1)
    {
    	try
    	{
    	    	
    		URL connectURL = new URL("sample URL"); 
    		// connectURL is a URL object
    		
    		
    		HttpURLConnection conn = (HttpURLConnection) 
    		connectURL.openConnection(); 
    		// allow inputs 
    		conn.setDoInput(true); 
    		// allow outputs 
    		conn.setDoOutput(true); 
    		// don't use a cached copy 
    		conn.setUseCaches(false); 
    		// use a post method 
    		conn.setRequestMethod("POST"); 
    		// set post headers 
    		conn.setRequestProperty("Connection","Keep-Alive"); 
    		
    		
    		
    		
    		// open data output stream 
    		OutputStream dos ; 
    		
    		dos=conn.getOutputStream();
    	
    	    byte[] arr = str1.getBytes();                //here it throws exception as  java.lang.OutOfMemoryError when size of image is greater than 900kb.
    	    System.out.println ("arr auccesfully created"+arr.length);
    	      	    
    	    dos.write(arr);
    	    
    		System.out.println ("write to the page");
    	   		
    		// create a buffer of maximum size 
    		
	    	dos.flush(); 
	        	
	    	InputStream is = conn.getInputStream(); 
	    	int ch; 
	    	StringBuffer b =new StringBuffer(); 
	    	System.out.println ("Before second while loop");
	    	while(( ch = is.read() ) != -1 )
	    	{ 
	    		b.append( (char)ch);
	    		
	    	} 
	    	String s=b.toString(); 
	    	System.out.println (s);
	    	dos.close(); 
	    	System.out.println ("at the end of try block");
    	} 
    	catch (MalformedURLException ex)
    	{ 
    		// Log.e(Tag, "error: " + ex.getMessage(), ex); 
    	} 
    	catch (IOException ioe)
    	{ 
    		// Log.e(Tag, "error: " + ioe.getMessage(), ioe); 
    	} 

    }
	
}

I have Base64 class which has method

public static String encode(byte[] raw) {
        StringBuffer encoded = new StringBuffer();
        for (int i = 0; i < raw.length; i += 3) {
            encoded.append(encodeBlock(raw, i));
        }
        return encoded.toString();
    }

What is wrong here?

Thanks in advance.

[Ankit Garg]

I would say your code is not properly created for mobile devices. You are reading the whole file into a byte array, then encoding it with Base64 to get a String and then again convert the whole String back to byte array. This will use a lot of memory for a mobile device to handle. Why don't you read the file in chunks like 100bytes at a time and send it to the output stream. That way you won't use that much memory...