combobox is not updating in Swing GUI

[praveen bhurlekar]

I am adding item in the combo box within a fucntion and I am calling that function from actionListener of a button.
The combo box is getting populated, I am able to print the value using SOP but it is not updating in GUI.

PSB the sample code :

// Leeloo.java

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;


public class Leeloo extends JPanel implements ActionListener {
	String login_s;
	String passwd_s;
	JComboBox env_combo;
	JComboBox app_combo;	
	JComboBox logs_combo; // check it without static
	JButton logs;
	String [] env_log = {"none"};
	//Leeloo l = new Leeloo();
	
	public Leeloo() {
		new FlowLayout();
		String[] env = {"65","66","79","80","81","82","83","84","85"};
		String[] app = {"ABP","CRM","OMS","ARM","SOM","USM"};
		
		env_combo = new JComboBox(env);
		app_combo = new JComboBox(app);	
		logs_combo = new JComboBox(env_log);
		
		logs = new JButton("Logs");
		
		add(env_combo);
		add(app_combo);
		add(logs_combo);
		add(logs);
		logs.addActionListener(this);

	}

	public void actionPerformed(ActionEvent e) {
        //JComboBox cb = (JComboBox)e.getSource();
		//String host = "ilhp010";
		System.out.println("hiya");
		String s = (String)env_combo.getSelectedItem();
		String p = (String)app_combo.getSelectedItem();
		
		Leeloo l = new Leeloo();
		l.getDataFiles( "****", "****","****", "my/logs", "C:\ftp", start,end );
		System.out.println("hiya back");

		//String password = "Unix11!";
        
    }
	
public static void CreateAndShowGUI() {
	JFrame jfrm = new JFrame("Logs");
	//jfrm.setSize(190,70);
	jfrm.setSize(400,400);
	jfrm.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	JComponent newContentPane = new Leeloo();
	newContentPane.setOpaque(true);
	jfrm.setContentPane(newContentPane);
	//jfrm.pack();
	jfrm.setVisible(true);
}

public static void main(String args[]) {
	javax.swing.SwingUtilities.invokeLater(new Runnable() {
		public void run() {
			CreateAndShowGUI();
		}
	});
}


public void getDataFiles( String server, String username, String password, String folder, String destinationFolder, Calendar start, Calendar end )
  {
    try
    {
	     // adding items to combo box but they are not updating


     
	String[] fileNames = {"f1","f2","f3"};

	logs_combo.addItem("added");
	//logs_combo.removeItemAt(0);
	 for(int i=0;i<fileNames.length;i++)
	 {
		logs_combo.addItem(fileNames[i]);
		System.out.println(" in logs ");
	 }
	 
	 System.out.println(logs_combo.getItemCount());
	  System.out.println("hello : " +logs_combo.getItemAt(1));
	
	.......................

    }
    catch( Exception e )
    {
      e.printStackTrace();
    }
  }  // end function......
  
} // end class 

[Maneesh Godbole]

Praveen,
Welcome to the Ranch. I have edited your post to incorporate code tags. UseCodeTags
Also please avoid using words like PSB. UseRealWords

To get the most out of the Ranch, please do take out time to review http://faq.javaranch.com/java/HowToAskQuestionsOnJavaRanch

[Maneesh Godbole]

The combo box is getting populated, I am able to print the value using SOP but it is not updating in GUI.

This is contradictory. Did you open the combo drop down to view the data after populating it?

[Maneesh Godbole]

Ok. I tried your code. I got some compiler errors which I fixed. In the future please PostRealCode

Root cause of your problem is

Leeloo l = new Leeloo();

in your actionPerformed. What do you think it does?

[praveen bhurlekar]

Hi Mangesh,

sorry for the incomplete code.

first my Gui shows the combo-box.
Then on button click combo-box is populated, I print the value from combo box using System.out.println("");

but when i open GUI it is not updated.

mangesh,
if you found the problem please let me know how to rectify it.

I need to update the combo box within the fucntion only.

[Maneesh Godbole]

My name is Maneesh not Mangesh.
I have already told you what is causing the problem in my earlier post

[praveen bhurlekar]

my program is going in infinite loop at runtime.
while putting Leeloo l = new Leeloo(); outside actioPerformed() function.

Maneesh,
please help.

[Rob Spoor]

On line 43 you create a new instance of Leeloo which is completely unrelated to the current Leeloo instance. It has its own set of combo boxes and all. Try calling simply "getDataFiles", without the "l." This will call this method on your current instance.