Spring AOP program not running as expected

[rakesh kadulkar]

Hi,

I am referring to Spring In Action and I am at the end of the first chapter i.e. Springing into action.

I am trting to run the demo given for AOP introduction.

I am giving the code for all here including my xml file.

This is my employee class

    
package com.emp;

/**
 *
 * @author rakeshk
 */
public class Employee {
    private String id;
    private String first;
    private String last;

    public Employee() {
    }

    
    
    public Employee(String id, String first, String last) {
        this.id = id;
        this.first = first;
        this.last = last;
    }

    public String getFirst() {
        return first;
    }

    public void setFirst(String first) {
        this.first = first;
    }

    public String getId() {
        return id;
    }

    public void setId(String id) {
        this.id = id;
    }

    public String getLast() {
        return last;
    }

    public void setLast(String last) {
        this.last = last;
    }
    
    public void embarkOnQuest()
    {
        System.out.println("Withn the embark on quest method");
        System.out.println(getId() + "  " + getFirst() + "  " + getLast());
    }

}

This is my MyLogger class

    
import com.emp.Employee;

/**
 *
 * @author rakeshk
 */
public class MyLogger {
    
    public void before(Employee emp)
    {
        System.out.println("Before for employee " + emp.getLast());
    }
    
    public void after(Employee emp)
    {
        System.out.println("After for employee " + emp.getLast());
    } 
    
}

This is the configuration file

    
<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
		xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
		xmlns:aop="http://www.springframework.org/schema/aop"
		xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.0.xsd
				http://www.springframework.org/schema/aop http://www.springframework.org/schema/aop/spring-aop-2.0.xsd">
                                    
                
                <bean id="logger" class="com.log.MyLogger"/>
                
                <bean id="emp" class="com.emp.Employee">
                    <property name="id" value="10"/>
                    <property name="first" value="rakesh"/>
                    <property name="last" value="kadulkar"/>
                </bean>
                
                <aop:config>
                <aop:aspect ref="logger">    
                
                <aop:pointcut  id="test" expression="execution(* *.embarkOnQuest(..)) and target(bean)" />
                <aop:before method="before" pointcut-ref="test" arg-names="bean"/>
                <aop:after-returning method="after" pointcut-ref="test" arg-names="bean"/>
                    
                </aop:aspect>
                </aop:config>
              
              
</beans>

What I expected is whenever I call embarkObQuest() method on the employee object it will first call the before() method of MyLogger and then the embarkOnquest() method execution and after that after() method on MyLogger object.
But when I run the program it shows only the output from embarkOnQuest() method and not from before() and after) method.

What may be wrong?

Here is the client code.

public class Main {

/**
* @param args the command line arguments
*/
public static void main(String[] args) {
// TODO code application logic here
BeanFactory factory = new XmlBeanFactory(new FileSystemResource("./config/employee.xml.xml"));
Employee emp = (Employee)factory.getBean("emp");
Object obj = emp.embarkOnQuest();
}


}

[David Newton]

I'm not sure that using a plain XmlBeanFactory works for this; I'd use an ApplicationContext (a ClassPathXmlApplicationContext, in this case) to make sure pre- and post-processors are registered.

public class Main {
    public static void main(String[] args) {
        ApplicationContext context = new ClassPathXmlApplicationContext("spring-config.xml");
        Employee emp = (Employee) context.getBean("emp");
        emp.embarkOnQuest();
    }
}

I'd also recommend using classpath-based configuration files (and avoiding filenames with doubled extensions ;)