Stopping a thread

[Manikandan Swaminathan]

Hi all,

Now that the stop() method has been deprecated, should we have to stop a running thread only using interrupt() method?

 
private Thread workingThread;
public void run(){
workingThread = Thread.currentThread();
// do other work here
}
public void stopThread() {
workingThread.interrupt();
}
  

Can anyone please review the above code and let me know if its the proper way to stop a thread?

Thanks in advance !

[Jelle Klap]

The interruption mechanism is the preferred way to implement cancellation, but calling interrupt() should be considered a request for interruption of the target thread; it does not by definition mean that the target thread will halt execution. You're merely asking the thread to interrupt itself at its own convenience. How that request is dealt with may vary.

[Edward Harned]

interrupt() is a mess. Threads interrupt themselves, other threads call interrupt(). There is no definition for what interrupt should do.

Follow the suggestion in the link found in Thread.stop(). Use your own volatile field to indicate "stop."