Need a better solution

[adeeb alexander]

Hi all.
I have 2 class A and B. I passed values to B constructor n done some thing and sent values back to class A method. Below is the code. i think there is much more better solution than this. Bcauz i am a noob.
class A

 import java.util.*;
import java.util.Scanner;
import java.io.*;
import java.text.*;

public class And{
	 
	public void And(String input){
		try
		{
		//	BufferedReader in = new BufferedReader(new InputStreamReader(System.in));
		//	String input = in.readLine();
		//	in.close();
			input = input.toUpperCase();
			String []spl = input.split("\\s+AND");
			List<String> cols= new ArrayList<String>();
			List<String> vals= new ArrayList<String>();
			for(int i=0;i<=spl.length-1;i++)
			{
				String []spl1=spl[i].split("\\s?+=");
					spl1[0]=spl1[0].trim();
					spl1[1]=spl1[1].trim();
					cols.add(spl1[0]);
					vals.add(spl1[1]);
			}
			AndTest.solved(cols,vals);
			
		/*	System.out.println("Columns:");
			for(int k=0;k<cols.size();k++)
			{
				System.out.println(cols.get(k));
			}
			System.out.println("Values:");
			for(int l=0;l<vals.size();l++)
			{
				System.out.println(vals.get(l));
			}*/
			
		}catch(Exception ce){
			System.out.println("And Exception:"+ce);
		}
	}
/*	public static void main(String args[])
	{
		new And();
	}*/
}   

class B

  import java.util.*;
import java.util.Scanner;
import java.io.*;
import java.text.*;

public class AndTest{
	private static List><String> colss=new ArrayList<String>();
	private static List<String> valss=new ArrayList<String>();
	
	public static void solved(List<String> cols,List<String> vals){
			colss=cols;
			valss=vals;	
	}
	
	public AndTest(){
		String str = "col   = val and col   =    val";
		And and = new And();
		and.And(str);
		System.out.println("Columns:");
			for(int k=0;k<colss.size();k++)
			{
				System.out.println(colss.get(k));
			}
			System.out.println("Values:");
			for(int l=0;l<valss.size();l++)
			{
				System.out.println(valss.get(l));
			}
	}
	public static void main(String args[]){
		new AndTest();
	}
}  

Thanks and Regards
Adeeb>

[pete stein]

adeeb alexander wrote:Hi all.
I have 2 class A and B. I passed values to B constructor n done some thing and sent values back to class A method. Below is the code. i think there is much more better solution than this. Bcauz i am a noob.

Perhaps it's me, but I'm not sure I understand just what your problem is. What is working/not working with this code? What in particular bugs you? And also, just what is this code supposed to do.

Also, just to be sure, you do know that this is not a constructor but rather a dangerously named method, correct?

	public void And(String input){
	    //....
	}

edit: ah, you've posted the second class, AndTest. One point to make, if this is truly a test class, then it is my impression that you shouldn't have the class you are testing, And, call methods from the tester, TestAnd, that the first class should have no knowledge of the second.

Much luck! Pete

[pete stein]

One way to fix your problem with And calling the method from the test class is to give And two List<String> private variables complete, say cols and vals, with public getter methods, and to have your And constructor (if you give it one) and its methods use these class fields and not re-declare them elsewhere. Then you can have the test program retrieve and use the two Lists via And's getter methods.

And, again please re-name the pseudo-constructor method that you currently call And. Either that or make it a true constructor.

Luck!

Pete

[adeeb alexander]

Thank you so much stein. Is it necessary to use a constructor or just we can write prog without it??

[pete stein]

adeeb alexander wrote:Thank you so much stein. Is it necessary to use a constructor or just we can write prog without it??

Well, as far as I know, all classes must have a constructor, but if you don't provide an explicit constructor, Java will implicitly provide a default one. So your And class doesn't need a constructor, and it's fine to use the And method, but again, you will want to rename the method since as it is written with the pseudo-constructor, it will confuse many who read the code. Also method names should not be capitalized.

[Campbell Ritchie]

Please always tell us what the thread is about, and avoid misspellings like "n" and "bcauz".