How to Promt User for Three Times Password Check?

[Behrouz Hosseini]

Hi Guys
I am trying to write a simple program which is suppose to give the user three times chances to enter the correct password. as you can see from the following code if enter the correct pass at the first time system will accept it but if I enter the correct password at second or third time system will accept the password and will prompt the "Access denied!" message which I can't figure it out why it is printing out while it is in else clause!

public class Main {

    public static void main(String[] args){

        String password = "Test";
        String inputPass;
        Scanner  input = new Scanner(System.in);
        
        System.out.println("Enter Your Password:");
        inputPass = input.nextLine();

        if (inputPass.equals(password)) {
            System.out.println("Welcome User!");
        } else {
            for (int i = 0; i < 2; i++) {
                System.out.println("Enter Your Password:");
                inputPass = input.nextLine();
                if (inputPass.equals(password)) {
                    System.out.println("Welcome User!");
                } 
              }
         System.out.println("Access Denied!");
        }
    }
}
    

Could you please let me know what I am doing wrong here?
Best Regards

[Deepak Bala]

"Access denied!" message which I can't figure it out why it is printing out while it is in else clause!

Does this statement require an else clause of its own ?

  if (inputPass.equals(password))  

Where do you think the 'access denied' message belongs ?

[Mina Daoud]

Can you please check your condition and loop scope!

[Behrouz Hosseini]

Dear Deepak
Thanks for reply, I understand what you are talking about and let's rewrite the code in this way

public class Main {

    public static void main(String[] args){

        String password = "Test";
        String inputPass;
        Scanner  input = new Scanner(System.in);
        
        System.out.println("Enter Your Password:");
        inputPass = input.nextLine();

        if (inputPass.equals(password)) {
            System.out.println("Welcome User!");
        } else {
            for (int i = 0; i < 2; i++) {
                System.out.println("Enter Your Password:");
                inputPass = input.nextLine();
                if (inputPass.equals(password)) {
                    System.out.println("Welcome User!");
                } 
                   else{System.out.println("Access Denied!");
                  }
  
              }
         else{System.out.println("Access Denied!");
        }
    }
}
    

but the problem still on going .I am getting the "Access Denied!" message after second time correct try!

[Behrouz Hosseini]

Mina Daoud wrote:Can you please check your condition and loop scope!

Hi Mina,
I agree with you there is something wrong with my loop scope but where is it?! I tried to follow all rules!

[Mina Daoud]

Behrouz Hosseini wrote:

Mina Daoud wrote:Can you please check your condition and loop scope!

Hi Mina,
I agree with you there is something wrong with my loop scope but where is it?! I tried to follow all rules!

Ok Say the first attempt of inserting the password is wrong, your code will jump to the for loop. What will happen if i insert a CORRECT password?

[Behrouz Hosseini]

re-prompting the user to enter the password despite accepting the password!

[Mina Daoud]

Behrouz Hosseini wrote:re-prompting the user to enter the password despite accepting the password!

Exactly, so you need to have something to break the loop if the password is correct.
P.S. the last else is your code will throw compilation error!

[Behrouz Hosseini]

Thanks, I used the break to stop looping but still getting the Access denied message.should I replace the last print out message?

[Mina Daoud]

Behrouz Hosseini wrote:Thanks, I used the break to stop looping but still getting the Access denied message.should I replace the last print out message?

I think you need to enhance little bit the if..else and for loop.

[Behrouz Hosseini]

Ok Mina, thanks for your help. I think I need some more time to think about it.I have to go to sleep now it's 3 am here and maybe tomorrow I can work on it.
Thanks again,

[Mina Daoud]

No problems, Hope i helped you!

[Behrouz Hosseini]

well this is the way that i tried to modify my code

 
public class Main {

    public static void main(String[] args){

        String password = "Test"";
        String inputPass;
        Scanner  input = new Scanner(System.in);
        

          for (int i = 0; i < 3; i++) {
            System.out.println("Enter Your Password:");
            inputPass = input.nextLine();
            if (inputPass.equals(password)) {
                System.out.println("Welcome User!");
                break;
            } else {
                System.out.println("Access Denied!");
            }
        }
    }
}
   

But I am still getting the Access Denied message after each incorrect try which make sense! because it is in for loop scope but how can I stop it and just print it out at the very end of program if all three tries were incorrect!?

[Gary Ba]

Try taking out the else statement outside the loop.

like..
for ...
{
do stuff
}
if password has been entered 3 times incorrectly,
print message.

Good luck,
Gary

[Kshitij Chandrasen]

Declare the counter "i" outside the scope of the loop. After the loop, check for it value, and if it is equal to 3 it means the user did not enter the correct password at the third time too.

[Behrouz Hosseini]

Gary Ba wrote:Try taking out the else statement outside the loop.

like..
for ...
{
do stuff
}
if password has been entered 3 times incorrectly,
print message.

Good luck,
Gary

thanks Gary
even in that format I can't stop repeating of the Access denied Message!

  
public class Main {

    public static void main(String[] args) throws FileNotFoundException {

        String password = "Test";
        String inputPass;
        Scanner input = new Scanner(System.in);
       
        for (int i = 0; i < 3; i++) {
            System.out.println("Enter Your Password:");
            inputPass = input.nextLine();
            if (!inputPass.equals(password)) {
                System.out.println("Access Denied!");
            } else {
                System.out.println("Welcome User!");
                break;
            }
        }
    }
}
  

[Kshitij Chandrasen]

You need to bring the the print statement for "access denied" outside the for loop, check for the value of "i" (declare i outside the scope of the loop) and print the error message accordingly.

[Gary Ba]

You did not take out the else statement inside the loop.
Also note, break after the password has been entered correctly.

I wish I can give you the code but I will get yelled at by Mr. Campbell.

Regards,
Gary

[Behrouz Hosseini]

Gary Ba wrote:You did not take out the else statement inside the loop.

But how I can take out the else clause out side of the loop while the if clause should be in!?

[Gary Ba]

It is possible....

   
int i = 0;
for (; i < 3; i++)
{
   if (statement)
   {
   }
}

if(statement)

Try it out and see how it works.

hope this helps,
Gary