Pasing scriptlet variable to javascript

[David Kennedy]

Hi all,

I need to use a variable from a scriptlet in some javascript and I cant get it working. My code is the following. Scriptlet where i set a request attribute followed by calling it in some javascript. Any ideas would be very welcome.

Thanks

<% String variable = "December 25, 2010";
request.setAttribute("variable", variable);
%>


<SCRIPT LANGUAGE="JAVASCRIPT">
    var myVar = "<% request.getAttribute("variable"); %>";

    document.write("My var " + myVar);
</SCRIPT>

[Devaka Cooray]

<% request.getAttribute("variable"); %> is just calling the getAttribute method ignoring the returned value. If you need to get the returned value, you should call it as <%= request.getAttribute("variable") %>
However, note that using scriptlets on JSPs is obsolete - it's a bad practice to have Java codes in JSPs. You can easily use EL for this requirement, replacing all of these scriptlets with handy EL tags.

[David Kennedy]

Thanks for the reply Devaka,

My code now looks like this below but it still isnt working. am I still missing something?

<% String variable = "December 25, 2010";
request.setAttribute("variable", variable);
%>


<SCRIPT LANGUAGE="JAVASCRIPT">

var myVar = <%= request.getAttribute("variable") %>;
document.write(myVar);
</SCRIPT>

I have also tried

<SCRIPT LANGUAGE="JAVASCRIPT">

var myVar = <%= request.getAttribute("variable") %>
document.write(myVar);
</SCRIPT>

Thanks

[ramprasad madathil]

My code now looks like this below but it still isnt working

Did you look at the html source on the browser and confirm that the variable is not being populated?

[Ilari Moilanen]

You are also missing the quote marks around your variable so the result currently looks like this

var myVar = December 25, 2010;

and that is invalid javascript. But you see this yourself when you look at the resulted html source.

[Devaka Cooray]

David, please UseCodeTags when you post a code. It's unnecessarily hard to read the code otherwise. Please edit your post to add code tags by clicking the button.

[David Kennedy]

Thanks for the help and the quotes fixed it.
Apologies for the lack of code thanks.

Here was the final code for anybody else:

var myVar = "<%= request.getAttribute("variable") %>"

[Devaka Cooray]

[Bear Bibeault]

But you should take the other advice given to you earlier in this topic: scriptlets have been discredited for over 8 years now. Time to update your JSP knowledge.