Forum:

Struts

validation problem.

Ranch Hand

Posts: 30

posted 9 years ago

i have action class with following code

my problem is validate() method not working.
it only give actionerrors i.e. "Invalid User Name or Password"; eventhough if i provide empty string in the text box for username and pwd.
need some assists.

Ankit Garg

Sheriff

Posts: 9674

I like...

posted 9 years ago

Can you post the code of the related JSP page...

SCJP 6 | SCWCD 5 | Javaranch SCJP FAQ | SCWCD Links

Java 8 (verified skill)
Skill verified by Jeanne Boyarsky

rajiv shrestha

Ranch Hand

Posts: 30

posted 9 years ago

Jsp page is given below

<%@ page contentType="text/html;charset=UTF-8" %>

<%@taglib uri="/struts-tags" prefix="s"%>
<%@taglib uri="/struts-dojo-tags" prefix="sx"%>
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Insert title here</title>
<s:head />
</head>
<body>

<s:if test="hasActionErrors()">
	<s:actionerror />
</s:if>
<s:fielderror/>

<s:form action="loginSubmit">

<s:textfield key="global.username" name="user.username" />
	<s:password key="global.password" name="user.pwd" />
	<s:submit key="global.submit" name="submit" />

<s:url id="localeEN" action="localeAction">
		<s:param name="request_locale">en</s:param>
	</s:url>
	<s:url id="localezhCN" action="localeAction">
		<s:param name="request_locale">zh_CN</s:param>
	</s:url>
	<s:url id="localeDE" action="localeAction">
		<s:param name="request_locale">de</s:param>
	</s:url>
	<s:url id="localeFR" action="localeAction">
		<s:param name="request_locale">fr</s:param>
	</s:url><!--

<s:a href="%{localeEN}">English</s:a>
	<s:a href="%{localezhCN}">Chinese</s:a>
	<s:a href="%{localeDE}">German</s:a>
	<s:a href="%{localeFR}">France</s:a>
-->
</s:form>

</body>
</html>

Raza Mohd

Ranch Hand

Posts: 247

I like...

posted 9 years ago

Hi.
can i have a look at struts.xml

Good luck!!
A small leak can sink a Gigantic ship.>

rajiv shrestha

Ranch Hand

Posts: 30

posted 9 years ago

struts.xml is given below.

<!DOCTYPE struts PUBLIC
"-//Apache Software Foundation//DTD Struts Configuration 2.0//EN"
"http://struts.apache.org/dtds/struts-2.0.dtd">

<result-types>
			<result-type name="tiles"
				class="org.apache.struts2.views.tiles.TilesResult" />
		</result-types>

<interceptor-stack name="sessionStack">
				<interceptor-ref name="session"/>
				<interceptor-ref name="loggingInterceptor"/>
				<interceptor-ref name="defaultStack"/>	
			</interceptor-stack>
		</interceptors>

<default-interceptor-ref name="sessionStack">
		</default-interceptor-ref>

<global-results>
			<result name="sessions">/sessionexpired.jsp</result>
		</global-results>

<action name="loginForm" method="loginForm" class="actions.LoginAction">
			<interceptor-ref name="validation">
				<param name="excludeMethods">loginForm</param>
			</interceptor-ref>

<result name="success">/login.jsp</result>
		</action>

<action name="loginSubmit" class="actions.LoginAction">
			<interceptor-ref name="defaultStack">
				<param name="validation.excludeMethods">execute</param>
			</interceptor-ref>
			<result name="success" type="tiles">/welcome.tiles</result>
			<result name="input">/login.jsp</result>
			<result name="error">/login.jsp</result>
		</action>

<action name="displayAction" method="displayDetails" class="serviceAction">			
			<result name="success" type="tiles">/userDetails.tiles</result>
		</action>

<action name="addStartAction" method="addStartUser" class="serviceAction">
			<result name="success" type="tiles">/addStartUser.tiles</result>
			
		</action>

<action name="addAction" method="addUser" class="serviceAction">
			<result name="success" type="tiles">/addUser.tiles</result>
		</action>

<action name="deleteAction" method="deleteUser" class="serviceAction">
			<result name="success" type="redirect">displayAction</result>
		</action>

<action name="editAction" method="editUser" class="serviceAction">
			<result name="success" type="tiles">/editUser.tiles</result>
		</action>

<action name="localeAction" class="actions.LocaleAction">
			<interceptor-ref name="defaultStack">
				<param name="validation.excludeMethods">execute</param>
			</interceptor-ref>			
			<result name="success">/login.jsp</result>
		</action>

<action name="logoutAction" class="actions.LogoutAction">
			<result name="success">/index.jsp</result>
		</action>

</package>
</struts>

Ankit Garg

Sheriff

Posts: 9674

I like...

posted 9 years ago

Is the validate method being called?? Check if your action implements Validateable interface (the struts configuration is not of much use as we don't know the name of your action class)...

SCJP 6 | SCWCD 5 | Javaranch SCJP FAQ | SCWCD Links

rajiv shrestha

Ranch Hand

Posts: 30

posted 9 years ago

no validate method is not called
Action class:

public class LoginAction extends ActionSupport implements SessionAware
{
	/**
	 * 
	 */
	private static final long serialVersionUID = 1L;
	
	private UserService userService;
	private List<User> userList;

private Map<String, Object> session;
	private User user= new User();

public List<User> getUserList() {
		return userList;
	}

public void setUserList(List<User> userList) {
		this.userList = userList;
	}

public Map<String, Object> getSession() {
		return session;
	}

public void setSession(Map<String, Object> session) {
		this.session = session;
	}

public UserService getUserService() {
		return userService;
	}

public void setUserService(UserService userService) {
		this.userService = userService;
	}

public User getUser() {
		return user;
	}

public void setUser(User user) {
		this.user = user;
	}
	
	boolean status;

public String execute() throws Exception 
	{
		
		status = userService.login(user);
		
		System.out.println("Validating-user:"+user.getUsername()+"-pwd:"+user.getPwd());
		
		if(status)
		{
			int loginId = userService.getLoginId(user);			
			System.out.println("Login id:"+loginId);
			session = ActionContext.getContext().getSession();	
			session.put("loginid", loginId);
			session.put("status", status);
			return "success";
		}
		else
		{
			addActionError("Invalid User Name or Password");
			//addActionMessage("invalid username or password");
		
			return "error";
			
		}
	}

public String input() throws Exception
	{
		System.out.println("Redirecting to login frm input");
		return "input";
	}

public String loginForm() throws Exception
	{
		System.out.println("Redirecting to login from loginForn");
		return "success";
	}

/* (non-Javadoc)
	 * @see com.opensymphony.xwork2.ActionSupport#validate()
	 */
	public void validate() {
		
		if(user.getUsername().length()==0){
			addActionError("Enter username");
		}
		if(user.getPwd().length()==0){
			addActionError( "Enter password");
		}
	}

Raza Mohd

Ranch Hand

Posts: 247

I like...

posted 9 years ago

hi rajiv..
Define result type 'input' in your struts.xml.

I think that will help..
Struts is redirecting your control to result type 'input'

please mention it inyour struts.xml

Thanks n Regards
Raza

Good luck!!
A small leak can sink a Gigantic ship.>

rajiv shrestha

Ranch Hand

Posts: 30

posted 9 years ago

the problem is solved with this code..

instead of

Would you like to try a free sample? Today we are featuring tiny ads:

Thread Boost feature

https://coderanch.com/t/674455/Thread-Boost-feature