Injecting a mock request into the RequestContextHolder

[Rob Dennett]

I am trying to write tests for some existing code in a SpringMVC application which frequently retrieves the request from

((ServletRequestAttributes) RequestContextHolder.getRequestAttributes()).getRequest()

rather than using one that might be passed into the a controller method.

Is there a way to make that return a MockHttpRequest?

For example, here is something similar to the code I am testing:

@RequestMapping("/foo.do")
public String foo(HttpServletRequest request, HttpServletResponse response) {
  bar();
}

public void bar() {
  AClass aClass = AClass.getInstance();
  // etc.
}

// AClass.getInstance method

public AClass getInstance() {
  AClass aClass = (AClass) ((ServletRequestAttributes) RequestContextHolder.getRequestAttributes()).getRequest().getSession().getAttribute("aClass");
  if (aClass != null) return aClass;
  // etc.
}

I can certainly inject a mock request into the foo method from a jUnit test, but I don't know how to make it so that AClass.getInstance() will use the mock request. If I can't figure this out, it will mean a lot of refactoring.

Thanks for your help,
Rob

[Jeanne Boyarsky]

RequestContextHolder.setRequestAttributes lets you pass in any request attributes you want via an interface. Can you mock out this interface and have it return your mock request?

[Martijn Verburg]

And welcome to Javaranch Rob!