Regarding jsp quote symbol error

[yekkala krishna]

Hi,
Following is my jsp code.if i run this jsp i am getting quote symbol expected error.
could you please suggest what can i do to solve this error.

<input type="submit" name="submit" value="click" onclick = "window.open('
<c:url value ="/viewMapToolScreen.html">
<c:param name="com.smarts.autoAttachDM" value="10.80.159.20:7001/SAM-GSAM1"/>
<c:param name="class" value="com.smarts.webapps.SmWebMapApp"/>
<c:param name="classname" value="${param.classname}"/>
<c:param name="instance" value="${param.instance}"/>
<c:param name="com.smarts.userid" value="admin"/>
<c:param name="com.smarts.password" value="changeme"/>
</c:url>')"/>

thanks in advacne.

regards,
rama

[Vt Guru]

I think you haven't do the taglib deceleration
Like below
<%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c"%>

[Stefan Evans]

Is this a java error, or a javascript error when you load the page?

My guess is that the code will generate something like this:

<input type="submit" name="submit" value="click" onclick = "window.open('  
/TestWeb/viewMapToolScreen.html?com.smarts.autoAttachDM=10.80.159.20%3a7001%2fSAM-GSAM1&class=com.smarts.webapps.SmWebMapApp&classname=&instance=&com.smarts.userid=admin&com.smarts.password=changeme')"/>

Note that you have a line break in there that creates a javascript error.
The solution is to remove a line break from your code:

   1. <input type="submit" name="submit" value="click" onclick = "window.open('<c:url value ="/viewMapToolScreen.html">  
      ...
   </c:url>')"/>  

or alternatively, I like separating it out:

<c:url var = "myUrl" value ="/viewMapToolScreen.html">  
<c:param name="com.smarts.autoAttachDM" value="10.80.159.20:7001/SAM-GSAM1"/>  
<c:param name="class" value="com.smarts.webapps.SmWebMapApp"/>  
<c:param name="classname" value="${param.classname}"/>  
<c:param name="instance" value="${param.instance}"/>  
<c:param name="com.smarts.userid" value="admin"/>  
<c:param name="com.smarts.password" value="changeme"/>  
</c:url>
<input type="submit" name="submit" value="click" onclick = "window.open('${myUrl}')"/> 

[yekkala krishna]

Hi Stefan,
Thanks for your suggestion.
i tried in a way you suggested but also url is forming in the below way.special symbols like :,/-> are going to convert into binary code.what can i do for this:

http://10.80.159.20:8080/Dashboard/viewMapToolScreen.html?com.smarts.autoAttachDM=10.80.159.20%3a7001%2fSAM-GSAM1&class=com.smarts.webapps.SmWebMapApp&classname=Session&instance=SESSION-APP-InChargeService_SAM-T1-bay-%3eAPP-InChargeService_IP-Perspective&com.smarts.userid=admin&com.smarts.password=changeme

following is my code:

<c:url var="myUrl" value ='/viewMapToolScreen.html'><c:param name='com.smarts.autoAttachDM' value='10.80.159.20:7001/SAM-GSAM1'/><c:param name='class' value='com.smarts.webapps.SmWebMapApp'/><c:param name='classname' value='<%=request.getParameter("classname")%>'/><c:param name='instance' value='<%=request.getParameter("instance")%>'/><c:param name='com.smarts.userid' value='admin'/><c:param name='com.smarts.password' value='changeme'/></c:url>')
<tr>
<td  >            <div align="center">

<input type="submit" name="submit" value="click" onclick = "window.open('${myUrl}')"/>

[Bear Bibeault]

Yes, the URL's special characters will get encoded. That's a good thing. Why is it a problem?