Selecting option in second selectOneMenu not setting property value

[D Plum]

Hi,
I have been working on this problem for hours and cannot find an answer in this forum or any other google search.
I have a form that contains 2 dropdowns populated from database tables, when an option is selected in the first one (system) it successfully triggers the rendering and populating of the second (facility). Great. But...when the user selects from the second dropdown, the bean's property (ie selectedFac) is always null. I need the 2 values, system and facility, to then find the person in the database.

Using JSF 2, glassfish 3. No richfaces etc

Here's the JSF:

        <h:form id="UserSystemFacilities">
            Systems available to <h:outputText value="#{user.name}" />:
            <p></p>
            
             
            <h:selectOneMenu id="selectSys" value="#{dataAccess.selectedSys}" onchange="submit()" valueChangeListener="#{dataAccess.getSelectFacList}" >
                <f:selectItems value="#{dataAccess.selectSysList}"/>
            </h:selectOneMenu>
           
           <h:selectOneMenu  id="selectFac" value="#{dataAccess.selectedFac}" rendered="#{dataAccess.selectedSys != null}"  onchange="submit()"  >
                <f:selectItems value="#{dataAccess.selectFacList}"/>
           </h:selectOneMenu>
          
           
            <h:commandButton action="personFind.xhtml" value="Find Person" />
            
            <p><h:commandButton action="#{user.logout}" value="Log out"/></p>

       </h:form>

When I view the html source I see the first list has an option selected but not the second:

<select id="UserSystemFacilities:selectSys" name="UserSystemFacilities:selectSys" size="1" onchange="submit()">	<option value="">Select a system</option>
	<option value="100">SYSTEM ABC</option>

	<option value="101" selected="selected">SYSTEM XYZ</option>
</select>
            

<select id="UserSystemFacilities:selectFac" name="UserSystemFacilities:selectFac" size="1" onchange="submit()">	<option value="00011">FACILITY A</option>
	<option value="00050">FACILITY B</option>
</select>

I know the code is OK for the second dropdown because when I remove the first one (and add some hardcoding in the bean for the "system" value) the property is set fine and I can see the option selected on the HTML source.
Has anyone come accross this before? Any ideas or suggestions would be appreciated.

D.Plum

[Tim Holloway]

I did a very superficial look at this and one thing jumped out:

rendered="#{dataAccess.selectedSys != null}"

I don't think that's doing what you think it's doing, although it might work for the wrong reason.

EL has a tidier way:

rendered="#{not empty dataAccess.selectedSys}"

"null" is not a manifest constant in EL.

Since I didn't actually do a close look, I don't know if this will actually fix the problem, but it fixes a problem. If you're having an issue with a dependent selectOneMenu, it's probably got to do with the fact that the only allowable options for the selected value are those that are in its selectItems list. JSF will zap anything that isn't in there.

[D Plum]

Thanks Tim, I made the change you suggested and unfortunately the behaviour has not changed (but I appreciate the code review)
I didn't quite understand your second comment though, can you elaborate?
Perhaps you could post some example code if you have it for 2 drop downs with one dependant on the other could help? I'm at a loss

[D hanu]

I tried this and I found a solution. Check if this works for you.

<tr>
        <td>Product Type:</td>
        <td><h:selectOneMenu  value="#{UserBean.productType}" id="menu1" immediate="true"
          valueChangeListener="#{UserBean.productSubTypeMethod}" onchange="return func_1(this, event);">
          <f:selectItem itemLabel="please select" itemValue="" />
          <f:selectItem itemLabel="general" itemValue="general" />
          <f:selectItem itemLabel="special" itemValue="special" />
        </h:selectOneMenu></td>
      </tr>
      <tr>
         <h:panelGroup
          rendered="#{UserBean.productSubTypeList != null}" id = "menu2">
          <td>Product SubType:</td>
           <td>
          <h:selectOneMenu id="secondDropDown"
            binding="#{UserBean.subProductType}" immediate="true">

            <f:selectItems value="#{UserBean.dataTransferTypeList}"/>

          </h:selectOneMenu>  </td>
        </h:panelGroup>

When i tried using binding attribute for the second drop down, it did work for me.

[D Plum]

I'm not sure how binding the component to the backing bean will help me, the problem I have is the item in the menu is not being selected ie the "selected" attribute of the option element in the second select element is not set:

This is the first select element with the selected item rendered:

<select id="UserSystemFacilities:selectSys" name="UserSystemFacilities:selectSys" size="1" onchange="this.form.submit()">	<option value="">Select a system</option>
	<option value="100">SYSTEM ABC</option>
	<option value="101" selected="selected">SYSTEM XYZ/option>
</select>

But the second one has no selection:

<select id="UserSystemFacilities:selectFac" name="UserSystemFacilities:selectFac" size="1">	<option value="">Select a facility</option>
	<option value="00011">FACILITY A</option>
	<option value="00050">FACILITY B</option>
</select>

Still can't work out why, would the backing bean code help?

[D hanu]

A value appears as selected in html only when page is rendered. Try loading the page and you will find that the first dropdown would also not have any selected option.

But once you select an item, since the page is re-rendered due to valuechangelistener, html code would appear as selected. Try re-rendering the page second time to see the second dropdown value selected.

[D Plum]

Hi reloading the page didn't change anything. The second property "#{dataAccess.selectedFac}" is definitely not being set because I use it to conditionaly render a text box for the next step ie user can enter an account number and look up the person details.

Please, does any one have an idea? Here's my backing bean code which I know has some problems like executing SQL in the getters but it works:

package SITUI;


import java.io.Serializable;
import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.ArrayList;
import java.util.List;
import java.util.logging.Logger;

import javax.annotation.Resource;
import javax.faces.bean.ManagedBean;
import javax.faces.bean.ManagedProperty;
import javax.enterprise.context.SessionScoped;
//import javax.faces.bean.RequestScoped;
import javax.faces.model.SelectItem;
import javax.sql.DataSource;
import javax.sql.rowset.CachedRowSet;
import javax.faces.component.html.HtmlSelectOneMenu;

@ManagedBean (name = "dataAccess")
@SessionScoped
public class DataAccessBean implements Serializable  {
   private final static Logger logger = Logger.getLogger("SITUI");
   @Resource(name="jdbc/sitdevdb")
   private DataSource ds;
   
   @ManagedProperty(value="#{user}")
   private UserBean userBean;

   private String selectedSys;
   private String selectedFac;
   private HtmlSelectOneMenu selectedFacil;
   private String selectedSysDesc;
   private String selectedFacDesc;

   List<SelectItem> selectSysList;
   List<SelectItem> selectFacList;


   public void setSelectedFacil(HtmlSelectOneMenu inMenu){
       this.selectedFacil = inMenu;
   }
   public HtmlSelectOneMenu getSelectedFacil(){
       return this.selectedFacil;
   }

   public void setUserBean(UserBean userBean) {
       this.userBean = userBean;
   }

   public ResultSet getAllFacility() throws SQLException {
      Connection conn = ds.getConnection();
      try {
         Statement stmt = conn.createStatement();
         ResultSet result = stmt.executeQuery("SELECT * FROM Facility");
         CachedRowSet crs = new com.sun.rowset.CachedRowSetImpl();
         crs.populate(result);
         return crs;
      } finally {
         conn.close();
      }
   }
   public ResultSet getUserSysRoles() throws SQLException {

      String user = userBean.getName();
      Connection conn = ds.getConnection();

      try {
         Statement stmt = conn.createStatement();
         ResultSet result = stmt.executeQuery("SELECT * FROM UserSysRole where USR_UserName = '"+user+"'");
         CachedRowSet crs = new com.sun.rowset.CachedRowSetImpl();
         crs.populate(result);
         return crs;
      } finally {
         conn.close();
      }

   }

   public ResultSet getUserSystems() throws SQLException {

      String user = userBean.getName();
      Connection conn = ds.getConnection();

      try {
         Statement stmt = conn.createStatement();
         ResultSet result = stmt.executeQuery("SELECT * FROM UserSysRole where USR_UserName = '"+user+"'");
         CachedRowSet crs = new com.sun.rowset.CachedRowSetImpl();
         crs.populate(result);
         return crs;
      } finally {
         conn.close();

      }
    }
      
    
    public List<SelectItem> getSelectSysList()  throws SQLException {
        
      List<SelectItem> selectList = new ArrayList();
      String selectCode = "";
      String selectDesc = "Select a system";
        
      String user = userBean.getName();
      Connection conn = ds.getConnection();
      
      try {
         Statement stmt = conn.createStatement();
         ResultSet result = stmt.executeQuery("SELECT SYSTEMCODE, SYSTEMNAME FROM UserSysRole USR,Systems SYS where USR.USR_SYSTEMCODE = SYS.SYSTEMCODE AND USR.USR_UserName = '"+user+"'");
         while (result.next()) {
         selectList.add(new SelectItem(result.getString("SYSTEMCODE"),result.getString("SYSTEMNAME")));
         }
         if (selectList.size() > 1) {
             selectList.add(0,new SelectItem(selectCode,selectDesc));
         }

         
      } finally {
         conn.close();

      }
      
      return selectList;
    }

    public void setSelectedSys(String id){
        logger.info("Setting Selected System");
        this.selectedSys = id;
    }

    public String getSelectedSys(){
        logger.info("Getting Selected System - "+this.selectedSys);
        return this.selectedSys;
    }
    
    public List<SelectItem> getSelectFacList()  throws SQLException {
        logger.info("Getting Facility List");
      List<SelectItem> selectList = new ArrayList();

      String selectCode = "";
      String selectDesc = "Select a facility";

      String system = getSelectedSys();
      Connection conn = ds.getConnection();

      

      try {
         Statement stmt = conn.createStatement();
             ResultSet result = stmt.executeQuery("SELECT FACILITYCODE, FACILITYNAME FROM FACILITY F, SYSFAC SF where SF.SF_FACILITYCODE = F.FACILITYCODE AND SF.SF_SYSTEMCODE = '"+system+"'");
         while (result.next()) {
            selectList.add(new SelectItem(result.getString("FACILITYCODE"),result.getString("FACILITYNAME")));
            
         }
         if (selectList.size() > 1) {
             selectList.add(0,new SelectItem(selectCode,selectDesc));
         }


      } finally {
         conn.close();

      }
 

      return selectList;
    }

    public void setSelectedFac(String id){
        logger.info("Setting Selected Facility");
        this.selectedFac = id;
    }

    public String getSelectedFac(){
        logger.info("Getting Selected Facility - "+this.selectedFac);
        return selectedFac;
    }

    public String getSelectedFacDesc(){
        
        String facilityCode = getSelectedFac();
        String facilityDesc = "";
        
        try {
         Connection conn = ds.getConnection();   
         Statement stmt = conn.createStatement();
             ResultSet result = stmt.executeQuery("SELECT FACILITYNAME FROM FACILITY FACILITYCODE =  '"+facilityCode+"'");
         while (result.next()) {
             facilityDesc = result.getString("FACILITYNAME");
         }
            
        }
        catch(SQLException e){
            return "";
            
        }
        setSelectedFacDesc(facilityDesc);
        return facilityDesc;
    }

    public void setSelectedFacDesc(String facDesc) {
        this.selectedFacDesc = facDesc;
    }
    public String getSelectedSysDesc(){

        String systemCode = getSelectedSys();
        String systemDesc = "";

        try {
         Connection conn = ds.getConnection();
         Statement stmt = conn.createStatement();
             ResultSet result = stmt.executeQuery("SELECT SYSTEMNAME FROM SYSTEMS SYSTEMCODE =  '"+systemCode+"'");
         while (result.next()) {
             systemDesc = result.getString("SYSTEMNAME");
         }

        }
        catch(SQLException e){
            return "";

        }
        setSelectedSysDesc(systemDesc);
        return systemDesc;
    }
    public void setSelectedSysDesc(String sysDesc){
        this.selectedSysDesc = sysDesc;
    }
}