update query

[Aditi agarwal]

Hi friends i am writing an update module but there is some problem which i am nt getting

my update query is not working instead if at this place i use insert query it works

my code is


this is my forgetpasswordaction file

/*
 * Generated by MyEclipse Struts
 * Template path: templates/java/JavaClass.vtl
 */
package ams.action;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
import ams.form.ForgetpasswdForm;

import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.SQLException;

import ams.database.*;
/** 
 * MyEclipse Struts
 * Creation date: 03-06-2011
 * 
 * XDoclet definition:
 * @struts.action path="/forgetpasswd" name="forgetpasswdForm" input="/forgetpasswd.jsp" scope="request" validate="true"
 * @struts.action-forward name="failure" path="/forgetpasswd.jsp"
 * @struts.action-forward name="success" path="/passwdsuccess"
 */
public class ForgetpasswdAction extends Action {
	/*
	 * Generated Methods
	 */

	/** 
	 * Method execute
	 * @param mapping
	 * @param form
	 * @param request
	 * @param response
	 * @return ActionForward
	 */
	public ActionForward execute(ActionMapping mapping, ActionForm form,
			HttpServletRequest request, HttpServletResponse response) {
		ForgetpasswdForm forgetpasswdForm = (ForgetpasswdForm) form;// TODO Auto-generated method stub
		Connection conn=new database().getConnection();
		PreparedStatement psat=null;
		try {
			 psat=conn.prepareStatement("UPDATE ams_login SET password=? where loginname=?;");
			psat.setString(1, forgetpasswdForm.getLoginname().trim());
			psat.setString(2, forgetpasswdForm.getPassword().trim());
			int result=psat.executeUpdate();
			String cpasswd=forgetpasswdForm.getConfirmpassword().trim();
			String passwd=forgetpasswdForm.getPassword().trim();
			if((result==1)&& (passwd.equals(cpasswd)))
			{
				return mapping.findForward("success");
			}
	   } 
		catch (SQLException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
			return mapping.findForward("failure");
		}
		return mapping.findForward("failure");
	}

}

[Joe Ess]

So what does happen? It Doesnt Work Is Useless

[Aditi agarwal]

its an update query so i want to update my database from my struts application
i need that when i change password in form that changes are reflected in the database

[Tom Rispoli]

We need specifics on is what happens when you run this code. Does it write anything to any of your log files? Does it go into that sql exception that you have a catch for? Does it just run the method completely with out updating the database but with out generating an error?

[Aditi agarwal]

Sorry for late reply i think the error is not in the update query but somewhere else

its giving an error

The column index is out of range: 1, number of columns: 0.

should i create a new message for it or it will be continue in this only

[Tom Rispoli]

When I get that error, it usually indicates that I am trying to set the value of a bind variable in an sql statement (using something like the psat.setString you have in your code) and I am specifying an index for it that is greater than the number of ? in the string. Your code doesn't appear to have that problem. Can you give the full stack trace of the error, including the line numbers, maybe this is happening some place unexpected.

[Aditi agarwal]

now today when i again run the program it gives a new error
the error log is here

Mar 10, 2011 9:47:22 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet action threw exception
java.lang.NullPointerException
	at ams.action.ForgetpasswdAction.execute(ForgetpasswdAction.java:49)
	at org.apache.struts.chain.commands.servlet.ExecuteAction.execute(ExecuteAction.java:58)
	at org.apache.struts.chain.commands.AbstractExecuteAction.execute(AbstractExecuteAction.java:67)
	at org.apache.struts.chain.commands.ActionCommandBase.execute(ActionCommandBase.java:51)
	at org.apache.commons.chain.impl.ChainBase.execute(ChainBase.java:190)
	at org.apache.commons.chain.generic.LookupCommand.execute(LookupCommand.java:304)
	at org.apache.commons.chain.impl.ChainBase.execute(ChainBase.java:190)
	at org.apache.struts.chain.ComposableRequestProcessor.process(ComposableRequestProcessor.java:283)
	at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1913)
	at org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:462)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:230)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:261)
	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
	at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:581)
	at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
	at java.lang.Thread.run(Thread.java:619)

[Tom Rispoli]

Assuming the line numbers in your action class are still the same, it sounds like either psat or forgetpasswdForm.getLoginname() is null at line 49, can you tell which and why?

[Aditi agarwal]

sorry again Tom for so late reply

actually i have change the code so the code is

/*
 * Generated by MyEclipse Struts
 * Template path: templates/java/JavaClass.vtl
 */
package ams.action;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
import ams.form.ForgetpasswdForm;

import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.SQLException;

import ams.database.*;
/** 
 * MyEclipse Struts
 * Creation date: 03-06-2011
 * 
 * XDoclet definition:
 * @struts.action path="/forgetpasswd" name="forgetpasswdForm" input="/forgetpasswd.jsp" scope="request" validate="true"
 * @struts.action-forward name="failure" path="/forgetpasswd.jsp"
 * @struts.action-forward name="success" path="/passwdsuccess"
 */
public class ForgetpasswdAction extends Action {
	/*
	 * Generated Methods
	 */

	/** 
	 * Method execute
	 * @param mapping
	 * @param form
	 * @param request
	 * @param response
	 * @return ActionForward
	 */
	public ActionForward execute(ActionMapping mapping, ActionForm form,
			HttpServletRequest request, HttpServletResponse response) {
		ForgetpasswdForm forgetpasswdForm = (ForgetpasswdForm) form;// TODO Auto-generated method stub
		Connection conn=new database().getConnection();
		PreparedStatement psat=null;
		try {
			 psat=conn.prepareStatement("UPDATE ams_login SET password=? where loginname=?;");
			psat.setString(1, forgetpasswdForm.getPassword().trim());
			psat.setString(2, forgetpasswdForm.getLoginname().trim());
			int result=psat.executeUpdate();
			String cpasswd=forgetpasswdForm.getConfirmpassword().trim();
			String passwd=forgetpasswdForm.getPassword().trim();
			if((result==1)&& (passwd.equals(cpasswd)))
			{
				return mapping.findForward("success");
			}
	   } 
		catch (SQLException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
			return mapping.findForward("failure");
		}
		return mapping.findForward("failure");
	}

}

the error is :

Mar 10, 2011 9:47:22 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet action threw exception
java.lang.NullPointerException
	at ams.action.ForgetpasswdAction.execute(ForgetpasswdAction.java:49)
	at org.apache.struts.chain.commands.servlet.ExecuteAction.execute(ExecuteAction.java:58)
	at org.apache.struts.chain.commands.AbstractExecuteAction.execute(AbstractExecuteAction.java:67)
	at org.apache.struts.chain.commands.ActionCommandBase.execute(ActionCommandBase.java:51)
	at org.apache.commons.chain.impl.ChainBase.execute(ChainBase.java:190)
	at org.apache.commons.chain.generic.LookupCommand.execute(LookupCommand.java:304)
	at org.apache.commons.chain.impl.ChainBase.execute(ChainBase.java:190)
	at org.apache.struts.chain.ComposableRequestProcessor.process(ComposableRequestProcessor.java:283)
	at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1913)
	at org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:462)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:230)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:261)
	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
	at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:581)
	at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
	at java.lang.Thread.run(Thread.java:619)

[Tom Rispoli]

My questions from my previous post still apply. All we really know is that you are trying to use a reference that is null on line 49. Can you determine which variable on line 49 is null and why?

[Aditi agarwal]

k i will try

[Aditi agarwal]

hi tom i have printed both values & they are not null
i don't know what is happening i am writing action file & error page

action file

/*
 * Generated by MyEclipse Struts
 * Template path: templates/java/JavaClass.vtl
 */
package ams.action;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
import ams.form.ForgetpasswdForm;

import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.SQLException;

import ams.database.*;
/** 
 * MyEclipse Struts
 * Creation date: 03-06-2011
 * 
 * XDoclet definition:
 * @struts.action path="/forgetpasswd" name="forgetpasswdForm" input="/forgetpasswd.jsp" scope="request" validate="true"
 * @struts.action-forward name="failure" path="/forgetpasswd.jsp"
 * @struts.action-forward name="success" path="/passwdsuccess"
 */
public class ForgetpasswdAction extends Action {
	/*
	 * Generated Methods
	 */

	/** 
	 * Method execute
	 * @param mapping
	 * @param form
	 * @param request
	 * @param response
	 * @return ActionForward
	 */
	public ActionForward execute(ActionMapping mapping, ActionForm form,
			HttpServletRequest request, HttpServletResponse response) {
		ForgetpasswdForm forgetpasswdForm = (ForgetpasswdForm) form;// TODO Auto-generated method stub
		Connection conn=new database().getConnection();
		String b = forgetpasswdForm.getPassword().trim();
		String c =forgetpasswdForm.getLoginname().trim();
		System.out.println(b);
		System.out.println(c);
		PreparedStatement psat=null;
		try {
			 psat=conn.prepareStatement("update ams_login set password='?' where loginname='?';");
			psat.setString(1, forgetpasswdForm.getPassword().trim());
			psat.setString(2, forgetpasswdForm.getLoginname().trim());
			int result=psat.executeUpdate();
			String cpasswd=forgetpasswdForm.getConfirmpassword().trim();
			String passwd=forgetpasswdForm.getPassword().trim();
			if((result==1)&& (passwd.equals(cpasswd)))
			{
				return mapping.findForward("success");
			}
	   } 
		catch (SQLException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
			return mapping.findForward("failure");
		}
		finally {
		      // Always close the database connection.
		      try {
		        if (conn != null) conn.close();
		      }
		      catch (SQLException ignored){
		        System.out.println(ignored);
		      }
		    }

		return mapping.findForward("failure");
	}

}

error :

Initialize action of type: ams.action.ForgetpasswdAction
js1234
jointsec
org.postgresql.util.PSQLException: The column index is out of range: 1, number of columns: 0.
	at org.postgresql.core.v3.SimpleParameterList.bind(SimpleParameterList.java:53)
	at org.postgresql.core.v3.SimpleParameterList.setStringParameter(SimpleParameterList.java:118)
	at org.postgresql.jdbc2.AbstractJdbc2Statement.bindString(AbstractJdbc2Statement.java:2155)
	at org.postgresql.jdbc2.AbstractJdbc2Statement.setString(AbstractJdbc2Statement.java:1276)
	at org.postgresql.jdbc2.AbstractJdbc2Statement.setString(AbstractJdbc2Statement.java:1262)
	at ams.action.ForgetpasswdAction.execute(ForgetpasswdAction.java:53)
	at org.apache.struts.chain.commands.servlet.ExecuteAction.execute(ExecuteAction.java:58)
	at org.apache.struts.chain.commands.AbstractExecuteAction.execute(AbstractExecuteAction.java:67)
	at org.apache.struts.chain.commands.ActionCommandBase.execute(ActionCommandBase.java:51)
	at org.apache.commons.chain.impl.ChainBase.execute(ChainBase.java:190)
	at org.apache.commons.chain.generic.LookupCommand.execute(LookupCommand.java:304)
	at org.apache.commons.chain.impl.ChainBase.execute(ChainBase.java:190)
	at org.apache.struts.chain.ComposableRequestProcessor.process(ComposableRequestProcessor.java:283)
	at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1913)
	at org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:462)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:230)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:261)
	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
	at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:581)
	at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
	at java.lang.Thread.run(Thread.java:619)

thank you

[Joe Ess]

Aditi agarwal wrote:

Initialize action of type: ams.action.ForgetpasswdAction
js1234
jointsec
org.postgresql.util.PSQLException: The column index is out of range: 1, number of columns: 0.
	

Sounds like you have a problem with your SQL query.

[Aditi agarwal]

but its working correctly with Postgre SQL i.e. my database

[Joe Ess]

So what is the difference between the query in your code and the query you run against the database?

[Tom Rispoli]

It sounds like you gone back to your earlier problem where you are trying to put a value into the first bind variable in a prepared statement but the prepared statement doesn't have any bind variables.

after this line:

psat=conn.prepareStatement("update ams_login set password='?' where loginname='?';");

try putting in some code to write psat.toString() to your log file, I wonder if the statement isn't being created correctly.

I'm not exactly sure what this will print out, but I read that postgres should write out the text of your prepared statement.

Let us know what it shows.

[sri ramvaithiyanathan]

Aditi agarwal wrote:
psat=conn.prepareStatement("update ams_login set password='?' where loginname='?';");
psat.setString(1, forgetpasswdForm.getPassword().trim());
psat.setString(2, forgetpasswdForm.getLoginname().trim());

You did mistake in update query dont use '?' use ? and remove ; from the query.
Let me know if you face any problem.

Regards,
Sriram.V

[Aditi agarwal]

thank you sri ramvaithiyanathan for your reply

i would like to ask then what should i write in place of the question marks should i write anything else
or
my query wouldlook like

update <tablename> set password =? where loginname =?


thank you

[sri ramvaithiyanathan]

your query should be like this
update tableName set column = ? where column = ?

psat.setString(1,XXX);
psat.setString(2,XXX);

The number 1 and 2 denoted the place of the ?
In XXX pass the value which you want to use in the query.
The XXX value and datatype used in your table should be of same.

Hope it clears your doubt.

Regards,
Sriram.V

[Aditi agarwal]

i have done all same but still its not working what could be the problem now ?

[Joe Ess]

We cannot possibly know because we cannot see your current code or the errors you are seeing. Please read our FAQ, HowToAskQuestionsOnJavaRanch. The better question you ask, the more help we can be.