problem in uploading a file

[Jatin sachdev]

<%@ page import="java.io.*" %>
<%
	//to get the content type information from JSP Request Header
	String contentType = request.getContentType();
	//here we are checking the content type is not equal to Null and as well as the passed data from mulitpart/form-data is greater than or equal to 0
	if ((contentType != null) && (contentType.indexOf("multipart/form-data") >= 0)) {
 		DataInputStream in = new DataInputStream(request.getInputStream());
		//we are taking the length of Content type data
		int formDataLength = request.getContentLength();
		byte dataBytes[] = new byte[formDataLength];
		int byteRead = 0;
		int totalBytesRead = 0;
		//this loop converting the uploaded file into byte code
		while (totalBytesRead < formDataLength) {
			byteRead = in.read(dataBytes, totalBytesRead, formDataLength);
			totalBytesRead += byteRead;
			}

		String file = new String(dataBytes);
		//for saving the file name
		String saveFile = file.substring(file.indexOf("filename=\"") + 10);
		saveFile = saveFile.substring(0, saveFile.indexOf("\n"));
		saveFile = saveFile.substring(saveFile.lastIndexOf("\\") + 1,saveFile.indexOf("\""));
		int lastIndex = contentType.lastIndexOf("=");
		String boundary = contentType.substring(lastIndex + 1,contentType.length());
		int pos;
		//extracting the index of file 
		pos = file.indexOf("filename=\"");
		pos = file.indexOf("\n", pos) + 1;
		pos = file.indexOf("\n", pos) + 1;
		pos = file.indexOf("\n", pos) + 1;
		int boundaryLocation = file.indexOf(boundary, pos) - 4;
		int startPos = ((file.substring(0, pos)).getBytes()).length;
		int endPos = ((file.substring(0, boundaryLocation)).getBytes()).length;

		// creating a new file with the same name and writing the content in new file
		FileOutputStream fileOut = new FileOutputStream(saveFile);
		fileOut.write(dataBytes, startPos, (endPos - startPos));
		fileOut.flush();
		fileOut.close();

		%><Br><table border="2"><tr><td><b>You have successfully upload the file by the name of:</b>
		<% out.println(saveFile); %></td></tr></table> <%
		}
%>

This particular code is uploading the file at /bin folder of tomcat server, but i want this to upload in webapps. i can't understand how it is storing in /bin. please suggest some solution.

[Bear Bibeault]

You are likely using a relative file path to specify the file location. That will put the file some non-deterinistic place as web apps have no concept of "current directory".

[Bear Bibeault]

And for goodness sakes, please move this code out of a JSP and put it into a servlet where it belongs.

[balakrishnabilla billa]

Hi,
please give the correct path where you wanted to create a file in server.
here i given a sample code here

           File f = new File("f:/Tomcat 5.5/webapps/"+saveFile);
			if(!f.exists()){
				f.createNewFile();
			}
           FileOutputStream fileOut = new FileOutputStream(f);  

before use, please remove the read only permissions to the web apps folder.

[Bear Bibeault]

balakrishnabilla billa wrote:please give the correct path where you wanted to create a file in server

But, of course, hard-coding the path as a string would be a very bad practice indeed.

Rather, determine the location programmatically.

Also, do you really want to upload a file into the web app? Really? What happens when you have to redeploy and update?

[Jatin sachdev]

Thanks for suggestion..............

But as Bear has said

do you really want to upload a file into the web app? Really? What happens when you have to redeploy and update?

where should i upload the file then...?
One more thing i want to ask --- Is there any easy code that i can understand and works accordingly for uploading file?
i dont know actually how to upload file....
please help and give some code snippet for uploading a file....

[Bear Bibeault]

See the JSP FAQ where file uploads are discussed.

With regards to where to put it, what is the purpose of the file?

[Jatin sachdev]

purpose of the file is to authenticate the user on the basis of some information in the file.
I have searched JSP FAQ but the link provided :

On the client

If you want to upload files in conjunction with Commons HttpClient, this introductory article tells how to use FileUpload in conjunction with the Commons HttpClient package.

is not working.............

[Jatin sachdev]

cant i use simple input sream to upload file...?

[Bear Bibeault]

Jatin sachdev wrote:cant i use simple input sream to upload file...?

The input stream contains a multipart request which is a pain in the rear to parse. No one in their right mind would try to reinvent the wheel when a number of perfectly good libraries that have already solved the problem exist.

Why do you need to write a file to authenticate a user?U