tictactoe help

[Anthony Pena]

so far i have this,

import java.awt.*;
import java.awt.*;  
import javax.swing.*;  

public class tictactoe extends JApplet implements ActionListener
{
	JLabel jlWin,jlTie;
	JButton b1,b2,b3,b4,b5,b6,b7,b8,b9;
	JPanel pane;
	Image x,o,e;
	string sLetter = "";
	ImageIcon icX,icO,icE;
	x = getImage(getCodeBase(),"Black_x.png");
	o = getImage(getCodeBase(),"o.gif");
	e = getImage(getCodeBase(),"empty.png");
	icE=new ImageIcon(e);
		
		
		b1= new JButton(icE);
		b2= new JButton(icE);
		b3= new JButton(icE);
		b4= new JButton(icE);
		b5= new JButton(icE);
		b6= new JButton(icE);
		b7= new JButton(icE);
		b8= new JButton(icE);
		b9= new JButton(icE);
		int iCount=0;
		boolean bWin = false;
		jlWin= new JLabel(sLetter + " Wins!");
		jlTie= new JLabel("NO ONE WINS!");
		
	public void init()
	{	
	setLayout (new GridLayout(3,3));
	add (b1);	add (b2);	add (b3);
	add (b4);	add (b5);	add (b6);
	add (b7);	add (b8);	add (b9);
	
	
	
	b1.addActionListener(this);
	b2.addActionListener(this);
	b3.addActionListener(this);
	b4.addActionListener(this);
	b5.addActionListener(this);
	b6.addActionListener(this);
	b7.addActionListener(this);
	b8.addActionListener(this);
	b9.addActionListener(this);
	}
	
	public void actionPerformed(ActionEvent a)
	{
	if(iCount==1 || iCount == 3||iCount==5||iCount==7||iCount==9)
	{
	icX=new ImageIcon(x);
	sLetter="X";
	}
	else if (iCount==2||iCount==4||iCount==6||iCount==8||iCount==10)
	{
	icX=new ImageIcon(o);
	sLetter="O";
	}
	if (a.getSource()== b1)
	{
	b1.setText(sLetter);
	b1.setIcon(icX);
	b1.setEnabled(False);
	}
	else if (a.getSource()==b2)
	{
	b1.setText(sLetter);
	b2.setIcon(icX);
	b2.setEnabled(False);
	}
	else if (a.getSource()== b3)
	{
	b1.setText(sLetter);
	b3.setIcon(icX);
	b3.setEnabled(False);
	}
	else if (a.getSource()== b4)
	{
	b1.setText(sLetter);
	b4.setIcon(icX);
	b4.setEnabled(False);
	}
	else if (a.getSource()== b5)
	{
	b1.setText(sLetter);
	b5.setIcon(icX);
	b5.setEnabled(False);
	}
	else if (a.getSource()== b6)
	{
	b1.setText(sLetter);
	b6.setIcon(icX);			
	b6.setEnabled(False);
	}	
	else if (a.getSource()== b7)
	{
	b1.setText(sLetter);
	b7.setIcon(icX);
	b7.setEnabled(False);
	}
	else if (a.getSource()== b8)
	{
	b1.setText(sLetter);
	b8.setIcon(icX);
	b8.setEnabled(False);
	}
	else if (a.getSource()== b9)
	{
	b1.setText(sLetter);
	b9.setIcon(icX);
	b9.setEnabled(False);
	}
	
	  //horizontal wins
        if( b1.getText() == b2.getText() && b2.getText() == b3.getText() && button1.getText() != ""){
            bWin = true;
        }
        else if(b4.getText() == b5.getText() && b5.getText() == b6.getText() && b4.getText() != ""){
            bWin = true;
        }
        else if(b7.getText() == b8.getText() && b8.getText() == b9.getText() && b7.getText() != ""){
            bWin = true;
        }
        
        //virticle wins
        else if(button1.getText() == b4.getText() && b4.getText() == b7.getText() && button1.getText() != ""){
            bWin = true;
        }
        else if(b2.getText() == b5.getText() && b5.getText() == b8.getText() && b2.getText() != ""){
            bWin = true;
        }
        else if(b3.getText() == b6.getText() && b6.getText() == b9.getText() && b3.getText() != ""){
            bWin = true;
        }
        
        //diagonal wins
        else if(button1.getText() == b5.getText() && b5.getText() == b9.getText() && button1.getText() != ""){
            bWin = true;
        }
        else if(b3.getText() == b5.getText() && b5.getText() == b7.getText() && b3.getText() != ""){
            bWin = true;
        }
        else {
            bWin = false;
        }
		  
		  if (bWin == true)
		  {
		  add (jlWin);
		  }
		  else if (count ==9&&win==false)
		  {
		  add (jlTie);
		  } 
		 
		 
	}
}
		  

where are the errors im getting, please help0.0

----jGRASP exec: javac -g tictactoe.java

tictactoe.java:13: <identifier> expected
x = getImage(getCodeBase(),"Black_x.png");
^
tictactoe.java:14: <identifier> expected
o = getImage(getCodeBase(),"o.gif");
^
tictactoe.java:15: <identifier> expected
e = getImage(getCodeBase(),"empty.png");
^
tictactoe.java:16: <identifier> expected
icE=new ImageIcon(e);
^
tictactoe.java:19: <identifier> expected
b1= new JButton(icE);
^
tictactoe.java:20: <identifier> expected
b2= new JButton(icE);
^
tictactoe.java:21: <identifier> expected
b3= new JButton(icE);
^
tictactoe.java:22: <identifier> expected
b4= new JButton(icE);
^
tictactoe.java:23: <identifier> expected
b5= new JButton(icE);
^
tictactoe.java:24: <identifier> expected
b6= new JButton(icE);
^
tictactoe.java:25: <identifier> expected
b7= new JButton(icE);
^
tictactoe.java:26: <identifier> expected
b8= new JButton(icE);
^
tictactoe.java:27: <identifier> expected
b9= new JButton(icE);
^
tictactoe.java:30: <identifier> expected
jlWin= new JLabel(sLetter + " Wins!");
^
tictactoe.java:31: <identifier> expected
jlTie= new JLabel("NO ONE WINS!");
^

please help 0.0 im so confused :-\

[Jesper de Jong]

Taking a quick look at this: line 11 is wrong, it should be String instead of string. Remember that Java is case-sensitive!

You cannot put arbitrary statements, which you have in lines 13 - 31, at class level. You can only add variable, constructor and method declarations (optionally with an initialization value for the variable) at class level. Put the statements from lines 13 - 31 in a constructor or method, or combine them with the declaration of the variables just above.

[Anthony Pena]

thank you!

[Anthony Pena]

how do you mean combine them?

[Anthony Pena]

import java.awt.*;  
import java.awt.event.*;
import javax.swing.*;  

public class tictactoe extends JApplet implements ActionListener
{
	String sLetter = "";
	JLabel jlWin= new JLabel(sLetter + " Wins!");
	JLabel jlTie= new JLabel("NO ONE WINS!");
	JButton b1,b2,b3,b4,b5,b6,b7,b8,b9;
	JPanel pane;
	Image x = getImage(getCodeBase(),"Black_x.png");
	Image o = getImage(getCodeBase(),"o.gif");
	Image e = getImage(getCodeBase(),"empty.png");

	
	ImageIcon icE=new ImageIcon(e);
		int iCount=0;
		boolean bWin = false;
		
		
		
	public void init()
	{	
		b1= new JButton(icE);
		b2= new JButton(icE);
		b3= new JButton(icE);
		b4= new JButton(icE);
		b5= new JButton(icE);
		b6= new JButton(icE);
		b7= new JButton(icE);
		b8= new JButton(icE);
		b9= new JButton(icE);
	setLayout (new GridLayout(3,3));
	add (b1);	add (b2);	add (b3);
	add (b4);	add (b5);	add (b6);
	add (b7);	add (b8);	add (b9);
	
	
	
	b1.addActionListener(this);
	b2.addActionListener(this);
	b3.addActionListener(this);
	b4.addActionListener(this);
	b5.addActionListener(this);
	b6.addActionListener(this);
	b7.addActionListener(this);
	b8.addActionListener(this);
	b9.addActionListener(this);
	}
	
	public void actionPerformed(ActionEvent a)
	{
	if(iCount==1 || iCount == 3||iCount==5||iCount==7||iCount==9)
	{
	icE=new ImageIcon(x);
	sLetter="X";
	}
	else if (iCount==2||iCount==4||iCount==6||iCount==8||iCount==10)
	{
	icE=new ImageIcon(o);
	sLetter="O";
	}
	if (a.getSource()== b1)
	{
	b1.setText(sLetter);
	b1.setIcon(icE);
	b1.setEnabled(false);
	}
	else if (a.getSource()==b2)
	{
	b1.setText(sLetter);
	b2.setIcon(icE);
	b2.setEnabled(false);
	}
	else if (a.getSource()== b3)
	{
	b1.setText(sLetter);
	b3.setIcon(icE);
	b3.setEnabled(false);
	}
	else if (a.getSource()== b4)
	{
	b1.setText(sLetter);
	b4.setIcon(icE);
	b4.setEnabled(false);
	}
	else if (a.getSource()== b5)
	{
	b1.setText(sLetter);
	b5.setIcon(icE);
	b5.setEnabled(false);
	}
	else if (a.getSource()== b6)
	{
	b1.setText(sLetter);
	b6.setIcon(icE);			
	b6.setEnabled(false);
	}	
	else if (a.getSource()== b7)
	{
	b1.setText(sLetter);
	b7.setIcon(icE);
	b7.setEnabled(false);
	}
	else if (a.getSource()== b8)
	{
	b1.setText(sLetter);
	b8.setIcon(icE);
	b8.setEnabled(false);
	}
	else if (a.getSource()== b9)
	{
	b1.setText(sLetter);
	b9.setIcon(icE);
	b9.setEnabled(false);
	}
	
	  //horizontal wins
        if( b1.getText() == b2.getText() && b2.getText() == b3.getText() && b1.getText() != ""){
            bWin = true;
        }
        else if(b4.getText() == b5.getText() && b5.getText() == b6.getText() && b4.getText() != ""){
            bWin = true;
        }
        else if(b7.getText() == b8.getText() && b8.getText() == b9.getText() && b7.getText() != ""){
            bWin = true;
        }
        
        //virticle wins
        else if(b1.getText() == b4.getText() && b4.getText() == b7.getText() && b1.getText() != ""){
            bWin = true;
        }
        else if(b2.getText() == b5.getText() && b5.getText() == b8.getText() && b2.getText() != ""){
            bWin = true;
        }
        else if(b3.getText() == b6.getText() && b6.getText() == b9.getText() && b3.getText() != ""){
            bWin = true;
        }
        
        //diagonal wins
        else if(b1.getText() == b5.getText() && b5.getText() == b9.getText() && b1.getText() != ""){
            bWin = true;
        }
        else if(b3.getText() == b5.getText() && b5.getText() == b7.getText() && b3.getText() != ""){
            bWin = true;
        }
        else {
            bWin = false;
        }
		  
		  if (bWin == true)
		  {
		  add (jlWin);
		  }
		  else if (iCount ==9 && bWin==false)
		  {
		  add (jlTie);
		  } 
		 
		 
	}
}

got rid of all my errors, but now its not running ? it says it didn initialize

[Rob Spoor]

Check the Java Console in your system tray, there's probably an exception. Post the full stack trace here.

[Anthony Pena]

Rob Spoor wrote:Check the Java Console in your system tray, there's probably an exception. Post the full stack trace here.

java.lang.NullPointerException
at java.applet.Applet.getCodeBase(Applet.java:152)
at tictactoe.<init>(tictactoe.java:12)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
at java.lang.Class.newInstance0(Class.java:355)
at java.lang.Class.newInstance(Class.java:308)
at sun.applet.AppletPanel.createApplet(AppletPanel.java:785)
at sun.applet.AppletPanel.runLoader(AppletPanel.java:714)
at sun.applet.AppletPanel.run(AppletPanel.java:368)
at java.lang.Thread.run(Thread.java:662)

[Campbell Ritchie]

It looks as if the problem is on line 12.
You have made things difficult for yourself by trying to write the whole thing in one go. You ought to do it bit by bit.

Try printing the code base URL and the toString method of the Image to screen; then you can narrow down where the error occurs: is it code base or is it the image?

And the length of your actionPerformed method is a good example of why addActionListener(this) is poor, non-object-oriented programming. Even though there are lots of books which show such code.

[Anthony Pena]

Campbell Ritchie wrote:It looks as if the problem is on line 12.
You have made things difficult for yourself by trying to write the whole thing in one go. You ought to do it bit by bit.

Try printing the code base URL and the toString method of the Image to screen; then you can narrow down where the error occurs: is it code base or is it the image?

And the length of your actionPerformed method is a good example of why addActionListener(this) is poor, non-object-oriented programming. Even though there are lots of books which show such code.

java.lang.NullPointerException

at java.applet.Applet.getCodeBase(Applet.java:152)
at tictactoe.<init>(tictactoe.java:12)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
at java.lang.Class.newInstance0(Class.java:355)
at java.lang.Class.newInstance(Class.java:308)
at sun.applet.AppletPanel.createApplet(AppletPanel.java:785)
at sun.applet.AppletPanel.runLoader(AppletPanel.java:714)
at sun.applet.AppletPanel.run(AppletPanel.java:368)
at java.lang.Thread.run(Thread.java:662)
thats the one with the issue i think

[Campbell Ritchie]

. . . and have you done anything else with line 12?

[Anthony Pena]

Campbell Ritchie wrote: . . . and have you done anything else with line 12?

im not sure what there is to do? i changed the name of the image to something more simple? should i try a different image?

[Rob Spoor]

You're trying to run your applet from an IDE, aren't you? Because line 152 of java.awt.Applet says

return stub.getCodeBase();

which means that "stub" is null. That field is set by calling setStub on the Applet instance, something that should automatically be done when the applet is called from a browser or the appletviewer application.

[Wim Vanni]

Tried the code in an Eclipse project. (Had to get some images of my own for this.)

	public void init() {
		try {
			x = getImage(new File("./tictactoe/images").toURI().toURL(), "Black_x.png");
			o = getImage(new File("./tictactoe/images").toURI().toURL(), "Red_o.png");
			e = getImage(new File("./tictactoe/images").toURI().toURL(), "empty.png");
		} catch (MalformedURLException e1) {
			// TODO Auto-generated catch block
			e1.printStackTrace();
		}
		
		icE = new ImageIcon(e);
		

I moved the images to a specific folder in the project and had them loaded from there. This solved the 'not initialized' error. There were some more things to tackle before I could enjoy a game of tic-tac-toe though ;-)

If you want hints:

iCount starts at 0; it never changes

the 'win label' isn't showing dynamically the winning letter (move the assignment)

the actionlistener is working on wrong JButtons in several places

If you haven't already, take a look at Oracle's (Sun's) page on creating applets. The tutorial and example there could keep you from falling into some other pitfalls.

Have fun!
Wim

[Anthony Pena]

import java.awt.*;    
import java.awt.event.*;  
import javax.swing.*;    

public class tictactoe extends JApplet implements ActionListener  
{  
	String sLetter = "";  
	JLabel jlWin= new JLabel(sLetter + " Wins!");  
	JLabel jlTie= new JLabel("NO ONE WINS!");  
	JButton b1,b2,b3,b4,b5,b6,b7,b8,b9;  
	JPanel pane = new JPanel();;  
	Image imageX; // marks field with 'x'
	Image imageO; // marks field with 'o'
	Image imageE; // marks field with '', empty
	ImageIcon icE;



	int iCount=0;  
	boolean bWin = false;  



	public void init()  
	{     

		imageX = getImage(getCodeBase(),"blcx.png");  
		imageO = getImage(getCodeBase(),"o.gif");  
		imageE = getImage(getCodeBase(),"empty.png");  
		icE=new ImageIcon(imageE);  

		b1= new JButton(icE);  
		b2= new JButton(icE);  
		b3= new JButton(icE);  
		b4= new JButton(icE);  
		b5= new JButton(icE);  
		b6= new JButton(icE);  
		b7= new JButton(icE);  
		b8= new JButton(icE);  
		b9= new JButton(icE);  
		pane.setLayout (new GridLayout(3,3));  
		pane.add (b1);   pane.add (b2);  pane.add (b3);  
		pane.add (b4);   pane.add (b5);  pane.add (b6);  
		pane.add (b7);   pane.add (b8);  pane.add (b9);  

		add (pane,BorderLayout.CENTER);  
		setFocusable(true);  


		b1.addActionListener(this);  
		b2.addActionListener(this);  
		b3.addActionListener(this);  
		b4.addActionListener(this);  
		b5.addActionListener(this);  
		b6.addActionListener(this);  
		b7.addActionListener(this);  
		b8.addActionListener(this);  
		b9.addActionListener(this);  
	}  

	public void actionPerformed(ActionEvent a)  
	{  
		iCount++;
		if(iCount==1 || iCount == 3||iCount==5||iCount==7||iCount==9)  
		{  
			icE=new ImageIcon(imageX);  
			sLetter="X";  
		}  
		else if (iCount==2||iCount==4||iCount==6||iCount==8||iCount==10)  
		{  
			icE=new ImageIcon(imageO);  
			sLetter="O";  
		}  

		if (a.getSource()== b1)  
		{  
			b1.setText(sLetter);  
			b1.setIcon(icE);  
			b1.setEnabled(false);  
		}  
		else if (a.getSource()==b2)  
		{  
			b2.setText(sLetter);  
			b2.setIcon(icE);  
			b2.setEnabled(false);  
		}  
		else if (a.getSource()== b3)  
		{  
			b3.setText(sLetter);  
			b3.setIcon(icE);  
			b3.setEnabled(false);  
		}  
		else if (a.getSource()== b4)  
		{  
			b4.setText(sLetter);  
			b4.setIcon(icE);  
			b4.setEnabled(false);  
		}  
		else if (a.getSource()== b5)  
		{  
			b5.setText(sLetter);  
			b5.setIcon(icE);  
			b5.setEnabled(false);
			  
		}  
		else if (a.getSource()== b6)  
		{  
			b6.setText(sLetter);  
			b6.setIcon(icE);              
			b6.setEnabled(false);  
		}     
		else if (a.getSource()== b7)  
		{  
			b7.setText(sLetter);  
			b7.setIcon(icE);  
			b7.setEnabled(false);  
		}  
		else if (a.getSource()== b8)  
		{  
			b8.setText(sLetter);  
			b8.setIcon(icE);  
			b8.setEnabled(false);  
		}  
		else if (a.getSource()== b9)  
		{  
			b9.setText(sLetter);  
			b9.setIcon(icE);  
			b9.setEnabled(false);  
		}  

		//horizontal wins  
		if( b1.getText() == b2.getText() && b2.getText() == b3.getText() && b1.getText() != ""){  
			bWin = true;  
			b1.setBackground(Color.BLUE);
			b2.setBackground(Color.BLUE);
			b3.setBackground(Color.BLUE);
		}  
		else if(b4.getText() == b5.getText() && b5.getText() == b6.getText() && b4.getText() != ""){  
			bWin = true;  
			b4.setBackground(Color.BLUE);
			b5.setBackground(Color.BLUE);
			b6.setBackground(Color.BLUE);
		}  
		else if(b7.getText() == b8.getText() && b8.getText() == b9.getText() && b7.getText() != ""){  
			bWin = true;  
			b7.setBackground(Color.BLUE);
			b8.setBackground(Color.BLUE);
			b9.setBackground(Color.BLUE);
		}  

		//vertical wins  
		else if(b1.getText() == b4.getText() && b4.getText() == b7.getText() && b1.getText() != ""){  
			bWin = true;  
			b1.setBackground(Color.BLUE);
			b4.setBackground(Color.BLUE);
			b7.setBackground(Color.BLUE);

		}  
		else if(b2.getText() == b5.getText() && b5.getText() == b8.getText() && b2.getText() != ""){  
			bWin = true;  
			b2.setBackground(Color.BLUE);
			b5.setBackground(Color.BLUE);
			b8.setBackground(Color.BLUE);
		}  
		else if(b3.getText() == b6.getText() && b6.getText() == b9.getText() && b3.getText() != ""){  
			bWin = true;  
			b3.setBackground(Color.BLUE);
			b6.setBackground(Color.BLUE);
			b9.setBackground(Color.BLUE);
		}  

		//diagonal wins  
		else if(b1.getText() == b5.getText() && b5.getText() == b9.getText() && b1.getText() != ""){  
			bWin = true;  
			b1.setBackground(Color.BLUE);
			b5.setBackground(Color.BLUE);
			b9.setBackground(Color.BLUE);
		}  
		else if(b3.getText() == b5.getText() && b5.getText() == b7.getText() && b3.getText() != ""){  
			bWin = true;  
			b3.setBackground(Color.BLUE);
			b5.setBackground(Color.BLUE);
			b7.setBackground(Color.BLUE);
		}  
		else {  
			bWin = false;  
		}  
		if (bWin == true)  
		{  
			b1.setEnabled(false);  
			b2.setEnabled(false);  
			b3.setEnabled(false);  
			b4.setEnabled(false);  
			b5.setEnabled(false);  
			b6.setEnabled(false);  
			b7.setEnabled(false);  
			b8.setEnabled(false);  
			b9.setEnabled(false);  
			b5.setText(sLetter+" wins");
		}  
		else if (iCount ==9 && bWin==false)  
		{  
				b1.setEnabled(false);  
			b2.setEnabled(false);  
			b3.setEnabled(false);  
			b4.setEnabled(false);  
			b5.setEnabled(false);  
			b6.setEnabled(false);  
			b7.setEnabled(false);  
			b8.setEnabled(false);  
			b9.setEnabled(false); 
			b5.setText("tie!");
		
		}   
		


	}  
}

so after alot of work thats what i got, it works, im happy lol

[Rob Spoor]

Well, that of course make sense. You previously initialized the images when the applet was created. At that time it did not have an AppletStub yet. At the time init() is called it does, so getCodeBase() will work at that point.

So the lesson learned (also for me!): do not call any methods of java.awt.Applet (or javax.swing.JApplet) until init() has been called, as you can't guarantee that they will work before that time.