Cannot find the problem in the code

[Himanshu S. Soni]

I am using Eclipse ADT to learn developing android application.

This simple piece of code given below is used to accept username and password from user, and display it on the next page after hitting Go button.

package academic.Test;

import android.app.Activity;
import android.os.Bundle;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.EditText;

public class Test extends Activity {
    public static String Uname,Upass;
	private EditText name;
	private EditText pass;
	private Button Go;
	/** Called when the activity is first created. */
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);
        
        Go = (Button) findViewById(R.id.Go);          //line 1
        name = (EditText) findViewById(R.id.name);
        pass = (EditText) findViewById(R.id.pass);
        Go.setOnClickListener(new OnClickListener(){

			public void onClick(View v) {
				Uname = name.getText().toString();
				Upass = pass.getText().toString();
				
			}
        	
        });      //line 2
    }
}

The code has no errors as far as i know.
However, when i run this code , i get the error

The application login(process academic.login) has stopped unexpectedly.
Please try again.

One more thing which i found out, is that when i comment out from the code from line 1 to line 2. The UI boots up perfectly.
The same problem happened when i was building a calculator, which too is incomplete as a resukt of this problem.
Others sample applications run perfectly, so i am not able to pin point the errors.

[zoheb hassan]

Please Post your complete Code, this code however looks fine with the exception that you have not specified a intent to navigate to next screen also check your Manifest if you have mentioned your second activity there

[Himanshu S. Soni]

package academic.Test;

import android.app.Activity;
import android.content.Intent;
import android.os.Bundle;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.EditText;

public class Test extends Activity {
    public static String Uname,Upass;
	private EditText name;
	private EditText pass;
	private Button Go;
	/** Called when the activity is first created. */
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);
        
        Go = (Button) findViewById(R.id.Go);
        name = (EditText) findViewById(R.id.name);
        pass = (EditText) findViewById(R.id.pass);
        Go.setOnClickListener(new OnClickListener(){

			public void onClick(View v) {
				Uname = name.getText().toString();
				Upass = pass.getText().toString();
				launchPost();
			}
        	
        });
    }
    protected void launchPost() {
        Intent i = new Intent(this, Post.class);
        startActivity(i);
    }
}

This is my manifest file.
i have to screens Test -> Post. The above code resembles the Test.java activity.

<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
      package="academic.Test"
      android:versionCode="1"
      android:versionName="1.0">


    <application android:icon="@drawable/icon" android:label="@string/app_name">
        <activity android:name=".Test"
                  android:label="@string/app_name">
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />
                <category android:name="android.intent.category.LAUNCHER" />
            </intent-filter>
        </activity>
        <activity android:name="Post" android:label="@string/app_name">
        </activity>
    </application>
</manifest>

Are there any other places, i should check for errors ?

[zoheb hassan]

Just use a .Post in android:name attribute and in onClick method

public void onClick(View v) {
Uname = name.getText().toString();
Upass = pass.getText().toString();
new Intent(getBaseContext(), Post.class);
startActivity(i);
}
});

this should work without any errors.Let us know the result

[Himanshu S. Soni]

I made the changes as per your guidance. But no luck.
The application stops unexpectedly.

i will send you the project.
Tell me how to.
Please let me know what error is causing this problem.
As a result of this error, my entire practical work is halted.
I made a calculator, but the same problem persists in it too.

[zoheb hassan]

Place the code in launchpost method in onclick method and try, it should work if not then post your code here like the way you did earlier and we will solve it

-Zoheb

[Himanshu S. Soni]

No success.
as i said, when i comment out the implementation of onCreate(), the UI boots fine.

Test.java ------ screen 1

package com.academic.Test;

import academic.Test.R;
import android.app.Activity;
import android.content.Intent;
import android.os.Bundle;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.EditText;

public class Test extends Activity {
    public static String Uname,Upass;
	private EditText name;
	private EditText pass;
	private Button Go;
	/** Called when the activity is first created. */
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);
        
        Go = (Button) findViewById(R.id.Go1);
        name = (EditText) findViewById(R.id.name1);
        pass = (EditText) findViewById(R.id.pass1);
        Go.setOnClickListener(new OnClickListener(){

			public void onClick(View v) {
				Uname = name.getText().toString();
				Upass = pass.getText().toString();
				launchPost();
			}
        	
        });
    }
    public void launchPost()
    {
    	Intent i = new Intent(getBaseContext(), Post.class);
        startActivity(i);
    }
}

Post.java ------ Screen 2

package academic.Test;

import android.app.Activity;
import android.os.Bundle;
import android.widget.TextView;

public class Post extends Activity{
private TextView name;
private TextView pass;
	@Override
	protected void onCreate(Bundle savedInstanceState) {
		super.onCreate(savedInstanceState);
		setContentView(R.layout.post);
		name = (TextView)findViewById(R.id.name1);
		pass = (TextView)findViewById(R.id.pass1);
		name.setText(Test.Uname);
		pass.setText(Test.Upass);		
	}

}

[zoheb hassan]

Error is at Line number 27,28 of Test Activity where you are trying to set the values of the text View, Trying to use a Static text String would work for java Classes for an Activity however it wont.However you can pass the values from one activity to another via Bundle and retrieve it in another activity using Key Value Pairs

In Activity1
eg:    Intent i=new Intent(getBaseContext(),Activity2.class);
         i.putExtra("KEY", "VALUE");
         startActivity(i);

and receive it in Activity2
       String val=getIntent().getStringExtra("KEY");

However the exact reason why static String wont work here is something i am not aware of.Lets hope someone answers this in the forum

Best Regards,
-Zoheb