JTable date edit problem

[Giuseppa Cefalu]

Hi,

I am working on a JTable AbstractTableModel application. I made the table editable, and I can edit String and Integer values; however, the date column cells do not respont to a mouse click and cannot be edited. Is there any particular way to make date cells editable. Thank you for ypur help.

Giuseppa

[Rob Camick]

Why are you creating a custom model? Just use the DefaultTableModel:

import java.awt.*;
import java.util.*;
import javax.swing.*;
import javax.swing.table.*;

public class TableBasic extends JPanel
{
	public TableBasic()
	{
		String[] columnNames = {"Date", "String", "Integer", "Boolean"};

		Object[][] data =
		{
			{new Date(), "A", new Double(1), Boolean.TRUE },
			{new Date(), "B", new Double(2), Boolean.FALSE},
			{new Date(), "C", new Double(9), Boolean.TRUE },
			{new Date(), "D", new Double(4), Boolean.FALSE}
		};

		DefaultTableModel model = new DefaultTableModel(data, columnNames);

		JTable table = new JTable(model)
		{
			//  Returning the Class of each column will allow different
			//  renderers and editors to be used based on Class

			public Class getColumnClass(int column)
			{
				for (int row = 0; row < getRowCount(); row++)
				{
					Object o = getValueAt(row, column);

					if (o != null)
						return o.getClass();
				}

				return Object.class;
			}
		};
		table.setPreferredScrollableViewportSize(table.getPreferredSize());
		JScrollPane scrollPane = new JScrollPane( table );
		scrollPane.setVerticalScrollBarPolicy(ScrollPaneConstants.VERTICAL_SCROLLBAR_ALWAYS);
		add( scrollPane );
	}

	private static void createAndShowUI()
	{
		JFrame frame = new JFrame("TableBasic");
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		frame.add( new TableBasic() );
		frame.pack();
		frame.setLocationRelativeTo( null );
		frame.setVisible( true );
	}

	public static void main(String[] args)
	{
		EventQueue.invokeLater(new Runnable()
		{
			public void run()
			{
				createAndShowUI();
			}
		});
	}
}

[Giuseppa Cefalu]

Thank you Rob. I will try it; but could you check my new post?

Giuseppa

[Rob Spoor]

Next time, keep it all in one thread please. For those interested, the code is found here.

[Rob Spoor]

If the cell is not editable, then rowNew must be false and the column number must be 0.

[Arun Chidam]

if(col == 0){   //is this your date column?
  
                return false;   
            }

[Giuseppa Cefalu]

Thank you all for your replies. This is the way to do it. The cell renderer is for display and formatting; and the cell editor if for editing

Giuseppa

   public class CellRenderer extends DefaultTableCellRenderer{

    public Component getTableCellRendererComponent(JTable table, Object value,
            boolean isSelected, boolean hasFocus, int row, int col){
        super.getTableCellRendererComponent( table, value, isSelected, hasFocus, row, col );


            if(value instanceof Date){

                String strDate = new SimpleDateFormat("yyyy-MM-dd").format((Date)value);
                this.setText(strDate);
            }

        return this;
    }
    }

    public class CellEditor extends DefaultCellEditor{

        JTextField textField;

        public CellEditor(){

            super(new JTextField());
        }

         
	// the editor must return a Date object
	public Object getCellEditorValue()
	{
	    try
	    {
		if (textField.getText().trim().length() == 0)
		    return null; 

		SimpleDateFormat fm = new SimpleDateFormat("yyyy-MM-dd");
		java.util.Date utilDate = fm.parse(textField.getText().trim());
		java.sql.Date sqlDate = new java.sql.Date(utilDate.getTime());
		
		return sqlDate; 
	    }
	    catch (ParseException e)
	    {
		ExceptionEvent event = new ExceptionEvent(this,
                        "Invalid Date Format. Date must be in form yyyy-MM-dd");

                return textField.getText();

		
	    }

	}

    }

[Giuseppa Cefalu]

Does any body know how to implement the other procedures for public class CellEditor extends DefaultCellEditor? The tabble accepts insertion of the cursor and changing of the date on the cell; but in order for the change to occur in the internal data structure, I need to be able to move the cursor to the next cell using the arrow key. I think that in order to accomplish this I need to implement other methods.

Thank you,

Giuseppa

  public class CellEditor extends DefaultCellEditor{

        JTextField textField;

        public CellEditor(){

            super(new JTextField());
        }

         
	// the editor must return a Date object
	public Object getCellEditorValue()
	{
	    try
	    {
		if (textField.getText().trim().length() == 0)
		    return null; 

		SimpleDateFormat fm = new SimpleDateFormat("yyyy-MM-dd");
		java.util.Date utilDate = fm.parse(textField.getText().trim());
		java.sql.Date sqlDate = new java.sql.Date(utilDate.getTime());
		
		return sqlDate; 
	    }
	    catch (ParseException e)
	    {
		ExceptionEvent event = new ExceptionEvent(this,
                        "Invalid Date Format. Date must be in form yyyy-MM-dd");

                return textField.getText();

		
	    }

	}

    }
 

[Rob Spoor]

The following are the default renderer and editor for dates, as found in the source* of JTable:

    static class DateRenderer extends DefaultTableCellRenderer.UIResource {
	DateFormat formatter;
	public DateRenderer() { super(); }

	public void setValue(Object value) {
	    if (formatter==null) {
		formatter = DateFormat.getDateInstance();
	    }
	    setText((value == null) ? "" : formatter.format(value));
	}
    }

    static class GenericEditor extends DefaultCellEditor {

	Class[] argTypes = new Class[]{String.class};
	java.lang.reflect.Constructor constructor;
	Object value;

	public GenericEditor() {
            super(new JTextField());
            getComponent().setName("Table.editor");
        }

	public boolean stopCellEditing() {
	    String s = (String)super.getCellEditorValue();
	    // Here we are dealing with the case where a user
	    // has deleted the string value in a cell, possibly
	    // after a failed validation. Return null, so that
	    // they have the option to replace the value with
	    // null or use escape to restore the original.
	    // For Strings, return "" for backward compatibility.
	    if ("".equals(s)) {
		if (constructor.getDeclaringClass() == String.class) {
		    value = s;
		}
		super.stopCellEditing();
	    }

	    try {
		value = constructor.newInstance(new Object[]{s});
	    }
	    catch (Exception e) {
		((JComponent)getComponent()).setBorder(new LineBorder(Color.red));
		return false;
	    }
	    return super.stopCellEditing();
	}

	public Component getTableCellEditorComponent(JTable table, Object value,
						 boolean isSelected,
						 int row, int column) {
	    this.value = null;
            ((JComponent)getComponent()).setBorder(new LineBorder(Color.black));
	    try {
		Class type = table.getColumnClass(column);
		// Since our obligation is to produce a value which is
		// assignable for the required type it is OK to use the
		// String constructor for columns which are declared
		// to contain Objects. A String is an Object.
		if (type == Object.class) {
		    type = String.class;
		}
		constructor = type.getConstructor(argTypes);
	    }
	    catch (Exception e) {
		return null;
	    }
	    return super.getTableCellEditorComponent(table, value, isSelected, row, column);
	}

	public Object getCellEditorValue() {
	    return value;
	}
    }

The problem with both is that neither allows you to specify the DateFormat to use. For the renderer that's easy - simply change the line that initializes formatter. The editor is a bit trickier - you need to reimplement stopCellEditing and getTableCellEditorComponent:

    @Override
    public boolean stopCellEditing()
    {
        String s = (String)super.getCellEditorValue();
        // Here we are dealing with the case where a user
        // has deleted the string value in a cell, possibly
        // after a failed validation. Return null, so that
        // they have the option to replace the value with
        // null or use escape to restore the original.
        // For Strings, return "" for backward compatibility.
        if ("".equals(s))
        {
            value = null;
            return super.stopCellEditing();
        }
        try
        {
            value = format.parse(s);
        }
        catch (ParseException e)
        {
            ((JComponent)getComponent()).setBorder(new LineBorder(Color.red));
            return false;
        }
        return super.stopCellEditing();
    }

    @Override
    public Component getTableCellEditorComponent(JTable table, Object value,
                                                 boolean isSelected, int row,
                                                 int column)
    {
        this.value = null;
        ((JComponent)getComponent()).setBorder(new LineBorder(Color.black));
        if (value instanceof Date)
        {
            Date d = (Date)value;
            value = format.format(d);
        }
        return super.getTableCellEditorComponent(
            table, value, isSelected, row, column
        );
    }

Here, format is a DateFormat object to use. As you can see, the code is still very similar to the GenericEditor. The differences are using a null Date if the cell content is empty, and using DateFormat for both parsing and displaying, instead of using a sole constructor that takes a String and the toString method.


* check out file src.zip inside the JDK folder.

[Giuseppa Cefalu]

Hi,

Thank you Rob.

This time I have added the editor class to my TableEditor. I can insert the cursor and move the cursor from one cell to onother; ALso I can insert new text and overwrite the cell; but the contents for date in the program data structure do not get edited. Could you help me with this please?

Thank you

Giuseppa

package database;



import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import javax.swing.event.*;
import javax.swing.table.*;
import java.util.Date;
import java.sql.*;
import java.util.*;
import java.text.SimpleDateFormat;
import java.text.ParseException;
import javax.swing.border.Border;
import javax.swing.border.LineBorder;




public class TableEditor extends JFrame{
private JPanel panel;
public JTable table;
private JButton insert;
private JButton update;
private JButton delete;
private DatabaseT dbtable;
private JScrollPane pane;
private boolean DEBUG = true;

    public TableEditor(){

        setLayout(new BorderLayout());
        panel = new JPanel();
        dbtable = new DatabaseT();
        table = new JTable(dbtable);
        table.setDefaultRenderer(Date.class, new  CellRenderer());
        table.setDefaultEditor(java.sql.Date.class, new CellEditor());

        insert = new JButton("Insert");
        update = new JButton("Update");
        delete = new JButton("Delete");
        table.setAutoResizeMode(JTable.AUTO_RESIZE_OFF);
        pane = new JScrollPane(table, JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED,
                JScrollPane.HORIZONTAL_SCROLLBAR_ALWAYS);
        pane.getViewport().setBackground(Color.white);

        add(pane, BorderLayout.NORTH);
        add(panel, BorderLayout.SOUTH);

        panel.setLayout(new FlowLayout());
        panel.add(insert);
        panel.add(update);
        panel.add(delete);

        update.addActionListener(new ActionListener(){

            public void actionPerformed(ActionEvent e){
                dbtable.updateDB();
            }

        });

         insert.addActionListener(new ActionListener(){

             public void actionPerformed(ActionEvent e){

                 dbtable.addRow();
                 table.setEditingRow(dbtable.getRowCount());
                 table.setRowSelectionInterval(dbtable.getRowCount()-1,
                         dbtable.getRowCount()-1);
             }
         });

        setSize(400,200);
        setVisible(true);

        addWindowListener(new WindowAdapter(){

            public void windowClosing(WindowEvent e){

                System.exit(0);
            }

        });

        if (DEBUG) {
            table.addMouseListener(new MouseAdapter() {
                public void mouseClicked(MouseEvent e) {
                    printDebugData(table);
                }
            });
        }

    }

    private void printDebugData(JTable table) {
        int numRows = table.getRowCount();
        int numCols = table.getColumnCount();
        javax.swing.table.TableModel model = table.getModel();

        System.out.println("Value of data: ");
        for (int i=0; i < numRows; i++) {
            System.out.print("    row " + i + ":");
            for (int j=0; j < numCols; j++) {
                System.out.print("  " + model.getValueAt(i, j));
            }
            System.out.println();
        }
        System.out.println("--------------------------");
    }

    public static void main(String args[]){

        TableEditor editor = new TableEditor();

    }

    public class CellRenderer extends DefaultTableCellRenderer{

    public Component getTableCellRendererComponent(JTable table, Object value,
            boolean isSelected, boolean hasFocus, int row, int col){
        super.getTableCellRendererComponent( table, value, isSelected, hasFocus, row, col );


            if(value instanceof java.sql.Date){

                String strDate = new SimpleDateFormat("yyyy-MM-dd").format((Date)value);
                this.setText(strDate);
            }

        return this;
    }
    }

    public class CellEditor extends DefaultCellEditor{

         Object myValue;

         JTextField textField;

         public CellEditor( ){

            super(new JTextField());

         }
  
  public Component getTableCellEditorComponent(JTable table, Object value,
                                                 boolean isSelected, int row,
                                                 int column)
    {

            return super.getTableCellEditorComponent(
            table, value, isSelected, row, column
            );
    }

 public Object getCellEditorValue(){

     try
        {
        if (textField.getText().trim().length() == 0)
            return null;

        SimpleDateFormat fm = new SimpleDateFormat("yyyy-MM-dd");
        java.util.Date utilDate = fm.parse(textField.getText().trim());
        java.sql.Date sqlDate = new java.sql.Date(utilDate.getTime());

        return sqlDate;
        }
        catch (ParseException e)
        {
        ExceptionEvent event = new ExceptionEvent(this,
                        "Invalid Date Format. Date must be in form yyyy-MM-dd");

                return textField.getText();
        }
 }



 public boolean stopcellEditing(){
      String s = (String)super.getCellEditorValue();
        // Here we are dealing with the case where a user
        // has deleted the string value in a cell, possibly
        // after a failed validation. Return null, so that
        // they have the option to replace the value with
        // null or use escape to restore the original.
        // For Strings, return "" for backward compatibility.
         if ("".equals(s))
        {
            myValue = null;
            return super.stopCellEditing();
        }

        try{
            SimpleDateFormat lFormat = new SimpleDateFormat("yyyy-MM-dd");
            myValue = lFormat.parse(s);
        }catch(ParseException e){
            ((JComponent)getComponent()).setBorder(new LineBorder(Color.red));
            return false;

        }
      
        return super.stopCellEditing();
 }


    }
}

[Giuseppa Cefalu]

Hi,

Thank you Rob.

This time I have added the editor class to my TableEditor. I can insert the cursor and move the cursor from one cell to onother; ALso I can insert new text and overwrite the cell; but the contents for date in the program data structure do not get edited. Could you help me with this please?

Thank you

Giuseppa

package database;

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import javax.swing.event.*;
import javax.swing.table.*;
import java.util.Date;
import java.sql.*;
import java.util.*;
import java.text.SimpleDateFormat;
import java.text.ParseException;
import javax.swing.border.Border;
import javax.swing.border.LineBorder;




public class TableEditor extends JFrame{
private JPanel panel;
public JTable table;
private JButton insert;
private JButton update;
private JButton delete;
private DatabaseT dbtable;
private JScrollPane pane;
private boolean DEBUG = true;

    public TableEditor(){

        setLayout(new BorderLayout());
        panel = new JPanel();
        dbtable = new DatabaseT();
        table = new JTable(dbtable);
        table.setDefaultRenderer(Date.class, new  CellRenderer());
        table.setDefaultEditor(java.sql.Date.class, new CellEditor());

        insert = new JButton("Insert");
        update = new JButton("Update");
        delete = new JButton("Delete");
        table.setAutoResizeMode(JTable.AUTO_RESIZE_OFF);
        pane = new JScrollPane(table, JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED,
                JScrollPane.HORIZONTAL_SCROLLBAR_ALWAYS);
        pane.getViewport().setBackground(Color.white);

        add(pane, BorderLayout.NORTH);
        add(panel, BorderLayout.SOUTH);

        panel.setLayout(new FlowLayout());
        panel.add(insert);
        panel.add(update);
        panel.add(delete);

        update.addActionListener(new ActionListener(){

            public void actionPerformed(ActionEvent e){
                dbtable.updateDB();
            }

        });

         insert.addActionListener(new ActionListener(){

             public void actionPerformed(ActionEvent e){

                 dbtable.addRow();
                 table.setEditingRow(dbtable.getRowCount());
                 table.setRowSelectionInterval(dbtable.getRowCount()-1,
                         dbtable.getRowCount()-1);
             }
         });

        setSize(400,200);
        setVisible(true);

        addWindowListener(new WindowAdapter(){

            public void windowClosing(WindowEvent e){

                System.exit(0);
            }

        });

        if (DEBUG) {
            table.addMouseListener(new MouseAdapter() {
                public void mouseClicked(MouseEvent e) {
                    printDebugData(table);
                }
            });
        }

    }

    private void printDebugData(JTable table) {
        int numRows = table.getRowCount();
        int numCols = table.getColumnCount();
        javax.swing.table.TableModel model = table.getModel();

        System.out.println("Value of data: ");
        for (int i=0; i < numRows; i++) {
            System.out.print("    row " + i + ":");
            for (int j=0; j < numCols; j++) {
                System.out.print("  " + model.getValueAt(i, j));
            }
            System.out.println();
        }
        System.out.println("--------------------------");
    }

    public static void main(String args[]){

        TableEditor editor = new TableEditor();

    }

    public class CellRenderer extends DefaultTableCellRenderer{

    public Component getTableCellRendererComponent(JTable table, Object value,
            boolean isSelected, boolean hasFocus, int row, int col){
        super.getTableCellRendererComponent( table, value, isSelected, hasFocus, row, col );


            if(value instanceof java.sql.Date){

                String strDate = new SimpleDateFormat("yyyy-MM-dd").format((Date)value);
                this.setText(strDate);
            }

        return this;
    }
    }

    public class CellEditor extends DefaultCellEditor{

         Object myValue;

         JTextField textField;

         public CellEditor( ){

            super(new JTextField());

         }
  
  public Component getTableCellEditorComponent(JTable table, Object value,
                                                 boolean isSelected, int row,
                                                 int column)
    {

            return super.getTableCellEditorComponent(
            table, value, isSelected, row, column
            );
    }

 public Object getCellEditorValue(){

     try
        {
        if (textField.getText().trim().length() == 0)
            return null;

        SimpleDateFormat fm = new SimpleDateFormat("yyyy-MM-dd");
        java.util.Date utilDate = fm.parse(textField.getText().trim());
        java.sql.Date sqlDate = new java.sql.Date(utilDate.getTime());

        return sqlDate;
        }
        catch (ParseException e)
        {
        ExceptionEvent event = new ExceptionEvent(this,
                        "Invalid Date Format. Date must be in form yyyy-MM-dd");

                return textField.getText();
        }
 }



 public boolean stopcellEditing(){
      String s = (String)super.getCellEditorValue();
        // Here we are dealing with the case where a user
        // has deleted the string value in a cell, possibly
        // after a failed validation. Return null, so that
        // they have the option to replace the value with
        // null or use escape to restore the original.
        // For Strings, return "" for backward compatibility.
         if ("".equals(s))
        {
            myValue = null;
            return super.stopCellEditing();
        }

        try{
            SimpleDateFormat lFormat = new SimpleDateFormat("yyyy-MM-dd");
            myValue = lFormat.parse(s);
        }catch(ParseException e){
            ((JComponent)getComponent()).setBorder(new LineBorder(Color.red));
            return false;

        }
      
        return super.stopCellEditing();
 }


    }
}

[Rob Spoor]

1) why did you install the editor for java.sql.Date, and not for java.util.Date?
2) your table and table model never specify that the specific column contains dates. Either the table or the table model should implement getColumnClass to return Date.class (or java.sql.Date.class) for that column.

[Giuseppa Cefalu]

Hi Rob,

I figured out why my date cells were not editable. I am reading from a database and the date type in mysql database is java.sql.Date. The table getColumnClass(int col) method is supposed to return a Java Date, an integer, a String .....; but not a java.sql.Date Type. When an object.class is returned by the getColumnClass(int col) method the table returns a java date format for the column, and some how because the real data type is java.sql.Date the date is not editable (does not work). In order for the date cell to be editable, I need to format the Date as java Date or as a string. I prefer to format it as a string, so that way I can present the user with the desired format. Here is the code. There is no need to implement a renderer or an editor unless you want to implement special features (ie; color).

   while(rs.next()){

                newRow = new Vector();
                   for(int j = 1; j <= columns; j++){
                       switch(md.getColumnType(j)){
                           case Types.CHAR:
                           case Types.VARCHAR:
                           case Types.LONGVARCHAR:
                               String s = rs.getString(j);
                               if(rs.wasNull()){
                                   newRow.addElement(null);
                               }
                               else {
                                   newRow.addElement(s);
                               }

                       break;

                       case Types.INTEGER:
                           int n = rs.getInt(j);
                           if(rs.wasNull()){
                               newRow.addElement(null);
                           }
                           else {
                               newRow.addElement(n);
                           }

                        break;

                        case Types.FLOAT:
                        case Types.DOUBLE:
                            double d = rs.getDouble(j);
                            if(rs.wasNull()){
                                newRow.addElement(null);
                            }
                            else{
                                newRow.addElement(new Double(d));
                            }

                            break;
                       case Types.DATE:
                           java.sql.Date date = rs.getDate(j);

                           
                           if(rs.wasNull()){
                               newRow.addElement(null);
                           }
                           else {

                             SimpleDateFormat formatter = new SimpleDateFormat("yyyy-MM-dd");
                             String formatDate = formatter.format(date);
                              newRow.addElement(date);
                           }

                           break;
                    
                            //    newRow.addElement(rs.getObject(j));

                       }

                }

                allRows.addElement(newRow);

         
 public Class getColumnClass(int col){

        try{
            switch(md.getColumnType(col + 1)){
                case Types.CHAR:
                case Types.VARCHAR:
                case Types.LONGVARCHAR:
                    return String.class;

                case Types.INTEGER:

                   return Integer.class;

                case Types.FLOAT:
                case Types.DOUBLE:
                    return Double.class;

                case Types.DATE:
                    return String.class;

                default:
                    return Object.class;

            }

        }catch(SQLException e){

            e.getMessage();
            return Object.class;
        }
            // return getValueAt(0, col).getClass();
       }
 

[Haris Tasawar]

hey Giuseppa,
Man how did you inherited the ResultSet metadata in the class???.......... I did everything else but am stuck in this because i cant get the resultset to be available in this class, could you tell me how did you do it???

[Haris Tasawar]

sorry i forgot to point out the line. It is this line in which i have a problem???

switch(md.getColumnType(column + 1))

Apparently, it cant find 'md' in this???

[Rob Spoor]

I'm guessing that md is an instance of ResultSetMetaData, retrieved by calling getMetaData() on the ResultSet.

[Giuseppa Cefalu]

Is this what you need?

for( int i = 0; i < columns; i++){

                tableColNames[i] = md.getColumnName(i + 1);