Listing all in a root (39 Line working code)

[john price]

I have this set up :

import java.util.*;
import java.io.*;

public class FileTest {
String setFinal;
	FileTest() {
	String string = System.getProperty("user.dir");
	try {
	File file = new File(string);
	File[] fileList = file.listRoots();
	for (File fileUno : fileList) {
	setFinal = fileUno.toString();
	}
	System.out.println(setFinal);
	File[] yomama = new File(setFinal).listFiles();
	for (File string1 : yomama) {
	if(string1.getAbsoluteFile().isDirectory()) {
	for (File string2 : string1.listFiles()) {
		if (string2.getAbsoluteFile().isDirectory()) {
		for (File string3 : string2.listFiles()) {
		System.out.println(string3.toString());
		}
		}
		else {
		System.out.println(string2.toString() + "is not a dir");
		}
	}
	}
	else {
	System.out.println(string1.toString() + " is not a dir");
	}
	}
	}
	catch (Exception eaf) {eaf.printStackTrace();}
	}
	public static void main (String[] args) {
	new FileTest();
	}
}

It works 100%. But, as the code says, it only goes 2 deep. I need this to be going until it runs out of dir's to check. If it isn't a dir, I want it to stop at that dir and :

System.out.println(file.absolutePathName().toString() + " is not a dir"); //Yes I know the syntax isn't right, but that's not the point...Yes I was doing this before.  I just want it to basically print out all the files and dir's of the system

Anyway, I was thinking something along the lines of a while() statement. I just don't know how to implement it. If you could provide code or insight that would be great.

Thanks,
cc11rocks

This is what it prints out for my "D:\" drive (in case you were wondering) :

C:\Users\cc11rocks\Desktop>java FileTest
D:\
D:\recovery\windowsre\EN1005HA-B_WW_W7S_32H_01.05.wim
D:\recovery\windowsre\EN1005HA-B_WW_W7S_32H_01.052.wim
D:\SOURCES\boot.wimis not a dir
D:\BOOT\FONTS\CHS_BOOT.TTF
D:\BOOT\FONTS\CHT_BOOT.TTF
D:\BOOT\FONTS\JPN_BOOT.TTF
D:\BOOT\FONTS\KOR_BOOT.TTF
D:\BOOT\FONTS\WGL4_BOOT.TTF
D:\BOOT\BCDis not a dir
D:\BOOT\BOOT.SDIis not a dir
D:\BOOT\BOOTFIX.BINis not a dir
D:\BOOT\ETFSBOOT.COMis not a dir
D:\BOOT\BCD.LOGis not a dir
D:\BOOTMGR is not a dir
D:\$RECYCLE.BIN\desktop.iniis not a dir

[Madhan Sundararajan Devaki]

You may use recursive programming technique, to traverse the entire depth of directory structure.

[john price]

How about this? :

public void testTheDir(File[] file) {
	for (File file : file.listFiles()) {
	System.out.println(file.toString();
	if (file.getAbsoluteFile().isDirectory()) {
	testTheDir(file.listFiles());
	}
	}
	}

If you were wondering, yes I came up with all of this myself. No copying
Thanks,
cc11rocks

[Madhan Sundararajan Devaki]

You may need to make the following changes.

public void testTheDir(File argFiles) { // NOTE : Change of argument and its name

  for(File file : argFiles.listFiles()) {// NOTE : The use of changed argument name

    if(file.isDirectory()) {  // NOTE : The absence of call to getAbsoluteFile method

      testTheDir(file);   // NOTE : The use of file instead of array of files
    }
    System.out.println(file.getName());  // NOTE : The use of getName method
  }
}

[Rob Spoor]

And even one more change:

public void testTheDir(File argFiles)
{
    File[] files = argFiles.listFiles();
    if (files != null) // listFiles() can return null if a) argFiles is not a directory, or b) the contents could not be read
    {
        for (File file : files)
        {
            if (file.isDirectory())
            {
                testTheDir(file);
            }
            System.out.println(file.getName());
        }
    }
}

[Wouter Oet]

And even one more change (everything). Java 7:

Path start = ...
Files.walkFileTree(start, new SimpleFileVisitor<Path>() {
	@Override
	public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException
	{
		System.out.println(file);
		return FileVisitResult.CONTINUE;
	}
 
});

[john price]

Thank you guys so much! Just to clarify, you were having the program do the same thing I was, just in a different way (and with less bugs as without "!= null" returns a NullException)?
I am currently using your method. It works 100% (with a slightly modified FileTest()).

In case you are wondering, I went through my whole hard drive. The file that I saved all the information in took up 13.5 MB of space. My CPU was going crazy. I had very little memory left.
Thank you guys again,
cc11rocks