Not able to delete xml files after reading

[Raaja Gotluru]

Hi,

I am unzipping xml files from a zip file using java util and reading xml files using DOM parser through my application after reading I want to delete the files which I unzipped. But until unless I wont close my application I cant delete the files. Even I tried to delete from Windows Explorer but it is showing message like It is being used by another person or program. ........

How can I delete those files with out closing the application.

My code is:
try {

DocumentBuilderFactory domFactory = DocumentBuilderFactory.newInstance();
domFactory.setNamespaceAware(true);
DocumentBuilder builder;
try {
builder = domFactory.newDocumentBuilder();
File fileDirectory = new File(fileDir);
String files[] = fileDirectory.list();
Document doc;
doc = builder.parse(fileDir+fileName);
doc.getDocumentElement ().normalize ();
String rootNode = doc.getDocumentElement().getNodeName();
NodeList bookslist = doc.getElementsByTagName(rootNode);
String servername = (String) ((Element) bookslist.item(0)).getElementsByTagName("servername").item(0).getChildNodes().item(0).getNodeValue();
String theatername = (String) ((Element) bookslist.item(0)).getElementsByTagName("theatername").item(0).getChildNodes().item(0).getNodeValue();
} catch (Exception e) {
e.printStackTrace();
}

Please guide me.

Thanking you.

--raaja. g

[William Brogden]

I think I would investigate using the Zip library to get an InputStream and parse that Stream rather than extracting to a temp file.

Bill

[Paul Clapham]

That's because your application hasn't closed the file. (The parser should close the file but apparently it doesn't.)

So pass a FileInputStream to the parser, instead of a File, and close it yourself after you have finished parsing.

[Raaja Gotluru]

Hi,

Thanks for the reply. I created a FileInputStream and parsed and closed it after use. But still I am not able to delete.

try {
			List<String> matchedFiles = new ArrayList<String>();
			List<String> unmatchedFiles = new ArrayList<String>();
			
			builder = domFactory.newDocumentBuilder();
			File fileDirectory = new File(fileDir);
			String files[] = fileDirectory.list();
			XPath xpath = XPathFactory.newInstance().newXPath();
			for(String fileName:files){
				String xmlData="";
				[b]FileInputStream is= new FileInputStream(fileDir+fileName);[/b]				Document doc;
				doc = builder.parse(is);
				
				doc.getDocumentElement ().normalize ();
	           // System.out.println ("Root element of the doc is " + doc.getDocumentElement().getNodeName());
	            String rootNode =  doc.getDocumentElement().getNodeName();
	            NodeList bookslist = doc.getElementsByTagName(rootNode);
	            String servername = (String) ((Element) bookslist.item(0)).getElementsByTagName("servername").item(0).getChildNodes().item(0).getNodeValue();
	            xmlData+=servername.trim();
	           // System.out.println("s= "+servername.trim());
	            String theatername = (String) ((Element) bookslist.item(0)).getElementsByTagName("theatername").item(0).getChildNodes().item(0).getNodeValue();
	            xmlData+=theatername.trim();
	            builder.reset();
				
	           // System.out.println("s1= "+theatername.trim());
				
				//System.out.println("xmlData= "+xmlData);
	            File file = new File(fileDir+fileName);
					for(String s:list1){
						for(String s1:list2){
							String x[] = s.split(":");
							String xx = x[0];
							String y[] = s1.split(":");
							String yy = y[0];
							System.out.println("xx= "+xx + " yy= "+yy);
							System.out.println("before xx equals yy");
							if(xx.equals(yy)){
							          if(xx.equalsIgnoreCase(xmlData)){
								String sourceFile = "c:\\"+file.getName();
								String srcFile= sourceFile.substring(0,sourceFile.length()-4));
								String newZipfile = srcFile+".zip";
								file.renameTo(new File("c:\\", file.getName()));
								zipFolder(sourceFile, newZipfile);
								String toAddress = x[1];
								sendAttachment(newZipfile,toAddress);
								matchedFiles.add(file.getName());
							        }
							}
						}
					}
					if(!matchedFiles.contains(file.getName())){
						unmatchedFiles.add(file.getName());
					}
					[b]is.close();[/b]					
                                                                             File delfile = new File("c:\\"+fileName);
					deleteDir(delfile);
					delfile.deleteOnExit();
				}
			File dir = new File(fileDir);
			deleteDir(dir);
			filesList.add(matchedFiles);
			filesList.add(unmatchedFiles);
		}catch (ParserConfigurationException e) {
			e.printStackTrace();
		}catch (SAXException e) {
			e.printStackTrace();
		} catch (IOException e) {
			e.printStackTrace();
		}
		return filesList;
	}

[Jaikiran Pai]

Please use code blocks while posting code. You can do that by using the "Code" button in the message editor window.

File delfile = new File("c:\\"+fileName);
deleteDir(delfile); 

What does the deleteDir method look like (the name of the method doesn't sound right, since you are passing it a file and not just a directory)? Also please post the exact exception stacktrace that you receive. While posting that stacktrace, wrap it in a code block too.

[Raaja Gotluru]

Hi,

deleteDir is a common method used to delete files or directories. Which I found in some examples site.

The code is like:

public static boolean deleteDir(File dir) {
	    if (dir.isDirectory()) {
	        String[] children = dir.list();
	        for (int i=0; i<children.length; i++) {
	            boolean success = deleteDir(new File(dir, children[i]));
	            if (!success) {
	                return false;
	            }
	        }
	    }
	    return dir.delete();
	}

[Raaja Gotluru]

Ok, I got it. I didnt closed the stream after zipping the file.

Thanks.