org.springframework.batch.core.repository.JobExecutionAlreadyRunningException

[Jay Abrahm]

I have the following xml configured from the Spring Batch examples to run every 10 seconds but I get an error while starting up. I also have logs configured at InfiniteLoopReader and InfiniteLoopWriter but it never hits those classes and yes it does make entries into the batch table.
How do I reconfigure this ?

 		
	<bean id="jobRepository"
		class="org.springframework.batch.core.repository.support.JobRepositoryFactoryBean">
		<property name="isolationLevelForCreate" value="ISOLATION_DEFAULT" />
		<property name="dataSource" ref="dataSource" />
		<property name="transactionManager" ref="transactionManager" />
	</bean> 		
	
	<bean id="jobDetail" class="org.springframework.scheduling.quartz.JobDetailBean">
	    <property name="jobClass" value="com.test.batch.JobLauncherDetails" />
	    <property name="group" value="quartz-batch" />
	    <property name="jobDataAsMap">
	        <map>
	            <entry key="jobName" value="footballJob"/>
	            <entry key="jobLocator" value-ref="jobRegistry"/>
	            <entry key="jobLauncher" value-ref="jobLauncher"/>
	        </map>
	    </property>
	</bean>

	<bean id="jobRegistry" class="org.springframework.batch.core.configuration.support.MapJobRegistry" />
	
	<!-- Got from a website for No job configuration with the name [footballJob] was registered  -->
	<bean id="jobRegistryBeanPostProcessor" 
	class="org.springframework.batch.core.configuration.support.JobRegistryBeanPostProcessor">
		<property name="jobRegistry" ref="jobRegistry" />
	</bean> 
	
	
	<bean id="jobLauncher" class="org.springframework.batch.core.launch.support.SimpleJobLauncher">
	  <property name="jobRepository" ref="jobRepository" />
	  <property name="taskExecutor">
	    <bean class="org.springframework.core.task.SimpleAsyncTaskExecutor" />
	  </property>
	</bean>
		
	<bean class="org.springframework.scheduling.quartz.SchedulerFactoryBean">
	  <property name="triggers">
	    <bean id="cronTrigger" class="org.springframework.scheduling.quartz.CronTriggerBean">
	      <property name="jobDetail" ref="jobDetail" />
	      <property name="cronExpression" value="0/10 * * * * ?" />
	    </bean>
	  </property>
	</bean>
	
	<job id="footballJob" xmlns="http://www.springframework.org/schema/batch">
		<step id="playerload">
			<tasklet>
				<chunk reader="reader" writer="writer" 
	                   commit-interval="2" />
			</tasklet>
		</step>
	</job>	

	<bean id="reader" class="com.test.batch.InfiniteLoopReader" />
	<bean id="writer" class="com.test.batch.InfiniteLoopWriter" />

</beans>

com.test.batch.JobLauncherDetails executeInternal Quartz trigger firing with Spring Batch jobName=footballJob
JobLauncherDe E com.test.batch.JobLauncherDetails executeInternal Could not execute job.
org.springframework.batch.core.repository.JobExecutionAlreadyRunningException: A job execution for this job is already running: JobInstance: id=21, version=0, JobParameters=[{}], Job=[footballJob]
at org.springframework.batch.core.repository.support.SimpleJobRepository.createJobExecution(SimpleJobRepository.java:116)

[Saifuddin Merchant]

You need to pass in different parameters at start-up for the job to run.

If the job was previously launched with teh same JobParameters and completed successfully, then it is an error to restart it. An ad-hoc request needs to be distinguished from previous runs by adding a unique job parameter. In either case a new JobExecution is created and stored to monitor this execution of the JobInstance.

[Jay Abrahm]

Sam Mercs wrote:You need to pass in different parameters at start-up for the job to run.

Is there an example you could point me to or could you post a quick code snippet on what parameter needs to be passed. If it needs to be unique can I just pass the time in milliseconds ? Not sure how it can be done though ...

[Saifuddin Merchant]

You have not mentioned how you are running the job, are you trying to run is as a Junit test? are you running it from the command line? do you have it scheduled to run?

In all case, you need to pass in job parameters, you can get all the details - http://static.springsource.org/spring-batch/reference/html/configureJob.html - 4.4. Running a Job in this section of the document.

Here is the gist,

If your using the command like job runner (shell script)

dateParam=date '+%m%d%y_%H%M%S'
java CommandLineJobRunner JOB_CONFIG.xml JOB_NAME timestamp=$dateParam

If you using Junit test & JobLauncherTestUtils, from the Javadoc...

It should be noted that using any of the methods that don't contain JobParameters in their signature, will result in one being created with the current system time as a parameter. This will ensure restartability when no parameters are provided.

If you are passing in param you need to add a unique param...

[Jay Abrahm]

I am running the job using quartz. The intention is to trigger some service calls within the ear to do some plumbing tasks every hour.

I wasn't sure on how to pass the job parameters in my case but when I increased the time gap between the tasks and also removed the Thread sleep in the samples, it wasn't spitting out JobExecutionAlreadyRunningException.

And it now triggers the job properly
com.test.JobLauncherDetails executeInternal Quartz trigger firing with Spring Batch jobName=footballJob
com.test.JobLauncherDetails executeInternal Quartz trigger firing with Spring Batch jobName=footballJob
com.test.JobLauncherDetails executeInternal Quartz trigger firing with Spring Batch jobName=footballJob
......

But now I don't see any entries in the Spring batch table, it doesn't seem to hit the reader/writer classes even though it isn't throwing any exceptions.

One more question, I was able to trigger my batch using Quarts example @ Quartz example. I keep hearing that Spring Batch is the ideal way to do this but can someone explain why using Batch is a better bet than using quartz in my scenario.

[Saifuddin Merchant]

What does your datasource and transactionManager beans refer to. Could you add the configuration for those. If they are configured correctly, it should write to the database ...

[Jay Abrahm]

Here goes...

<bean id="dataSource" class="org.springframework.jndi.JndiObjectFactoryBean">
	<property name="jndiName">
	<value>jdbc/BatchTestDB</value>
	</property>
</bean>


<bean id="transactionManager" class="org.springframework.orm.hibernate3.HibernateTransactionManager">
	<property name="sessionFactory" ref="sessionFactory" />
</bean>

<bean id="sessionFactory"
	class="org.springframework.orm.hibernate3.annotation.AnnotationSessionFactoryBean">
	<property name="dataSource" ref="dataSource" />
	<property name="packagesToScan" value="com.batch.test" />
	<property name="hibernateProperties">
	</property>
</bean>