Issue with Vaanilla Struts 2/Hibernate CRUD example

[Sean Romocki]

Hello all,

I have been trying to build a struts 2/hibernate web application that is based off of this example:
http://www.vaannila.com/struts-2/struts-2-example/struts-2-crud-example-1.html

My problem is this same as this thread, but the solutions there did not work for me:
https://coderanch.com/t/528498/Struts/Struts-valuestack-error

I've been stuck on this for several days. Here are the different classes/config files/jsp of my code:

The model class: Dnis.java

package net.ivr.dnis.model;

import java.io.Serializable;
import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.Id;
import javax.persistence.Table;

@Entity
@Table(name="dnis_caller_info_table")
//public class Dnis implements Serializable{
	
	public class Dnis implements Serializable{

	
	private static final long serialVersionUID = -8767337896773261247L;

	private Long id;
    private String adjudicator;
    private String callergreet;
    private String callerlang;
    private String defaultxfer;
    private String refillxfer;
    private String statusxfer;
    private String specialxfer;
    private String menucode;
    private String greetingfile;
    private String primarygrammar;
    private String numonlygrammar;
    private String brandingname;
    private String ctibranding;
    private String drmenucode;
    private String pretransprompt;
    
    @Id
    @Column(name="DNIS_ID") //database reference
	public Long getId() {
		return id;
	}
    
    @Column(name="ADJUDICATOR")
	public String getAdjudicator() {
		return adjudicator;
	}
    
    @Column(name="CALLER_GREET")
	public String getCallergreet() {
		return callergreet;
	}
    
    @Column(name="CALLER_LANGUAGE")
	public String getCallerlang() {
		return callerlang;
	}
    
    @Column(name="DEFAULT_XFER_EXT")
	public String getDefaultxfer() {
		return defaultxfer;
	}
    
    @Column(name="REFILL_XFER_EXT")
	public String getRefillxfer() {
		return refillxfer;
	}
    
    @Column(name="STATUS_XFER_EXT")
	public String getStatusxfer() {
		return statusxfer;
	}
    
    @Column(name="SPECIAL_USE_XFER_EXT")
	public String getSpecialxfer() {
		return specialxfer;
	}
    
    @Column(name="MENU_CODE")
	public String getMenucode() {
		return menucode;
	}
    
    @Column(name="GREETING_FILE")
	public String getGreetingfile() {
		return greetingfile;
	}
    
    @Column(name="PRIMARY_GRAMMAR")
	public String getPrimarygrammar() {
		return primarygrammar;
	}
    
    @Column(name="NUM_ONLY_GRAMMAR")
	public String getNumonlygrammar() {
		return numonlygrammar;
	}
    
    @Column(name="BRANDING_NAME")
	public String getBrandingname() {
		return brandingname;
	}
    
    @Column(name="CTI_BRANDING")
	public String getCtibranding() {
		return ctibranding;
	}
    
    @Column(name="DROFFICE_MENU_CODE")
	public String getDrmenucode() {
		return drmenucode;
	}
    
    @Column(name="PRE_TRANSFER_PROMPT")
	public String getPretransprompt() {
		return pretransprompt;
	}
	public void setId(Long id) {
		this.id = id;
	}
	public void setAdjudicator(String adjudicator) {
		this.adjudicator = adjudicator;
	}
	public void setCallergreet(String callergreet) {
		this.callergreet = callergreet;
	}
	public void setCallerlang(String callerlang) {
		this.callerlang = callerlang;
	}
	public void setDefaultxfer(String defaultxfer) {
		this.defaultxfer = defaultxfer;
	}
	public void setRefillxfer(String refillxfer) {
		this.refillxfer = refillxfer;
	}
	public void setStatusxfer(String statusxfer) {
		this.statusxfer = statusxfer;
	}
	public void setSpecialxfer(String specialxfer) {
		this.specialxfer = specialxfer;
	}
	public void setMenucode(String menucode) {
		this.menucode = menucode;
	}
	public void setGreetingfile(String greetingfile) {
		this.greetingfile = greetingfile;
	}
	public void setPrimarygrammar(String primarygrammar) {
		this.primarygrammar = primarygrammar;
	}
	public void setNumonlygrammar(String numonlygrammar) {
		this.numonlygrammar = numonlygrammar;
	}
	public void setBrandingname(String brandingname) {
		this.brandingname = brandingname;
	}
	public void setCtibranding(String ctibranding) {
		this.ctibranding = ctibranding;
	}
	public void setDrmenucode(String drmenucode) {
		this.drmenucode = drmenucode;
	}
	public void setPretransprompt(String pretransprompt) {
		this.pretransprompt = pretransprompt;
	}
	
}

The Controllers: DnisDAO.java & DnisDAOImpl.java

package net.ivr.dnis.controller;

import java.util.List;

import net.ivr.dnis.model.Dnis;

public interface DnisDAO {
	public void saveOrUpdateDnis(Dnis dnis);
	public List<Dnis> listDnis();
	public Dnis listDnisById(Long id);
	public void delete(Long id);
}

package net.ivr.dnis.controller;


import java.util.List;

import org.hibernate.Transaction;
import org.hibernate.classic.Session;

import com.googlecode.s2hibernate.struts2.plugin.annotations.SessionTarget;
import com.googlecode.s2hibernate.struts2.plugin.annotations.TransactionTarget;
import net.ivr.dnis.model.Dnis;



public class DnisDAOImpl implements DnisDAO {

	@SessionTarget
	Session session;
	
	@TransactionTarget
	Transaction transaction;

	/**
	 * Used to save or update a dnis.
	 */
	@Override
	public void saveOrUpdateDnis(Dnis dnis) {
		try {
			session.saveOrUpdate(dnis);
		} catch (Exception e) {
			transaction.rollback();
			e.printStackTrace();
		}
	}

	/**
	 * Used to delete a user.
	 */
	@Override
	public void delete(Long id) {
		try {
			Dnis dnis = (Dnis) session.get(Dnis.class, id);
			session.delete(dnis);
		} catch (Exception e) {
			transaction.rollback();
			e.printStackTrace();
		} 
	}
	
	/**
	 * Used to list all the dnis numbers.
	 */
	@SuppressWarnings("unchecked")
	@Override
	public List<Dnis> listDnis() {
		List<Dnis> dnisList = null;
		try {
			dnisList = session.createQuery("from Dnis").list();
		} catch (Exception e) {
			e.printStackTrace();
		}
		return dnisList;
	}

	/**
	 * Used to list a single dnis by Id.
	 */
	@Override
	public Dnis listDnisById(Long id) {
		Dnis dnis = null;
		try {
			dnis = (Dnis) session.get(Dnis.class, id);
		} catch (Exception e) {
			e.printStackTrace();
		}
		return dnis;
	}
}

The Action class: DnisAction.java

package net.ivr.dnis.view;

import java.util.ArrayList;
import java.util.List;

import javax.servlet.http.HttpServletRequest;

import org.apache.struts2.ServletActionContext;

import net.ivr.dnis.controller.DnisDAO;
import net.ivr.dnis.controller.DnisDAOImpl;
import net.ivr.dnis.model.Dnis;

import com.opensymphony.xwork2.ActionContext;
import com.opensymphony.xwork2.ActionSupport;
import com.opensymphony.xwork2.ModelDriven;

public class DnisAction extends ActionSupport implements ModelDriven<Dnis> {

	private static final long serialVersionUID = -6659925652584240539L;

	private Dnis dnis = new Dnis();
	private List<Dnis> dnisList = new ArrayList<Dnis>();
	private DnisDAO dnisDAO = new DnisDAOImpl();
	
	@Override
	public Dnis getModel() {
		return dnis;
	}
	
	/**
	 * To save or update user.
	 * @return String
	 */
	public String saveOrUpdate()
	{	
		dnisDAO.saveOrUpdateDnis(dnis);
		return SUCCESS;
	}
	
	/**
	 * To list all users.
	 * @return String
	 */
	public String list()
	{
		dnisList = dnisDAO.listDnis();
		return SUCCESS;
	}
	
	/**
	 * To delete a user.
	 * @return String
	 */
	public String delete()
	{
		HttpServletRequest request = (HttpServletRequest) ActionContext.getContext().get(ServletActionContext.HTTP_REQUEST);
		dnisDAO.delete(Long.parseLong(request.getParameter("id")));
		return SUCCESS;
	}
	
	/**
	 * To list a single user by Id.
	 * @return String
	 */
	public String edit()
	{
		HttpServletRequest request = (HttpServletRequest) ActionContext.getContext().get(ServletActionContext.HTTP_REQUEST);
		dnis = dnisDAO.listDnisById(Long.parseLong(request.getParameter("id")));
		return SUCCESS;
	}
	
	public Dnis getDnis() {
		return dnis;
	}

	public List<Dnis> getDnisList() {
		return dnisList;
	}

	public void setDnis(Dnis dnis) {
		this.dnis = dnis;
	}

	public void setDnisList(List<Dnis> dnisList) {
		this.dnisList = dnisList;
	}


}

The struts.xml

<?xml version="1.0" encoding="UTF-8" ?> <!DOCTYPE struts PUBLIC "-//Apache Software Foundation//DTD Struts Configuration 2.0//EN" "http://struts.apache.org/dtds/struts-2.0.dtd"> <struts> <package name="default" extends="struts-default"> <action name="saveOrUpdateDnis" method="saveOrUpdate" class="net.ivr.dnis.view.DnisAction"> <result name="success" type="redirect">listDnis</result> </action> <action name="listDnis" method="list" class="net.ivr.dnis.view.DnisAction"> <result name="success">/index.jsp</result> </action> <action name="editDnis" method="edit" class="net.ivr.dnis.view.DnisAction"> <result name="success">/index.jsp</result> </action> <action name="deleteDnis" method="delete" class="net.ivr.dnis.view.DnisAction"> <result name="success" type="redirect">listDnis</result> </action> </package> </struts>

And finally the Jsp: index.jsp

<%@ page contentType="text/html; charset=UTF-8"%>
<%@taglib uri="/struts-tags" prefix="s"%>
<html>
<head>
<style type="text/css">
@import url(style.css);
</style>
<title>DNIS Manager</title>
</head>
<body>
	<h1>DNIS Manager</h1>
	<s:form action="saveOrUpdateDnis">
		<s:push value="dnis">
			<s:textfield name="id" label="DNIS Number" />
			<s:textfield name="adjudicator" label="Adjudicator" />
			<s:textfield name="callergreet" label="Caller Greet" />
			<s:textfield name="callerlang" label="Caller Language" />
			<s:textfield name="defaultxfer" label="Default Xfer Ext" />
			<s:textfield name="refillxfer" label="Refill Xfer Ext" />
			<s:textfield name="statusxfer" label="Status Xfer Ext" />
			<s:textfield name="specialxfer" label="Special Use Xfer Ext" />
			<s:textfield name="menucode" label="Menu Code" />
			<s:textfield name="greetingfile" label="Greeting File" />
			<s:textfield name="primarygrammar" label="Primary Grammar" />
			<s:textfield name="numonlygrammar" label="Num Only Grammar" />
			<s:textfield name="brandingname" label="Branding Name" />
			<s:textfield name="ctibranding" label="CTI Branding" />
			<s:textfield name="drmenucode" label="Dr. Office Menu Code" />
			<s:textfield name="pretransprompt" label="Pre Transfer Prompt" />
			<s:submit />
		</s:push>
	</s:form>


	<h2>DNIS Info</h2>
	<s:if test="dnisList.size() > 0">
		<div class="content">
			<table class="dnisTable">
				<tr class="even">
					<th>DNIS</th>
					<th>Adjudicator</th>
					<th>Caller Greet</th>
					<th>Caller Language</th>
					<th>Default Xfer Ext</th>
					<th>Refill Xfer Ext</th>
					<th>Status Xfer Ext</th>
					<th>Special Use Xfer Ext</th>
					<th>Menu Code</th>
					<th>Greeting File</th>
					<th>Primary Grammar</th>
					<th>Num Only Grammar</th>
					<th>Branding Name</th>
					<th>CTI Branding</th>
					<th>Dr. Office Menu Code</th>
					<th>Pre Transfer Prompt</th>
				</tr>
				<s:iterator value="dnisList" status="dnisStatus">
					<tr
						class="<s:if test="#dnisStatus.odd == true ">odd</s:if><s:else>even</s:else>">
						<td><s:property value="id" /></td>
						<td><s:property value="adjudicator" /></td>
						<td><s:property value="callergreet" /></td>
						<td><s:property value="callerlang" /></td>
						<td><s:property value="defaultxfer" /></td>
						<td><s:property value="refillxfer" /></td>
						<td><s:property value="statusxfer" /></td>
						<td><s:property value="specialxfer" /></td>
						<td><s:property value="menucode" /></td>
						<td><s:property value="greetingfile" /></td>
						<td><s:property value="primarygrammar" /></td>
						<td><s:property value="numonlygrammar" /></td>
						<td><s:property value="brandingname" /></td>
						<td><s:property value="ctibranding" /></td>
						<td><s:property value="drmenucode" /></td>
						<td><s:property value="pretransprompt" /></td>
						<td><s:url id="editURL" action="editDnis">
								<s:param name="id" value="%{id}"></s:param>
							</s:url> <s:a href="%{editURL}">Edit</s:a></td>
						<td><s:url id="deleteURL" action="deleteDnis">
								<s:param name="id" value="%{id}"></s:param>
							</s:url> <s:a href="%{deleteURL}">Delete</s:a></td>
					</tr>
				</s:iterator>
			</table>
		</div>
	</s:if>
</body>
</html>

I try and run the application and it gives me this stack trace:

SEVERE: Servlet.service() for servlet [jsp] in context with path [/IVRSupportv1.1] threw exception [tag 'push', field 'value': You must specify a value to push on the stack. Example: person - [unknown location]] with root cause
tag 'push', field 'value': You must specify a value to push on the stack. Example: person - [unknown location]
at org.apache.struts2.components.Component.fieldError(Component.java:230)
at org.apache.struts2.components.Component.findValue(Component.java:351)
at org.apache.struts2.components.Push.start(Push.java:128)
at org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:53)
at org.apache.jsp.index_jsp._jspx_meth_s_005fpush_005f0(index_jsp.java:183)
at org.apache.jsp.index_jsp._jspx_meth_s_005fform_005f0(index_jsp.java:152)
at org.apache.jsp.index_jsp._jspService(index_jsp.java:108)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:433)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:389)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:333)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:73)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:224)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:185)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:151)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:929)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:405)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:269)
at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515)
at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:300)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:722)

Thanks for the help!!!

[Joe Ess]

Looking at this error:

tag 'push', field 'value': You must specify a value to push on the stack. Example: person - [unknown location]

and the push tag documentation, my guess would be that a textfield tag is not a value and can't be pushed on the stack.

[Sean Romocki]

Hey Joe,

Thanks for your response. I looked again at the Vaanilla exmaple and they used a textfield as part of the value in their example. The actual value is "value = user" in their example, or in my case "value = dnis" which is the Dnis.java object and the textfield names are the different fields. But anyways, maybe if I clarify how I want this page setup it will be easier for you to help me. These have to be textfields because they have to be user inputs.

This .jsp page should have all the input text boxes for the addition of a Dnis object to the database at the top. Right below all the input fields is a submit button. Below that is the list of all the current records in the database. When I add a record the list should refresh with the new record included. If I click edit, the values of that object should be populated into the textfields. Now, when I click submit the record's info will be updated in the database and the list. I was thinking maybe there is a disconnect between the clicking the edit button and having those values populate the above textfields. But how do I make that linkage? I know this is super simple, but have pity for I'm just a humble greenhorn. Thanks for you help!