Int array to 3D array

[Karoline Lim]

Hi, I've an array of tCost=0 2 3 3 0 1 2 1 0 0 5 2 1 0 3 3 2 0 0 2 1 3 0 1 5 4 0 0 1 3 2 0 1 2 2 0, and I would like to map it into 3 dimensional matrix, tCost1[j][i][k]

                      for(i=0; i<5; i++)
							for(j=0; j<3; j++)
							for(k=0; k<3; k++)
							for (int aa = 0;aa<36;aa++)
							{
								arrTcost = tCost.split(" ");						
								tCost1[j][i][k] = Integer.parseInt(arrTcost[aa]);
									
							}
					
							for(i=0; i<5; i++) 
							{
								for(j=0; j<3; j++) 
								{
									for(k=0; k<3; k++)
									{
										System.out.print(tCost1[j][i][k] + " ");
									}
									System.out.println();
								}
								System.out.println();
							} 	

I wonder what is the correct way of doing this, because the output I got is,

0 0 0
0 0 0
0 0 0

0 0 0
0 0 0
0 0 0

0 0 0
0 0 0
0 0 0

0 0 0
0 0 0
0 0 0

0 0 0
0 0 0
0 0 0

Thanks in advance!

[Karoline Lim]

I've found out the reason already.

[Campbell Ritchie]

And how did you sort it out?

By the way: you do realise there is no such thing as a multi-dimensional array in Java™? It only supports arrays of arrays. You are dealing with an array of arrays of arrays.
And where did you get 36 from? You are printing 45 0s. You need to link the size of the “target” array to the size of the “source” array. That is why there are style recommendations (§10.3) against using numbers like 36, 3 and 5 in your code.

This sort of code cannot overrun the bounds of the array:

private final int ROWS = 3;
private final int COLUMNS = 3;
String[] tokens =
    "1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36"
        .split("\\s");
int pages = tokens.length / COLUMNS - ROWS;
int[][][] numbers = new int[pages][ROWS][COLUMNS];
int index = 0;
for (int i = 0; i < numbers.length; i++)
{
   for (int j = 0; j < numbers[i].length; j++)
   {
      for (int k = 0; k < number[i][j].length; k++)
      {
          numbers[i][j][k] = Integer.parseInt(tokens[index++]));
      } 
   }
}

Note that this suggestion will discard 8 values if your original String contains 44 tokens. You can of course add a final array of this sort to use those last 8, if you so wish:
1 2 3
4 5 6
7 8

[Karoline Lim]

Campbell Ritchie wrote:And how did you sort it out?

By the way: you do realise there is no such thing as a multi-dimensional array in Java™? It only supports arrays of arrays. You are dealing with an array of arrays of arrays.
And where did you get 36 from? You are printing 45 0s. You need to link the size of the “target” array to the size of the “source” array. That is why there are style recommendations (§10.3) against using numbers like 36, 3 and 5 in your code.

This sort of code cannot overrun the bounds of the array:

private final int ROWS = 3;
private final int COLUMNS = 3;
String[] tokens =
    "1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36"
        .split("\\s");
int pages = tokens.length / COLUMNS - ROWS;
int[][][] numbers = new int[pages][ROWS][COLUMNS];
int index = 0;
for (int i = 0; i < numbers.length; i++)
{
   for (int j = 0; j < numbers[i].length; j++)
   {
      for (int k = 0; k < number[i][j].length; k++)
      {
          numbers[i][j][k] = Integer.parseInt(tokens[index++]));
      } 
   }
}

Note that this suggestion will discard 8 values if your original String contains 44 tokens. You can of course add a final array of this sort to use those last 8, if you so wish:
1 2 3
4 5 6
7 8

I thought I did, but when I checked the arrays of arrays out, the values are wrong..

Thanks for the comments, and I did try your codes, and changed the for loop into 36 tokens (4,3,3)

final int ROWS = 3;  
							final int COLUMNS = 3;  
							String[] tokens = "1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36".split("\\s");				     
							          
							int pages = tokens.length / COLUMNS - ROWS;  
							int[][][] numbers = new int[pages][ROWS][COLUMNS];  
							int index = 0;
							for (int i1 = 0; i1 < 4; i1++)  
							{  
							   for (int j1 = 0; j1 < 3; j1++)  
							   {  
								   
							      for (int k1 = 0; k1 <3; k1++)  
							      {  
							    	  System.out.println("Token value= "+tokens[index++]);
							          //numbers[i1][j1][k1] = Integer.parseInt(tokens[index++]);  
							      }   
							   }  
							} 

and it generates the token value right (1 to 36).

But when the line 16 is unmasked, I got output like this,

Token value= 1
Token value= 3
Token value= 5
Token value= 7
Token value= 9
Token value= 11
Token value= 13
Token value= 15
Token value= 17
Token value= 19
Token value= 21
Token value= 23
Token value= 25
Token value= 27
Token value= 29
Token value= 31
Token value= 33
Token value= 35
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 36
at alsClass.main(alsClass.java:245)

why would it be this??

Thanks in advance.

[Campbell Ritchie]

There is a big mistake. It shouldn’t be tokens.length / COLUMNS - ROWS. It should be tokens.length / COLUMNS / ROWS.

Very sorry about that error

[Campbell Ritchie]

And you should not use 3 or 4 inside the for loops. It is < something.length.

[Campbell Ritchie]

And if you have two ++ operators inside the same loop, you will run out of tokens when you are half-way through the array.

[Winston Gutkowski]

Karoline Lim wrote:But when the line 16 is unmasked, I got output like this,

Tip: avoid "combination code" like
System.out.println("Token value= " + tokens[index++]);
until you're a lot more confident with the language (and maybe not even then).

Use:
System.out.println("Token value= " + tokens[index]);
index++;

Winston

[Karoline Lim]

There is a big mistake. It shouldn’t be tokens.length / COLUMNS - ROWS. It should be tokens.length / COLUMNS / ROWS.

Very sorry about that error

It's ok, just a small mistake. Thanks alot! To make sure there's no 'fuzzyness', I hard-coded the for loop values to check the outcomes.

Really thanks Campbell, I've learned alot!

Tip: avoid "combination code" like
System.out.println("Token value= " + tokens[index++]);
until you're a lot more confident with the language (and maybe not even then).

It solves the problem, thank you so much Winston! No combination code!

Thanks again everyone.

[Campbell Ritchie]

It’s not that it was combination code. It was that you have two ++ operators in the same loop.

But there are a lot of people who think you oughtn’t to use the ++/-- operators in combination.

[Campbell Ritchie]

And you’re welcome