problems creating a new larger array with one extra element

[Dustin Schreader]

I am creating a program to have information entered into it and will store that into a csv file. I figure if I set rowSize variable at the top of the class so it covers the scope of the program I should be able to call a method to increment rowSize of the array and insert the new element into the new part of the array created. The program runs smoothly if I don't try and add the code to increment the rowSize and w (lines 144 & 145) but when they're run I get index out of bounds exceptions at line 150. What I'm I doing wrong to create this growing CSV file?

import java.io.*;
import java.util.*;
import java.text.*;
import javax.swing.JOptionPane;

class ServiceMaster implements SMInterface {

    private int rowSize = 4;
    private String[] dataArray;
    private String[][] rows = new String[rowSize][6];
    private String ptName = " ", ptCode = " ", dr = " ", floor = " ", time = " ";
    private String drCode = " ", drName = " ", gen = " ", icu = " ", pcu = " ", type = " ";

    public ServiceMaster() {
    }

    //creates array for use in other methods
    public String[][] createArray() {

        try {
            BufferedReader serviceMasterCSV =
                    new BufferedReader(new FileReader("/Users/doodthatscool/NetBeansProjects/ServiceMasterDriver/src/ServiceMaster.csv"));

            String dataRow = serviceMasterCSV.readLine();
            int x = 0;


            while (dataRow != null) {


                dataArray = dataRow.split(",");

                for (int r = 0; r < dataArray.length; r++) {

                    rows[x][r] = dataArray[r];
                }
                x++;

                dataRow = serviceMasterCSV.readLine(); // Read next line of data.
//System.out.println(Arrays.deepToString(rows));
            }
            serviceMasterCSV.close();

        } catch (IOException e) {
            e.printStackTrace();
        }

        return rows; //returns array

    }

    public void addPt(String ptCode, String ptName, String dr, String floor, String time) {
        rows = createArray();

        BufferedReader in = new BufferedReader(new InputStreamReader(System.in));

        for (int w = 0; w < rowSize; w++) {
            if (rows[w][0].equals(ptCode) && rows[w][5].equals("pt")) {
                JOptionPane.showMessageDialog(null, "Physician already exists",
                        "error", JOptionPane.ERROR_MESSAGE);
            } else if (rows[w][0] == null) {
                rows[w][0] = ptCode;
                rows[w][1] = ptName;
                rows[w][2] = dr;
                rows[w][3] = floor;
                time = getDate();
                rows[w][4] = time;
                rows[w][5] = "pt";
                System.out.println("Patient " + rows[w][0] + " added.");
                w = rowSize;
            } else if (rows[w][0].equals(ptCode)) {
                rows[w][0] = ptCode;
                rows[w][1] = ptName;
                rows[w][2] = dr;
                rows[w][3] = floor;
                time = getDate();
                rows[w][4] = time;
                rows[w][5] = "pt";
                System.out.println("Patient " + rows[w][0] + " added.");
                w = rowSize;
            } else if (rowSize == (w + 1)) {
                //add extra row to array
                //rowSize++;
                //w = w + 1;
                //rows = createArray();
                rows[w][0] = ptCode;
                rows[w][1] = ptName;
                rows[w][2] = dr;
                rows[w][3] = floor;
                time = getDate();
                rows[w][4] = time;
                rows[w][5] = "pt";
                System.out.println("pt " + rows[w][0] + " added.");
                //w = rowSize;

            }
        }

        try {
            BufferedWriter writer = new BufferedWriter(new FileWriter("/Users/doodthatscool/NetBeansProjects/ServiceMasterDriver/src/ServiceMaster.CSV"));

            for (int n = 0; n < rowSize; n++) {
                writer.write(rows[n][0]);
                writer.write(",");
                writer.write(rows[n][1]);
                writer.write(",");
                writer.write(rows[n][2]);
                writer.write(",");
                writer.write(rows[n][3]);
                writer.write(",");
                writer.write(rows[n][4]);
                writer.write(",");
                writer.write(rows[n][5]);
                writer.write("\n");
            }
            writer.close();

        } catch (IOException e) {
            e.printStackTrace();
        }
    }

    public void addDr(String drCode, String drName, String gen, String icu, String pcu) {

        rows = createArray();

        BufferedReader in = new BufferedReader(new InputStreamReader(System.in));

        for (int w = 0; w < rowSize; w++) {
            if (rows[w][0].equals(drCode) && rows[w][5].equals("dr")) {
                JOptionPane.showMessageDialog(null, "Physician already exists",
                        "error", JOptionPane.ERROR_MESSAGE);
            } else if (rows[w][0] == null) {
                rows[w][0] = drCode;
                rows[w][1] = drName;
                rows[w][2] = gen;
                rows[w][3] = icu;
                rows[w][4] = pcu;
                rows[w][5] = "dr";
                System.out.println("Doctor " + rows[w][1] + " added.");
                w = rowSize;
            } else if (rowSize == (w + 1)) {
                //add extra row to array
                rowSize++;              //<=========== When I add this...
                w = w + 1;             // <=========== and this I get error in line 150
                //System.out.println(rowSize);
                //System.out.println(w);
                //rows = createArray();

                rows[w][0] = drCode; //<==============Here is where I get the index out of bounds
                rows[w][1] = drName;
                rows[w][2] = gen;
                rows[w][3] = icu;
                rows[w][4] = pcu;
                rows[w][5] = "dr";
                System.out.println("Doctor " + rows[w][1] + " added to row " + w);
                //w = rowSize;

            }
        }

        try {
            BufferedWriter writer = new BufferedWriter(new FileWriter("/Users/doodthatscool/NetBeansProjects/ServiceMasterDriver/src/ServiceMaster.CSV"));

            for (int n = 0; n < rowSize; n++) {
                writer.write(rows[n][0]);
                writer.write(",");
                writer.write(rows[n][1]);
                writer.write(",");
                writer.write(rows[n][2]);
                writer.write(",");
                writer.write(rows[n][3]);
                writer.write(",");
                writer.write(rows[n][4]);
                writer.write(",");
                writer.write(rows[n][5]);
                writer.write("\n");
            }
            writer.close();

        } catch (IOException e) {
            e.printStackTrace();
        }

    }

    public boolean search(String code, String name) {
        rows = createArray();
        boolean stat = false;
        String output = "";
        System.out.println(Arrays.deepToString(rows));

        for (int w = 0; w < rowSize; w++) {
            if (rows[w][0].equals(code) || rows[w][1].equals(name)) {
                System.out.println("Found");

                if (rows[w][5].equals("pt")) {
                    ptCode = rows[w][0];
                    ptName = rows[w][1];
                    dr = rows[w][2];
                    floor = rows[w][3];
                    time = rows[w][4];
                    type = rows[w][5];
                } else {
                    drCode = rows[w][0];
                    drName = rows[w][1];
                    gen = rows[w][2];
                    icu = rows[w][3];
                    pcu = rows[w][4];
                    type = rows[w][5];
                }

                stat = true;
                w = rowSize;
            } else {
                System.out.println("not found");
                stat = false;
            }
        }
        return stat;
    }

    public void addRoom(String ptCode, String floor) {

        if (search(ptCode, " ")) {
            if (type.equals("dr")) {
                JOptionPane.showMessageDialog(null, "You must enter a Physician in as a pt first",
                        "error", JOptionPane.ERROR_MESSAGE);
            } else {
                addPt(ptName, ptCode, dr, floor, getDate());
            }
        }
    }

    public String displayInfo() {
        String info = "";

        if (type.equals("pt")) {
            info = ptCode + " " + ptName + " " + dr + " " + floor + " " + time + "\n";
        } else {
            info = drCode + " " + drName + " " + gen + " " + icu + " " + pcu + " M.D." + "\n";
        }
        return info;
    }

    //finds when pt info was last accesed
    public String getDate() {
        DateFormat dateFormat = new SimpleDateFormat("yyyy/MM/dd HH:mm:ss");
        Date date = new Date();
        return dateFormat.format(date);
    }
}

With the Error/output

[[56, shanan, fr1c, fr2c, jo2b, dr], [57, schreader, fr2c, fr1c, fr7b, dr],
 [99, houser, schreader, fr2c, 2011/12/04 03:32:27, pt],
 [66, justin, schreader, fr7b, 2011/12/04 04:41:40, pt]]
not found
not found
not found
not found
Exception in thread "AWT-EventQueue-0" java.lang.ArrayIndexOutOfBoundsException: 4
        at ServiceMaster.addDr(ServiceMaster.java:150)
        at NewJFrame1.pAddButtonActionPerformed(NewJFrame1.java:259)
        at NewJFrame1.access$100(NewJFrame1.java:19)
        at NewJFrame1$2.actionPerformed(NewJFrame1.java:93)
        at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028)
        at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351)
        at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
        at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
        at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
        at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272)
        at java.awt.Component.processMouseEvent(Component.java:6373)
        at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
        at java.awt.Component.processEvent(Component.java:6138)
        at java.awt.Container.processEvent(Container.java:2085)
        at java.awt.Component.dispatchEventImpl(Component.java:4735)
        at java.awt.Container.dispatchEventImpl(Container.java:2143)
        at java.awt.Component.dispatchEvent(Component.java:4565)
        at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4621)
        at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4282)
        at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4212)
        at java.awt.Container.dispatchEventImpl(Container.java:2129)
        at java.awt.Window.dispatchEventImpl(Window.java:2478)
        at java.awt.Component.dispatchEvent(Component.java:4565)
        at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:679)
        at java.awt.EventQueue.access$000(EventQueue.java:85)
        at java.awt.EventQueue$1.run(EventQueue.java:638)
        at java.awt.EventQueue$1.run(EventQueue.java:636)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
        at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
        at java.awt.EventQueue$2.run(EventQueue.java:652)
        at java.awt.EventQueue$2.run(EventQueue.java:650)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
        at java.awt.EventQueue.dispatchEvent(EventQueue.java:649)
        at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
        at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
        at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
        at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
BUILD SUCCESSFUL (total time: 30 seconds)

Sorry for the length.

[Matthew Brown]

Arrays in Java have a fixed size. If you want to resize an array you need to create a new one the size you want, and copy all the elements across to it.

Or, a much better solution: use a more appropriate data structure. You want a List (either an ArrayList or a LinkedList), which is designed to allow the size to change.

[Dustin Schreader]

That seems like it's going to be a lot of rework. Is there a way that I can convert the arrays I already have to an arraylist?

[Dustin Schreader]

I bet I could do something like this.

for (int w = 0; w < rowSize; w++) {
            if (rows[w][0].equals(ptCode) && rows[w][5].equals("pt")) {
                JOptionPane.showMessageDialog(null, "Physician already exists",
                        "error", JOptionPane.ERROR_MESSAGE);
            } else if (rows[w][0] == null) {
                rows[w][0] = ptCode;
                rows[w][1] = ptName;
                rows[w][2] = dr;
                rows[w][3] = floor;
                time = getDate();
                rows[w][4] = time;
                rows[w][5] = "pt";
                System.out.println("Patient " + rows[w][0] + " added.");
                w = rowSize;
            } else if (rows[w][0].equals(ptCode)) {
                rows[w][0] = ptCode;
                rows[w][1] = ptName;
                rows[w][2] = dr;
                rows[w][3] = floor;
                time = getDate();
                rows[w][4] = time;
                rows[w][5] = "pt";
                System.out.println("Patient " + rows[w][0] + " added.");
                w = rowSize;
            } else if (rowSize == (w + 1)) {
                //add extra row to array
                //rowSize++;
                //w = w + 1;
                //rows = createArray();
                rows[w][0] = ptCode;
                rows[w][1] = ptName;
                rows[w][2] = dr;
                rows[w][3] = floor;
                time = getDate();
                rows[w][4] = time;
                rows[w][5] = "pt";
                System.out.println("pt " + rows[w][0] + " added.");
                //w = rowSize;
                
                entries.add(rows[w][0] + "," + rows[w][1] + "," + rows[w][2] + "," + rows[w][3] + "," + rows[w][4] + "," + rows[w][5] + "," + );

            }

[Winston Gutkowski]

Dustin Schreader wrote:I bet I could do something like this.

Possibly, but it seems like an awful lot of work to cover up for the fact that you've made a bad decision to start with.
My advice: follow Matthew's.

Is there a way that I can convert the arrays I already have to an arraylist?

Yes, but it doesn't alter the fact that you're better off with an ArrayList to begin with.
Sometimes the school of hard knocks is the best way to learn, and the lesson here is:
unless you know how many items you're going to be creating, always use a collection rather than an array.

Winston

[Dustin Schreader]

Alright I'll get working on it. Thank you much for the help!

[Matthew Brown]

If you're re-working it ...

...there's another big improvement you could make. You're currently using an array of arrays to represent your rows. What I'd suggest is to create a class representing a single row (called Patient - or whatever makes sense in your application). Give that class fields according to what the columns mean. Then you can use an ArrayList<Patient> to hold them in. It will make your code far more readable and maintainable, which is always a good idea.

[Dustin Schreader]

It sounds pretty cool but I'm pretty overworked and tired would you be able to provide me with a small sample so I can understand a little better. I guess I don't understand creating a whole new class for just patient information formatting.

[Winston Gutkowski]

Dustin Schreader wrote:I guess I don't understand creating a whole new class for just patient information formatting.

Well, something like

public class Patient {
   private int code;
   private String name;
   private String doctor;
   private int floor;
   private Calendar admitted;

   public Patient(int code, String name, String doctor, int floor, Date admitted) {
      this.code = code;
      this.name = name;
      this.doctor = doctor;
      this.floor = floor;
      this.admitted = new GregorianCalendar(admitted);
   }

   public String toString() {
      //code to return Patient info as a string
   }
}

might be a start.

However, I suspect that the real problem you're having is that you're spending too much time coding, and not enough thinking about the problem.

You're also not doing yourself any favours with your cryptic codes and field names. What is "pt" for example?

Winston

[Dustin Schreader]

So since I had a an array of arrays previously and now I want to use an arrayList it seems easy enough to add more and more elements to an ArrayList but how do I sort through the list like i did when I was using a for loop to sort through the array of arrays? It seems like I'd be sorting through each entire string of combined variables created by my patient class when, let's say I just wanted to compare against the code of the pt to do a search on them not the code, name, physician, floor, and time.

    ArrayList<Patient> patient = new ArrayList<Patient>();
    
    for (int w = 0; w< patient.length; w++) {
            if (/*?*/.equals(ptCode) && /*?*/.equals("patient")) {
                JOptionPane.showMessageDialog(null, "Patient already exists",
                    "error", JOptionPane.ERROR_MESSAGE);
        } 

    else if (/*?*/.equals(ptCode)) {
            //replace the current patient room info (from ptCode) according to the new room info provided if pt already exists
                
            } 
        else {
                patient.add(new Patient(ptCode, ptName, dr, floor, getTime(), "pt"));

    }
}
try{
    
        BufferedWriter out = new BufferedWriter("database.CSV");

for( int i=0; i<patient.size(); i++){
out.write(patient.get(i));
}
//Close the output stream
    out.close();
    }catch (Exception e){//Catch exception if any
      System.out.println("Error: " + e.getMessage());
    }

[Winston Gutkowski]

Dustin Schreader wrote:It seems like I'd be sorting through each entire string of combined variables created by my patient class when, let's say I just wanted to compare against the code of the pt to do a search on them not the code, name, physician, floor, and time.

I suspect you need to go through the tutorials for object order and sorting. You should also look at java.lang.Comparable and java.util.Comparator.

Winston

[Dustin Schreader]

Thank you I will take a look.

[Campbell Ritchie]

Beware of long lines in code tags; I have split some of your output into multiple lines so they will fit onto the width of my screen.