java.lang.IllegalStateException:- when generating excel report

[vardhan reddy]

Hi All,
I am generating excel reports using jasper. I am able to generate excel report and providing save options user, it is workign fine but in logs I'm getting error.
error trace

org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/seoul_tax_forecasting].[jsp] - Servlet.service() for servlet jsp threw exception
java.lang.IllegalStateException: getOutputStream() has already been called for this response
	at org.apache.catalina.connector.Response.getWriter(Response.java:607)
	at org.apache.catalina.connector.ResponseFacade.getWriter(ResponseFacade.java:196)
	at javax.servlet.ServletResponseWrapper.getWriter(ServletResponseWrapper.java:111)
	at org.apache.jasper.runtime.JspWriterImpl.initOut(JspWriterImpl.java:125)
	at org.apache.jasper.runtime.JspWriterImpl.flushBuffer(JspWriterImpl.java:118)
	at org.apache.jasper.runtime.PageContextImpl.release(PageContextImpl.java:171)
	at org.apache.jasper.runtime.JspFactoryImpl.internalReleasePageContext(JspFactoryImpl.java:116)
	at org.apache.jasper.runtime.JspFactoryImpl.releasePageContext(JspFactoryImpl.java:76)
	at org.apache.jsp.jsp.layout.tiles_005flayout_jsp._jspService(tiles_005flayout_jsp.java:161)
	at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
	at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:331)
	at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:329)
	at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
	at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:679)
	at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:584)
	at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:497)
	at org.apache.tiles.servlet.context.ServletTilesRequestContext.include(ServletTilesRequestContext.java:260)
	at org.apache.tiles.servlet.context.ServletTilesRequestContext.dispatch(ServletTilesRequestContext.java:220)
	at org.apache.tiles.renderer.impl.TemplateAttributeRenderer.write(TemplateAttributeRenderer.java:44)
	at org.apache.tiles.renderer.impl.AbstractBaseAttributeRenderer.render(AbstractBaseAttributeRenderer.java:106)
	at org.apache.tiles.impl.BasicTilesContainer.render(BasicTilesContainer.java:670)
	at org.apache.tiles.impl.BasicTilesContainer.render(BasicTilesContainer.java:690)
	at org.apache.tiles.impl.BasicTilesContainer.render(BasicTilesContainer.java:644)
	at org.apache.tiles.impl.BasicTilesContainer.render(BasicTilesContainer.java:627)
	at org.apache.tiles.impl.BasicTilesContainer.render(BasicTilesContainer.java:321)
	at org.springframework.web.servlet.view.tiles2.TilesView.renderMergedOutputModel(TilesView.java:124)
	at org.springframework.web.servlet.view.AbstractView.render(AbstractView.java:250)
	at org.springframework.web.servlet.DispatcherServlet.render(DispatcherServlet.java:1047)
	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:817)
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:719)
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:644)
	at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:560)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:709)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:172)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:174)
	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:873)
	at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665)
	at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528)
	at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81)
	at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:689)
	at java.lang.Thread.run(Thread.java:595)

and here is my code

ArrayList<JasperPrint> list = new  ArrayList<JasperPrint>();
		OutputStream outputStream = null;
		FileInputStream fileInputStream = null;
		String[] sheetsList = new String[20];
		try {
			JasperPrint jasperPrint = reportsService.generateReport(AppConstants.F1_BONDS);
			JasperPrint jasperPrint2 = reportsService.generateReport(AppConstants.F2_BONDS);
			
			JRXlsExporter exporter = new JRXlsExporter(); 
			//exporter.setParameter(JRExporterParameter.JASPER_PRINT, jasperPrint); 
			//exporter.setParameter(JRExporterParameter.OUTPUT_FILE_NAME, "P:/STF-Project/testing/F1_BONDS.xls"); 
		
			list.add(jasperPrint); 
			list.add(jasperPrint2);
			
			//exporter.setParameter(JRExporterParameter.OUTPUT_FILE_NAME, "P:/STF-Project/testing/F1_BONDS.xls");
			
			exporter.setParameter(JRXlsExporterParameter.IS_REMOVE_EMPTY_SPACE_BETWEEN_ROWS, Boolean.TRUE);
			exporter.setParameter(JRXlsExporterParameter.IS_ONE_PAGE_PER_SHEET, Boolean.FALSE);
			exporter.setParameter(JRXlsExporterParameter.JASPER_PRINT_LIST, list);
			exporter.setParameter(JRExporterParameter.OUTPUT_FILE_NAME,"P:/STF-Project/testing/Report.xls");
			//Pass the sheet names
			exporter.setParameter(JRXlsExporterParameter.SHEET_NAMES, new String[]{"F1_BONDS", "F2_BONDS"});
			exporter.setParameter(JRXlsExporterParameter.IGNORE_PAGE_MARGINS, Boolean.TRUE);
			exporter.setParameter(JRXlsExporterParameter.OFFSET_X, 0);
			exporter.setParameter(JRXlsExporterParameter.IS_IGNORE_CELL_BORDER, Boolean.FALSE);
			exporter.setParameter(JRXlsExporterParameter.IS_DETECT_CELL_TYPE, true);
			exporter.setParameter(JRXlsExporterParameter.IS_WHITE_PAGE_BACKGROUND, false);
			exporter.exportReport();
			
			File file =new File("P:/STF-Project/testing/Report.xls");
			fileInputStream = new FileInputStream(file);
			outputStream = response.getOutputStream();

			// SET THE MIME TYPE.
			//response.setContentType("application/vnd.ms-excel");
			// set content disposition to attachment in with file name.
			// case the open/save dialog needs to appear.
			response.setHeader("Content-Disposition", "attachment;filename="+"Report.xls");
			
			byte[] buffer = new byte[262144];
			int n = 0;
			while ((n = fileInputStream.read(buffer)) != -1) {
				outputStream.write(buffer,0, n);
			}
			
		} catch (Exception e) {
			LOGGER.error("Unexpected error occurred trying to generate report details.",e);
			//sendErrorJSONResponse(response, e);
			System.out.println(e);
		} finally {
			LOGGER.error("Closing fileInputStream and ServletOutputStream in finally block.");
			try {
				outputStream.flush();
				fileInputStream.close();
				outputStream.close();

			} catch (IOException e) {
				// TODO Auto-generated catch block
				e.printStackTrace();
			}

Thanks.

[Rob Spoor]

You shouldn't use JSP files for binary data. The problem is that any line break outside tags will be included in the response. This includes line breaks between import tags, etc. When such a line break is included in the response, this is written to the writer (as returned by getWriter()). As a result you can't call getOutputStream() anymore.

There are three solutions:
1) Simply don't include any line breaks. Let each tag follow the next tag. For instance, not

<%@ page import="java.io.*" %>
<%@ page import="java.util.*" %>
<%@ page import="java.util.regex.*" %>

but instead

<%@ page import="java.io.*" %><%@
    page import="java.util.*" %><%@
    page import="java.util.regex.*" %>

Each and any line break should be removed.

2) Not sure about this one, but perhaps you can turn on output buffering and clear the buffer before you start writing the Excel report.

3) Definitely the preferred way - use a Servlet instead of a JSP file. With servlets you have full control over what's printed out. If you don't call getWriter() explicitly then it's not called at all.

[vardhan reddy]

Hi Rob,
Thanks for your reply,
i have only one button in my jsp and my logic is in controller class only.

[Rob Spoor]

Are you saying you want both HTML (the button) and the Excel data in one single JSP file? Because that's definitely not going to work.

[vardhan reddy]

No Rob,
i have button info in jsp and control login in java class.
I have checked my controller logic, but still i'm getting same error
and my jsp code is:

<div id="importform" class="div_form_horizontal">
	<form:form name="report_criteria" method="POST" action='<%=request.getContextPath()+"/reportFiles.do?method=generateReports"%>' commandName="criteriaBundle">
		<table class="tbl_form_horizontal">
			<tr>
				<td>
					<form:errors path="*"/>
				</td>
			</tr>
			<tr>
			<td class="col_label">
				<spring:message code="generic.app.report" />
			</td>
			</tr>
			<tr>
			<td class="opbuttons"><br/><br/>
				<div class="buttonwrapper">
					<a class="squarebutton" href="#" onclick="document.report_criteria.submit()"><span>Generate Reports</span></a>
				</div>
			</td>
			</tr>
		</table>
	</form:form>
</div>

[Nitin Surana]

As long as I remember, you can't setHeaders after a call to getOutputStream().

outputStream = response.getOutputStream();  
  
            // SET THE MIME TYPE.  
            //response.setContentType("application/vnd.ms-excel");  
            // set content disposition to attachment in with file name.  
            // case the open/save dialog needs to appear.  
            response.setHeader("Content-Disposition", "attachment;filename="+"Report.xls");  

[Kumaravadivel Subramani]

Nitin is right, after the response has been committed (actually it's being started to send the response to browser/some other resource) you can't add or change anything in response object.

[vardhan reddy]

Nitin/Subramani,

I have updated setHeader before calling getOutputStream and still I am getting same error.

[Rob Spoor]

I still say you should use a servlet instead of a JSP for generating the Excel file.