Class Practice Help

[Bryce Heath]

Hi guys
I'm working on making a very simple game to practice what I have learned so far programming. So far what I have done is made an enemy class, a hero class, a class I called gameplay that I figured would contain methods for fights ect, and the main. So I think my classes for hero/enemy are fine, and went on to make a very basic fight method using loops, and have relized in order to do this I beleive I will have to create the hero and the enemy object in this method (please correct me if im wrong) the problem with that is how can the main method access these objects? I dont think i want to create new ones in the main because they would not produce the right life ect from a battle that happened. Hope this made sense ill post some code be kind lol.

GamePlay class

package game;

public class GamePlay 
{
	
	private Orc orc1;
	private Hero champ;
	private int eDmg, eLife, hDmg, hLife;
	
	
	public GamePlay()
	{
		
	}
	public void fight()
	{
		
		
		eLife = orc1.getLife();
		hLife = champ.getLife();
		int hLifeAdj, eLifeAdj; 
		
		
		
		while(eLife > 0)
		{
			
			if(hLife > 0)
			{	
				eDmg = orc1.attack();
				hDmg = champ.attack();
				
				hLifeAdj = hLife - eDmg;
				
				champ.setLife(hLifeAdj);
				
				
				eLifeAdj = eLife - hDmg;
				
				orc1.setLife(eLifeAdj);
				
				eLife = orc1.getLife();
				hLife = champ.getLife();
				
				
			}
			
			
		}
		
		
	}
	
	public String toString()
	{
		String outcome = "----------";
		
		
		
		return outcome;
	}
}

Orc class

package game;

public class Orc 
{
	private final String NAME = "Orc";
	private final int  MAX_DAMAGE;
	private int life = 10;
	//Constructor
	public Orc ()
	{
		MAX_DAMAGE = 3;
		
	}

	public int attack()
	{
		int attackDmg;
		
		attackDmg = (int) (Math.random() * MAX_DAMAGE) + 1;
		
		return attackDmg;
	}
	
	
	
	public String getNAME() 
	{
		return NAME;
	}

	public int getLife() 
	{
		return life;
	}
	
	public void setLife(int life)
	{
		this.life = life;
	}

	public String toString()
	{
		String status;
		
		status = NAME + "\t" + life + "\t" + MAX_DAMAGE;
		
		return status;
	}
}

Hero class

package game;

public class Hero 

{
	private String name;
	public int life, damage;
	
	//constructs the main hero player
	public Hero (String name)
	{
		this.life = 100;
		this.damage = 2;
		
		this.name = name;
		
	}
	
	public int attack()
	{
		int attackDmg;
		
		attackDmg = (int) (Math.random() * damage) + 1;
		
		return attackDmg;
	}
	
	
	public String getName() 
	{
		return name;
	}



	public void setName(String name) 
	{
		this.name = name;
	}



	public int getLife() 
	{
		return life;
	}



	public void setLife(int life) 
	{
		this.life = life;
	}



	public int getDamage() 
	{
		return damage;
	}



	public void setDamage(int damage) 
	{
		this.damage = damage;
	}



	public String toString()
	{
		String status;
		
		status = name + "\t" + life + "\t" + damage;
		
		return status;
	}
}

[Stephan van Hulst]

Hi Bryce. You have to think on a bit more of a conceptual level. Don't dig into the programming straight away. First write down on paper what you want everything to look like. Ask yourself questions.

There are orcs. There are heroes. Who knows about their whereabouts? Are there levels? Are there areas, such as caves or forests? Is it just one game in which we only care about one orc and one hero? How are orcs and heroes different?

Now, let's say that all that we want to do when we run the program, is perform one fight exactly, and print who wins. Now you know enough to have a good idea of what you want your application to look like:

final class Game {

  Game(Figher one, Fighter two) {}
  
  Fighter fight() {}
  
}

final class Fighter {

  Fighter(String name, int health, int strength) {}
  
  String name() {}
  
  int health() {}

  int strength() {}
  
  @Override
  public String toString() {}
  
}

You see? With the method declarations alone we already have a really good idea of how we want everything to work. We construct a new game using two fighters. A fighter has a name and some stats. The main method then simply looks like this:

public static void main(String... args) {
  Fighter hero = new Fighter("Hero", 100, 2);
  Fighter orc = new Fighter("Orc", 20, 3);
  
  Game game = new Game(hero, orc);
  System.out.println(game.fight());
}

The Game class knows enough about the two fighters to be able to determine the outcome of a random battle. All it needs are the methods provided by the Fighter class. If you want, you can also add methods setHealth()/setStrength() to the Fighter class to edit these properties after a battle is done.

I hope this answers some of your questions.