Getting exceptions in my code... and I have no idea why.

[Sean Gnau]

Hey everyone, I'm having a really hard time with this code I have... the object is to determine the average number of characters and average number of letters in a word and average number of words in a sentence (which in this case is just each line in a text document). At the same time, it should be printing all the lines of input in the text document.

I'm fairly certain this code should be working, but clearly it doesn't, giving me exceptions instead of the result I would like to see.

import java.io.FileInputStream;
import java.io.IOException;
import static java.lang.System.out;
import java.util.Scanner;

public class Main
{

    public static void main(String[] args) throws IOException
    {
        Scanner reader = null;
        reader = new Scanner(new FileInputStream("txtdoc.txt"));
        int sentenceCount = 0;
        int wordCount     = 0;
        int totalCharacters = 0;

        out.println("Document Contents" + "\n");
        while ( reader.hasNext() ) {
            String line = null;
            line = reader.nextLine();
            out.println(line);
            sentenceCount++;
            Scanner lineScanner = null;
            lineScanner = new Scanner(line);


            while ( lineScanner.hasNext() ) {
                String word = null;
                word = reader.next();
                int wordCharacters = word.length(); 
                wordCount++;
                totalCharacters = totalCharacters + wordCharacters; 
            }        
        }
        double averageSentenceLength = 0;
        averageSentenceLength = (double) wordCount / sentenceCount;
        double averageWordLength = 0;
        averageWordLength = (double) totalCharacters / wordCount;
        out.println("\nThe average number of words in a sentence is:");
        out.format("\t%3.2f\n", averageSentenceLength);
        out.println("\nThe average number of characters in a word is:");
        out.format("\t%3.2f\n\n", averageWordLength);
    }
}

Thanks in advance

EDIT: txtdoc.txt can be anything.. but for an example, I am using

Tell me what thy lordly name
is on the nights plutonian shore
Quoth the raven nevermore

[Saurabh Pillai]

Can you show us the exception stacktrace?

[Ashish L. Sharma]

Hi, I tried running it (I am just a newbie.... ) that's the error it gave...

Document Contents

Tell me what thy lordly name
Exception in thread "main" java.util.NoSuchElementException
at java.util.Scanner.throwFor(Unknown Source)
at java.util.Scanner.next(Unknown Source)
at Main.main(Main.java:30)

Using Eclipse (indigo)

[Joanne Neal]

Take a look at the variable names on line 27 and line 29

[Ashish L. Sharma]

yes, that is the place of error. Do not know why ???

[Sean Gnau]

Ashish L. Sharma wrote:Hi, I tried running it (I am just a newbie.... ) that's the error it gave...

Document Contents

Tell me what thy lordly name
Exception in thread "main" java.util.NoSuchElementException
at java.util.Scanner.throwFor(Unknown Source)
at java.util.Scanner.next(Unknown Source)
at Main.main(Main.java:30)

Using Eclipse (indigo)

^ Exactly the same result I am getting. Sorry for forgetting to post that earlier.

[Sean Gnau]

Joanne Neal wrote:Take a look at the variable names on line 27 and line 29

Wow... such a simple mistake... That literally solved everything

@Ashish - It's because I used my original scanner name (reader) which considered the entire document, instead of the scanner name for the single line that I parsed out of the original document.

Thanks a million!

[Ashish L. Sharma]

Please post the rectified code.... do we have to put hasNext at ---> word = reader.(here)next();??

[Sean Gnau]

Ashish L. Sharma wrote:Please post the rectified code....

import java.io.FileInputStream;
import java.io.IOException;
import static java.lang.System.out;
import java.util.Scanner;

public class Main
{

    public static void main(String[] args) throws IOException
    {
        Scanner reader = null;
        reader = new Scanner(new FileInputStream("txtdoc.txt"));
        int sentenceCount = 0;
        int wordCount     = 0;
        int totalCharacters = 0;

        out.println("Document Contents" + "\n");
        while ( reader.hasNext() ) {
            String line = null;
            line = reader.nextLine();
            out.println(line);
            sentenceCount++;
            Scanner lineScanner = null;
            lineScanner = new Scanner(line);


            while ( lineScanner.hasNext() ) {
                String word = null;
                word = lineScanner.next();
                int wordCharacters = word.length(); 
                wordCount++;
                totalCharacters = totalCharacters + wordCharacters; 
            }        
        }
        double averageSentenceLength = 0;
        averageSentenceLength = (double) wordCount / sentenceCount;
        double averageWordLength = 0;
        averageWordLength = (double) totalCharacters / wordCount;
        out.println("\nThe average number of words in a sentence is:");
        out.format("\t%3.2f\n", averageSentenceLength);
        out.println("\nThe average number of characters in a word is:");
        out.format("\t%3.2f\n\n", averageWordLength);
    }
}

[Joanne Neal]

Sean Gnau wrote:Thanks a million!

You're welcome.
Also note that there is no need to initialise your line variable to null on line 19.

String line;

will work just as well and you could even do

String line = reader.nextLine();

Same applies to line 28/29