Updatings in database with JSP,EJB,XSL,XSP on JBoss

[Andrew Baba]

Hi
Im pretty new with JSP. I tried to solve the problem through search option but couldn't find it.
I am currently doing internship and I am having problem with updating data in the database.They work here on jboss. They use JSP, EJB, XSP,XSL and mysql.
I have a table and I would like to send updated data back to database by clicking SUBMIT button. Picture below


I should code this by finding correct id ,using LocalizationDataModel,storing model in the session. Should find correct ID in the database and next update it.
Here how it looks that in mysql



I have already got method savaLocalizationData in EJB, which I am sure is correct

 public LocalizationDataModel saveLocalizationData(LocalizationDataModel theModel)
			 {
			 
			 try
			 {
			 
				 Long id=theModel.getId();
			 	 
			 	 
				LocalizationDataLocal localizationDataLocal=localizationDataLocalHome.findByPrimaryKey(id);
			 	 localizationDataLocal.setModel(theModel);
			 	 
			 }
				catch (FinderException e) 
				{
					e.printStackTrace();
				}
			 	return theModel;
			 }

They told me I should work right now with controller.jsp
Here is code and advices in comments for a save localization data, I also added a sample how they display pages in listLoclizationData page

else if(command.equals("listLocalizationData"))
	{
	    System.out.println("Listing Localization Data........");
		
		
		
		String s_ModuleId = request.getParameter("moduleId");
        Long moduleId=new Long(s_ModuleId);
		
		System.out.println("It goes through s_ModuleId string" + s_ModuleId);
		
		session.setAttribute("moduleId",moduleId);
		
		String s_LanguageId = request.getParameter("languageId");
        Long languageId=new Long(s_LanguageId);
		
		System.out.println("Its getting the language id string" + s_LanguageId);

		//Store the required language number
		session.setAttribute("languageId",languageId);

		Vector theLocalizationData=myServer.getAllLocalizationData(moduleId);	//this line
	    //store in session
	    session.setAttribute("theLocalizationData", theLocalizationData); //this line
		
		%>
		<jsp:forward page="localization-data.html"/>
		<%
		
		
		
	}
	else if(command.equals("saveLocalizationData"))
	{
	    

	    System.out.println("Saving Localization Data........");

		 
		 //connect to the localization server and request Id => tu wywala blad
		 LocalizationDataModel theSaveData=myServer.saveLocalizationData("theModel");
		 //store in session
		 session.setAttribute("theSaveData",theSaveData);

		 
		 //update with new translation- quesiton is how to update this
		 //session.setAttribute("localization-data-edit",localization-data-edit);
		 //send to server- next question to answer
		 
		 %>
		<jsp:forward page="localization-data-edit.html"/>
		<%
	}

Here is a XSP page for that
<?xml version="1.0" encoding="UTF-8"?> <xsp:page language="java" xmlns:xsp="http://apache.org/xsp" xmlns:xsp-session="http://apache.org/xsp/session/2.0"> <xsp:structure> <xsp:include>java.util.*</xsp:include> <xsp:include>com.sykon.localization.model.LocalizationModuleModel</xsp:include> <xsp:include>com.sykon.localization.model.LocalizationDataModel</xsp:include> </xsp:structure> <page> <localization-data-list> <xsp:logic> System.out.println("Localization Data ... getting from session.."); //--get vector from the section-- Vector theLanguageDataModels=(Vector)session.getAttribute("theLocalizationData"); //--checking how many elements have I got in the languages vector-- Enumeration myEnum=theLanguageDataModels.elements(); //each one is LocalizationDataModel ... fields ID, ModuleId, LangEngligh, langPolish ..... while(myEnum.hasMoreElements()) { LocalizationDataModel localizationDataModel=(LocalizationDataModel)myEnum.nextElement(); //see which language was required... Long languageId=(Long)(session.getAttribute("languageId")); </xsp:logic> <localization-data> <xsp:element name="id"><xsp:expr>localizationDataModel.getId()</xsp:expr></xsp:element> <xsp:element name="item-name"><xsp:expr>localizationDataModel.getItemName()</xsp:expr></xsp:element> <xsp:logic> String theTranslation=""; if(languageId.intValue()==1)theTranslation=localizationDataModel.getLangEnglish(); else if(languageId.intValue()==2)theTranslation=localizationDataModel.getLangPolish(); else if(languageId.intValue()==3)theTranslation=localizationDataModel.getLangGerman(); else if(languageId.intValue()==4)theTranslation=localizationDataModel.getLangPortugese(); </xsp:logic> <xsp:element name="translation"><xsp:expr>theTranslation</xsp:expr></xsp:element> </localization-data> <xsp:logic> } </xsp:logic> </localization-data-list> </page> </xsp:page>

Here stylesheet in XSL form
<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform"> <xsl:include href="../../stylesheets/main.xsl"/> <xsl:template match="/"> <xsl:call-template name="main"/> </xsl:template> <xsl:template name="body"> <br/>Localization Data Editor:<br/> <form action="controller.jsp"> <input type='hidden' name='command' value="saveLocalizationData"/> <table border="1"> <tr> <td>ID</td> <td> <input type="text" size="30" name="id"> <xsl:attribute name="value"><xsl:value-of select="//localization-data/id"/></xsl:attribute> </input> </td> </tr> <tr> <td>Item Name</td> <td>Stock_Takes</td> </tr> <tr> <td>English</td> <td>Stock Takes</td> </tr> <tr> <td>Translation</td> <td> <input type="text" size="30" name="translation"> <xsl:attribute name="value"><xsl:value-of select="//localization-data/translation"/></xsl:attribute> </input> </td> </tr> </table> <input type="submit" value='go'/> </form> </xsl:template> </xsl:stylesheet>



CAN ANYBODY HELP ME WITH THAT ? I am not sure how should start with that in controller.jsp. Any help very appreciate

[Wendy L Gibbons]

did you write the jsp? or are you maintaining somebody else's code?

as there is far to much actual java code in there, that should all be somewhere else.
all your jsp should od is get data from the user, and display data to the user (and pretty pictures). It should be really really dumb.

now I have got that off my chest, i will actually read the code.

[Wendy L Gibbons]

Andrew Baba wrote:




Here is code and advices in comments for a save localization data, I also added a sample how they display pages in listLoclizationData page

else if(command.equals("listLocalizationData"))
	{
	    System.out.println("Listing Localization Data........");
		
		
		
		String s_ModuleId = request.getParameter("moduleId");
        Long moduleId=new Long(s_ModuleId);
		
		System.out.println("It goes through s_ModuleId string" + s_ModuleId);
		
		session.setAttribute("moduleId",moduleId);
		
		String s_LanguageId = request.getParameter("languageId");
        Long languageId=new Long(s_LanguageId);
		
		System.out.println("Its getting the language id string" + s_LanguageId);

		//Store the required language number
		session.setAttribute("languageId",languageId);

		Vector theLocalizationData=myServer.getAllLocalizationData(moduleId);	//this line
	    //store in session
	    session.setAttribute("theLocalizationData", theLocalizationData); //this line
		
		%>
		<jsp:forward page="localization-data.html"/>
		<%
		
		
		
	}
	else if(command.equals("saveLocalizationData"))
	{
	    

	    System.out.println("Saving Localization Data........");

		 
		 //connect to the localization server and request Id => tu wywala blad
		 LocalizationDataModel theSaveData=myServer.saveLocalizationData("theModel");
		 //store in session
		 session.setAttribute("theSaveData",theSaveData);

		 
		 //update with new translation- quesiton is how to update this
		 //session.setAttribute("localization-data-edit",localization-data-edit);
		 //send to server- next question to answer
		 
		 %>
		<jsp:forward page="localization-data-edit.html"/>
		<%
	}

is this the actual jsp page you want help with?

[Andrew Baba]

Code is mine. I created all of that on my internship. I have already made some changes and saveLocalizationData page is being already updated. Code from controller.jsp is not complete. There are more pages which I havent showed here.
I coded this

else if(command.equals("saveLocalizationData"))
	{
	    

	    System.out.println("Saving Localization Data........");

        
        String s_Id = request.getParameter("id");
        Long myIdToUpdate=new Long(s_Id);
        String s_Thetranslation = request.getParameter("theTranslation");

        System.out.println("ID from request:"+myIdToUpdate);
        System.out.println("Translation from request:"+s_Thetranslation);

		//Get the LocalizationDataModel from the session, upoate it and send to server
		Vector allLocalizationData=(Vector)session.getAttribute("theLocalizationData");

		//OK - we have all the LocalizationDataModels-  need to loop through them
		//and find the one with ID=xxx

		Enumeration enum_AllLocalizationData=allLocalizationData.elements();
		while(enum_AllLocalizationData.hasMoreElements())
		{
              LocalizationDataModel modelToCheck=(LocalizationDataModel)enum_AllLocalizationData.nextElement();
              Long modelToCheckId=modelToCheck.getId();
              if(modelToCheckId.equals(myIdToUpdate))
              {
                  System.out.println("Found LocalizationDataModel for ID "+myIdToUpdate+" updating....");

				
                  modelToCheck.setLangPolish(s_Thetranslation);
                  LocalizationDataModel updatedModel=myServer.saveLocalizationData(modelToCheck);
              }
             
	    }
	    

Right now the question I have is how to attach saved changes to the correct language in the database. When I display website lets say for a different language it still only making changes for Polish. How do you think ? Im thinking about if statement

[john wutka]

'If' Sounds fine to me.

[Wendy L Gibbons]

do you know about forms, and submitting in HTML? As that is what you should be learning and writing.
Then the java should be in the servlet that gets called when the form submits, and the servlet then sets the next page.

I do not know how that fits in with all the framwork code you have to work around.

I would recommend getting a good book, the head first jsp book is good
http://shop.oreilly.com/product/9780596516680.do

[Andrew Baba]

Wendy Gibbons wrote:do you know about forms, and submitting in HTML? As that is what you should be learning and writing.
Then the java should be in the servlet that gets called when the form submits, and the servlet then sets the next page.

I do not know how that fits in with all the framwork code you have to work around.

I would recommend getting a good book, the head first jsp book is good
http://shop.oreilly.com/product/9780596516680.do

I know basics in forms. I use forms through xsl stylesheet if I need it. Thanks for a book recommendation. I have just ordered from amazon. I was lucky I started this internship. I sold myself well on interview. I know that technologies are too deep for me. Right now I have to learn it anyway- it is motivates me. I have only finished introduction to Java so far (college) and started internship with EJB related technologies BOOM ! That's way I created this topic to ask advanced users about help. In the future I will help someone else. This is how it works, isn't ?

Back to the topic. I have created if statement. But If statement is not effiecient because I don't want add each time extra language to the controller.jsp Can somebody show me how to create loop instead?

Enumeration enum_AllLocalizationData=allLocalizationData.elements();
		while(enum_AllLocalizationData.hasMoreElements())
		{	  


              LocalizationDataModel modelToCheck=(LocalizationDataModel)enum_AllLocalizationData.nextElement();
              Long modelToCheckId=modelToCheck.getId();
              
              if(modelToCheckId.equals(myIdToUpdate) && languageId.intValue()==1) //my if statement starts here
              {
                  System.out.println("Found LocalizationDataModel for ID "+myIdToUpdate+" updating....");
				  modelToCheck.setLangEnglish(s_Thetranslation);
                  LocalizationDataModel updatedModel=myServer.saveLocalizationData(modelToCheck);
              }
              else if(modelToCheckId.equals(myIdToUpdate) && languageId.intValue()==2)
              {
                  System.out.println("Found LocalizationDataModel for ID "+myIdToUpdate+" updating....");
				  modelToCheck.setLangPolish(s_Thetranslation);
                  LocalizationDataModel updatedModel=myServer.saveLocalizationData(modelToCheck);
              }
              else if(modelToCheckId.equals(myIdToUpdate) && languageId.intValue()==3)
              {
                  System.out.println("Found LocalizationDataModel for ID "+myIdToUpdate+" updating....");
				  modelToCheck.setLangGerman(s_Thetranslation);
                  LocalizationDataModel updatedModel=myServer.saveLocalizationData(modelToCheck);
              }
              else if(modelToCheckId.equals(myIdToUpdate) && languageId.intValue()==4)
              {
                  System.out.println("Found LocalizationDataModel for ID "+myIdToUpdate+" updating....");
				  modelToCheck.setLangPortugese(s_Thetranslation);
                  LocalizationDataModel updatedModel=myServer.saveLocalizationData(modelToCheck);
              }
               else if(modelToCheckId.equals(myIdToUpdate) && languageId.intValue()==5)
              {
                  System.out.println("Found LocalizationDataModel for ID "+myIdToUpdate+" updating....");
				  modelToCheck.setLangSpanish(s_Thetranslation);
                  LocalizationDataModel updatedModel=myServer.saveLocalizationData(modelToCheck);
              }
               else if(modelToCheckId.equals(myIdToUpdate) && languageId.intValue()==6)
              {
                  System.out.println("Found LocalizationDataModel for ID "+myIdToUpdate+" updating....");
				  modelToCheck.setLangFrench(s_Thetranslation);
                  LocalizationDataModel updatedModel=myServer.saveLocalizationData(modelToCheck);
              }
               else if(modelToCheckId.equals(myIdToUpdate) && languageId.intValue()==7-)
              {
                  System.out.println("Found LocalizationDataModel for ID "+myIdToUpdate+" updating....");
				  modelToCheck.setLangDanish(s_Thetranslation);
                  LocalizationDataModel updatedModel=myServer.saveLocalizationData(modelToCheck);
              }


             
	    }

[Wendy L Gibbons]

Have a look at enums (not enumerations)

here is a good page:
http://docs.oracle.com/javase/1.5.0/docs/guide/language/enums.html

I would make a method in ModelToCheck that took a language and s_TheTranslation, then this code could be inside model to check.

then inside model to check it could use the enum.

here is some psuedo code, because how to get the correct enum from the id is a bit of a learnt trick (it will not compile)

enum language{

    ENGLISH(1), POLISH(2);

    public language(int magicNumberIdentifyingLanguage){
        this.id = magicNumber;
    }

    public language getLanguageFromId(int id)
    {
       language list = language.getEnums;
       for(language item: list)
       {
          if(item.id == id)
                return item;
        }
     }
     // other stuff to actually do processing on the language
}

[Andrew Moko]

Wendy Gibbons wrote:Have a look at enums (not enumerations)

here is a good page:
http://docs.oracle.com/javase/1.5.0/docs/guide/language/enums.html

I would make a method in ModelToCheck that took a language and s_TheTranslation, then this code could be inside model to check.

then inside model to check it could use the enum.

here is some psuedo code, because how to get the correct enum from the id is a bit of a learnt trick (it will not compile)

enum language{

    ENGLISH(1), POLISH(2);

    public language(int magicNumberIdentifyingLanguage){
        this.id = magicNumber;
    }

    public language getLanguageFromId(int id)
    {
       language list = language.getEnums;
       for(language item: list)
       {
          if(item.id == id)
                return item;
        }
     }
     // other stuff to actually do processing on the language
}

Who uses enums, Wendy ;)

Proper use of generics brings out well-laid out, short understandable code and abstracts complexity. I'd create a generic method on modelToCheck that takes a language type. Inside the method check the language and call the appropriate method/ functions.

[Wendy L Gibbons]

I do, you can either have 20 small classes, or 1 enum each with it's own method

can you show me how you would do it with generics?

[Andrew Moko]

Wendy Gibbons wrote:I do, you can either have 20 small classes, or 1 enum each with it's own method

can you show me how you would do it with generics?

Sure. Here's my two centavos..

public class LocalizationDataModel{
 private String language;
 public <T> void setLang(T language){
  this.language = (String) language;
 }
}

This method allows languages to be set dynamically without necessarily modifying the LocalizationDataModel class.

[Wendy L Gibbons]

Andrew Moko wrote:

Wendy Gibbons wrote:I do, you can either have 20 small classes, or 1 enum each with it's own method

can you show me how you would do it with generics?

Sure. Here's my two centavos..

public class LocalizationDataModel{
 private String language;
 public <T> void setLang(T language){
  this.language = (String) language;
 }
}

This method allows languages to be set dynamically without necessarily modifying the LocalizationDataModel class.

you haven't shown how you get the language class from the ID that is supplied, how you get rid of that big case statement?

[Andrew Moko]

Wendy Gibbons wrote:

Andrew Moko wrote:

Wendy Gibbons wrote:I do, you can either have 20 small classes, or 1 enum each with it's own method

can you show me how you would do it with generics?

Sure. Here's my two centavos..

public class LocalizationDataModel{
 private String language;
 public <T> void setLang(T language){
  this.language = (String) language;
 }
}

This method allows languages to be set dynamically without necessarily modifying the LocalizationDataModel class.

you haven't shown how you get the language class from the ID that is supplied, how you get rid of that big case statement?

public class LocalizationDataModel{
     private Integer languageId;  
     private String language;  
     private final static HashMap<Integer, String> mapLang = new HashMap<Integer, String>(){
      {
        put(1, "english");
        put(2, "polish");
        // etc 
      }
    };

    public <T> void setLang(T language){  
    // Language validations are implemented here... E.g
      if(languageId == mapLang.get((String)language){
       this.language = (String) language;  
     }  
   }
    public void setLanguageId(){
      // retrieve and set id from database/ flat file etc etc..
     // e.g languageId = 1; 
    } 
    public Integer getLanguageId(){
     return this.languageId;
   }
  }

I'm i missing out something??

[Wendy L Gibbons]

sorry a DOH moment, hashmaps DOH.

[Andrew Moko]

Wendy Gibbons wrote:sorry a DOH moment, hashmaps DOH.

LOL

*off for my coffee break TGIF*