how to write ftp code in android

[Suzzane Pinto]

hello friends,

i am developing an andriod application to transfer some images to the server,i am able to select images but really not aware of transfering it to the ftp server
can someone please help.???please

[Tim Moores]

Instead of reinventing the wheel, you should be able to use the Apache Commons Net library.

[Suzzane Pinto]

i have used common.net library but dont know why images are not uploaded to the server.code has no errors.
please do the needfull,attached is my code
using andriod version 2.1

the ftp code is

package com.andriod.myapp;

import java.io.File;
import java.io.FileInputStream;

import org.apache.commons.net.ftp.FTP;
import org.apache.commons.net.ftp.FTPClient;
import org.apache.commons.net.ftp.FTPReply;

public class StringSplit {
	public static String varrs;
  
public void doit() {
    String str =AndroidCustomGalleryActivity.selectImages;
    String [] temp = null;
    temp = str.split(",");
    dump(temp);
}
 
public void dump(String []s) {
    for (int i = 0 ; i < s.length ; i++) {
    	varrs=s[i];
    	
    	try
    	{
    	String ftpHost = "XXXXXX";
    	String ftpUserName = "XXXXXX"; 
    	String ftpPassword = "XXXXXX";
    	String ftpRemoteDirectory = "";
    	
    	String fileToTransmit =varrs;
    	FTPClient ftp = new FTPClient();
    	int reply;
    	
    	ftp.connect(ftpHost);
    	reply = ftp.getReplyCode();
    	
    	if(!FTPReply.isPositiveCompletion(reply)) 
    	{
    	try 
    	{
    	    ftp.disconnect();
    	} 
    	catch (Exception e) 
    	{
    	//out.println("Unable to disconnect from FTP server " + "after server refused connection. "+e.toString());
    	} 
    	throw new Exception ("FTP server refused connection.");
    	}
    	
    	if (!ftp.login(ftpUserName, ftpPassword)) 
    	{
    	    throw new Exception ("Unable to login to FTP server " + "using username "+ftpUserName+" " + "and password "+ftpPassword);
    	}
    	
    	ftp.setFileType(FTP.BINARY_FILE_TYPE);
    	
    	if (ftpRemoteDirectory != null && ftpRemoteDirectory.trim().length() > 0) 
    	{
    	    
    	//out.println("Changing to FTP remote dir: " + ftpRemoteDirectory);
    	ftp.makeDirectory(ftpRemoteDirectory);

    	ftp.changeWorkingDirectory(ftpRemoteDirectory);
    	reply = ftp.getReplyCode();
    	if(!FTPReply.isPositiveCompletion(reply)) 
        {
            throw new Exception ("Unable to change working 5 " + "to:"+ftpRemoteDirectory);
        }
    }
    	File f = new File(fileToTransmit);
    	//out.println("Storing file as remote filename: " + f.getName());
    	boolean retValue = ftp.storeFile(f.getName(), new FileInputStream(f));
    	
    	if (!retValue) 
    	{
    	    throw new Exception ("Storing of remote file failed. ftp.storeFile()" + " returned false.");
    	}
    	}
    	catch(Exception ex){}
    }
}

}

[Ulf Dittmer]

You need to be careful about posting login information; I have removed those from your post.

You need to set the file type to binary for images and other non-text files. If that doesn't fix the problem, tell us what, exactly, "images are not uploaded to the server." means.

[Suzzane Pinto]

thankyou for the last post
I have done exactly what you said in the above code at line 56. still the images are not uploaded to the server.
what i want to do is,uploaded multiple images to my ftp server.
the code shows no errors and also it is running fine with netbeans for simple application of transfering image to server but not in andriod.
what would be the problem iam not getting