problem in movement logic

[Punit Jain]

Sorry if i am posting this in wrong thread.

import java.awt.Color;
import java.awt.Graphics;
import java.awt.Image;
import java.awt.image.ImageObserver;

import javax.swing.JLabel;

class Cfish{
   int x = 0;	
   int y = 0;	
   int dx = 2;
   int dy = 1;
   Image fishImg;
   int direction =1;
  public Cfish() {}
  public Cfish(int x, int y, Image img) 
  {
  fishImg = img;
  this.x = x;
  this.y = y;
  }
   public void movementFish(Cpoint sp)
   {	 
	if(x+dx>sp.getWidth())
   	{
      x = sp.getWidth();
      dx = -dx;
      direction *= -1; 
    }
    else if(x+dx<0)
    {
      x = 0;
      dx = -dx;
      direction *= -1;
    }
    else{
    x+=  dx;
    System.out.println("\nX is: "+x);
    }
    if(y+dy>sp.getHeight())
    {
      y = sp.getHeight();
      dy = -dy;
    }
    else if(y+dy<0)
    {
      y = 0;
      dy = -dy;  
    }
    else{
    y+= dy;
    }
    y+= dy;
  }
  public void DisplayFish(Graphics g)
  {
	  if(direction==1)
		  g.drawImage (fishImg,x,y,null);
	  else  
	   	  g.drawImage (fishImg,x, 0, 0, y, 0, 0, x, y,null); 
  }
}

code is working, but there is some problem in my movementFish function, i tried allot but don't know where the problem is.
the problem is:
my x and y positions are 90 and 50,
sp.getHeight is 280 and sp.getWidth is 480.

when my image reached to 480 it reversed but now after reversing when it comes back(moving) to it's 0(zero)th position my y direction not changing while it's moving, it's moving continually at the top of frame, i mean to say, while coming back to 0th after reaching to 480, it only moving from left to right not top to bottom also (i mean y is not working only x is working).??

[Michael Dunn]

probably best to keep it all in the one thread, saves duplication of responses

https://coderanch.com/t/568233/GUI/java/reverse-image

[Punit Jain]

sorry for that...

[Michael Dunn]

No need to be sorry, posting a new topic
for a new problem is the right way to go.

A topic with 0 replies will get more attention
than a topic with 20+ replies.

The problem was resurrecting the old topic
at the same time, making this new topic redundant.

All you needed to do, in this new topic,
was to include a link to the old topic and
there would have been a natural flow.

[Punit Jain]

okay...
Thanks for the suggestions..