please somebody take me over this code segment

[caleb momanyi]

public synchronized void addItem(Product product){
boolean newItem = true;
for(shoppingCartItem scItem:items){
if(scItem.getProduct().getId()==product.getId;
newItem = false;
shoppingCart.incrementQuantity();

i dont get the part if for() loop please what is the meaning of that expression?

[S.R Paul]

It is the "Enhanced for loop".
It makes the looping easier for the collections and Arrays.

Here how it works;

for(shoppingCartItem scItem:items)...

ShoppingCartItem is a user defined class.
scItem is the reference of the object, which will be assigned while looping (the object will be retrieve from the collection "item")
items is the reference of the object, which is a Collection and type of ShoppingCartItem (mostly)

You can read the segment like this,
"for each object (ShoppingCartItem type)in the collection item, retrieve it and assign it to the scItem reference and do some work inside the loop body"

I hope it helps.

[Winston Gutkowski]

caleb momanyi wrote:i dont get the part if for() loop please what is the meaning of that expression?

Neither do I, because the code, as you've supplied it, is wrong (it won't even compile).

Please have a look at it again, and read the UseCodeTags page thoroughly before you re-submit.

Winston

[caleb momanyi]

thank you paul it helped a lot.
@Winstone that's not the whole of the code. I left out the rest of it because i was intrested with the explanation for this part only. But it works.

[gurpeet singh]

caleb momanyi wrote:thank you paul it helped a lot.
@Winstone that's not the whole of the code. I left out the rest of it because i was intrested with the explanation for this part only. But it works.

Don't want to offend you but Winston is right. the code snippet you wrote above is wrong. it won't compile. see for yourself in the if syntax. secondly you should follow forum rules and if somebody tell you to put code tags it is for your own good , so that your question can be answered quickly and clearly. code which is not properly formatted won't attract ranchers to answer it. so please in future, pay attention to these things.

[S.R Paul]

thank you paul it helped a lot.

That's fine, but next time more clear code.
Anyway, Welcome to the Ranch.

[caleb momanyi]

you were right my friend, there's something wrong with the code in that whenever I add a new cart to a session and try to add a new product I still end up without a product in the cart.
following the flow of code in the debugger I realized that a new product variable is seen just befor the for loop but not added to cart. I don't know where the problem is

package affablebean;

import entity.Product;
import java.util.ArrayList;
import java.util.List;

/**
 *
 * @author qualebs
 */
public class ShoppingCart {
    List<ShoppingCartItem> items;
    int numberOfItems;
    Double total;
    public ShoppingCart(){
        items = new ArrayList<ShoppingCartItem>();
        numberOfItems = 0;
        total = 0.0;
    }
    public synchronized void addItem(Product product){
        boolean newItem = true;
      
        for(ShoppingCartItem scItem:items){
            if(scItem.getProduct().getId()==product.getId()){
                newItem = false;
                scItem.incrementQuantity();
            }
            else if(newItem){
                scItem = new ShoppingCartItem(product);
                items.add(scItem);
            }
        }        
    }
    public synchronized void update(Product product, String quantity){
        Short qty = -1;
        qty = Short.parseShort(quantity);
        if(qty>=0){
            ShoppingCartItem item = null;
            for(ShoppingCartItem scItem:items){
                if(scItem.getProduct().getId()==product.getId()){
                    if(qty!=0){
                        scItem.setQuantity(qty);
                    }
                    else if(qty==0){
                        item = scItem;
                        break;
                    }
                }
            }
            if(item!=null){
                items.remove(item);
            }
        }
    }
    public synchronized List<ShoppingCartItem> getItems(){
        return items;
    }
    public synchronized int getNumberOfItems(){
        numberOfItems = 0;
        for(ShoppingCartItem scItem:items){
            numberOfItems += scItem.getQuantity();
        }
        return numberOfItems;
    }
    public synchronized double getSubTotal(){
        double amount = 0;
        for(ShoppingCartItem scItem:items){
            Product product = (Product)scItem.getProduct();
            amount += (scItem.getQuantity()*product.getPrice().doubleValue());
        }
        return amount;
    }
    public synchronized double calculateTotal(String surcharge){
        double amount = 0;
        double s = Double.parseDouble(surcharge);
        amount = this.getSubTotal();
        amount += s;
        return total;
    }
    public synchronized double getTotal(){
            return total;
    }
    public synchronized void clear(){
        items.clear();
        numberOfItems = 0;
        total = 0.0;
    }
    
}

[caleb momanyi]

thank you very much, I was beginning to feel bad that I was annoying the community. so why the code not working?

[Steve Luke]

You should read the web app's logs, or if you haven't started using logging yet, read the System.out and / or System.err output files. You have a runtime error that occurs in the loop which only happens when there is a new item and prevents the loop from completing. The error will throw a runtime exception and, assuming you don't catch it yourself, would be caught and logged by your application server.

I won't tell you what the exception is, because learning to find and use your logs is key to making functional code for a web application.

And if all else fails, write a simple local test which does not use a web application but instead just makes a cart and adds some items to it to see what happens (that is the best part about using POJOs in web applications, you can test them without the web server).

[caleb momanyi]

thank you all for the quick replis. I finally figured it out. in the this method

public synchronized void addItem(Product product){
        boolean newItem = true;
      
        for(ShoppingCartItem scItem:items){
            if(scItem.getProduct().getId()==product.getId()){
                newItem = false;
                scItem.incrementQuantity();
            }
/*
           else if(newItem){
                scItem = new ShoppingCartItem(product);
                items.add(scItem);
            }
*/
        }        
    }
  

the commented part should be outside the for loop. I took it out and got the cart working.
thanks to all who replied