Problems with input validation

[Michael Payte]

Okay, so for this program I'm trying to make, user input is required for several integer values. I've made it so that if the user enters a value other than an integer, the program will output that the user input must be an integer, and prompt for input again. The problem is, though, the user input here is then applied to the next thing that requires input, completely skipping what the user had given improper input in the first place. For example, if the user inputted a String when prompted for hours worked on Monday, and they enter "8" when prompted again after the error message appears, that 8 will not be applied to hours worked on Monday, but rather the next thing the program asks for input for: hours worked on Tuesday. The program just assigns a zero to hours worked on Monday. I would really appreciate help in fixing this problem. Thanks!

My program(the problem area is 125-199. Anything that appears as >< is just supposed to be <. I'm not sure why it shows up like that when I paste the code into the forums):

import java.util.*;
import java.util.Scanner;

public class program1 {
    String name;
    int age;
    int hourlyPayment;
    int hoursMonday;
	 int hoursTuesday;
	 int hoursWednesday;
	 int hoursThursday;
	 int hoursFriday;
	 Scanner input = new Scanner(System.in);

    void setName(String name)
    {
        this.name = name;
    }
   
    String getName()
    {
        return name;
    }
   
    void setAge( int a)
    {
        age =a;
    }
   
    int getAge()
    {
        return age;
    }
   
    void setHourlyPayment( int hp){
        hourlyPayment = hp;
    }
	 
	 int getHourlyPayment( ){
        return hourlyPayment;
    }
   
    void setHoursMonday( int hm ){
        hoursMonday = hm;
    }
   
    int getHoursMonday( ){
        return hoursMonday;
    }
   
	 void setHoursTuesday( int ht ){
        hoursTuesday = ht;
    }
   
    int getHoursTuesday( ){
        return hoursTuesday;
    }
	 
	  void setHoursWednesday( int hw ){
        hoursWednesday = hw;
    }
   
    int getHoursWednesday( ){
        return hoursWednesday;
    }
	 
	  void setHoursThursday( int hth ){
        hoursThursday = hth;
    }
   
    int getHoursThursday( ){
        return hoursThursday;
    }
	 
	  void setHoursFriday( int hf ){
        hoursFriday = hf;
    }
   
    int getHoursFriday( ){
        return hoursFriday;
    }
   
   
    /*void showEmployeeInfo()
    {
        System.out.println("Name : "+name);
        System.out.println("Age  : "+age);
        System.out.println("Hourly Payment : "+hourlyPayment);
        System.out.println("Hours Monday : "+hoursMonday);
		  System.out.println("Hours Tuesday : "+hoursTuesday); 
		  System.out.println("Hours Wednesday : "+hoursWednesday); 
		  System.out.println("Hours Thurday : "+hoursThursday); 
		  System.out.println("Hours Friday : "+hoursFriday);   
        System.out.println();
    }*/
   
    public static void main( String[] args)
	 {
	 
	 	Scanner input = new Scanner(System.in);
	
		 
        program1[] employeesList = new program1[3];
        employeesList[0] = new program1();
        employeesList[1] = new program1();
        employeesList[2] = new program1();
		  String answer;
		  char repeat;
       
	do
	{	
	  for(int i = 0; i<3; i++)
	  {  
		   System.out.println("Name of person " + (i+1) + "?");
        employeesList[i].setName(input.nextLine());
		  
		  
		/*  do {
        System.out.println("Please enter a positive number!");
        while (!sc.hasNextInt()) {
            System.out.println("That's not a number!");
            sc.next(); // this is important!
        }*/
		  
		   System.out.println("Age?");
			try{
        employeesList[i].setAge(input.nextInt());}
		  catch(InputMismatchException e){
		  while (!input.hasNextInt()) {
		  System.out.println("Input must be an integer.");
		  //employeesList[i].setAge(input.nextInt());
		  input.next();
		  }}

		   System.out.println("Payment per hour?");
			try{
        employeesList[i].setHourlyPayment(input.nextInt());
		  }
		  catch (InputMismatchException e)
		  {while (!input.hasNextInt()){
		  System.out.println("Input must be an integer.");
		  //employeesList[i].setHourlyPayment(input.nextInt());
		  input.next();
		  }}
		  
		   System.out.println("Hours worked Monday?");
			try{
		  employeesList[i].setHoursMonday(input.nextInt());
		  }
		  catch (InputMismatchException e)
		  {while (!input.hasNextInt()){
		  System.out.println("Input must be an integer.");
		  //employeesList[i].setHoursMonday(input.nextInt());
		  input.next();
		  }}
		  
		   System.out.println("Hours worked Tuesday?");
			try{
		  employeesList[i].setHoursTuesday(input.nextInt());
		  }
		  catch (InputMismatchException e)
		  {while (!input.hasNextInt()){
		  System.out.println("Input must be an integer.");
		  //employeesList[i].setHoursTuesday(input.nextInt());
		  input.next();
		  }}
		  
		   System.out.println("Hours worked Wednesday?");
			try{
		  employeesList[i].setHoursWednesday(input.nextInt());
		  }
		  catch (InputMismatchException e)
		  {while (!input.hasNextInt()){
		  System.out.println("Input must be an integer.");
		 // employeesList[i].setHoursWednesday(input.nextInt());
		  input.next();
		  }}
		  
		   System.out.println("Hours worked Thursday?");
			try{
		  employeesList[i].setHoursThursday(input.nextInt());
		  }
		  catch (InputMismatchException e)
		  {while (!input.hasNextInt()){
		  System.out.println("Input must be an integer.");
		  //employeesList[i].setHoursThursday(input.nextInt());
		  input.next();
		  }}
		  
		   System.out.println("Hours worked Friday?");
			try{
		  employeesList[i].setHoursFriday(input.nextInt());
		  }
		  catch (InputMismatchException e)
		  {while (!input.hasNextInt()){
		  System.out.println("Input must be an integer.");
		 // employeesList[i].setHoursFriday(input.nextInt());
		 input.next();
		  }}
		  input.nextLine();
       }
         /*System.out.println("Name of second person?");
        employeesList[1].setName(input.nextLine());
		   System.out.println("Age?");
			try{
        employeesList[1].setAge(input.nextInt());
		  }
		   System.out.println("Payment per hour?");
			try{
        employeesList[1].setHourlyPayment(input.nextInt());
		  }
		   System.out.println("Hours worked Monday?");
			try{
        employeesList[1].setHoursMonday(input.nextInt());
		  }
		   System.out.println("Hours worked Tuesday?");
			try{
		  employeesList[1].setHoursTuesday(input.nextInt());
		  }
		   System.out.println("Hours worked Wednesday?");
			try{
		  employeesList[1].setHoursWednesday(input.nextInt());
		  }
		   System.out.println("Hours worked Thursday?");
			try{
		  employeesList[1].setHoursThursday(input.nextInt());
		  }
		   System.out.println("Hours worked Friday?");
			try{
		  employeesList[1].setHoursFriday(input.nextInt());
		  }
		  input.nextLine();
       
        System.out.println("Name of third person?");
        employeesList[2].setName(input.nextLine());
		   System.out.println("Age?");
			try{
        employeesList[2].setAge(input.nextInt());
		  }
		   System.out.println("Payment per hour?");
			try{
        employeesList[2].setHourlyPayment(input.nextInt());
		  }
		   System.out.println("Hours worked Monday?");
			try{
        employeesList[2].setHoursMonday(input.nextInt());
		  }
		   System.out.println("Hours worked Tuesday?");
			try{
		  employeesList[2].setHoursTuesday(input.nextInt());
		  }
		   System.out.println("Hours worked Wednesday?");
			try{
		  employeesList[2].setHoursWednesday(input.nextInt());
		  }
		   System.out.println("Hours worked Thursday?");
			try{
		  employeesList[2].setHoursThursday(input.nextInt());
		  }
		   System.out.println("Hours worked Friday?");
			try{
		  employeesList[2].setHoursFriday(input.nextInt());
		  }
		  input.nextLine();*/
        
       
       /* for (int i=0; i<employeesList.length; i++)
        {
            employeesList[i].showEmployeeInfo();
        }*/
       
        int[][] info = new int[3][6];
        info[0][0] = employeesList[0].getHourlyPayment();
        info[0][1] = employeesList[0].getHoursMonday();
		  info[0][2] = employeesList[0].getHoursTuesday();
		  info[0][3] = employeesList[0].getHoursWednesday();
		  info[0][4] = employeesList[0].getHoursThursday();
		  info[0][5] = employeesList[0].getHoursFriday();
		
      
       
        info[1][0] = employeesList[1].getHourlyPayment();
        info[1][1] = employeesList[1].getHoursMonday();
        info[1][2] = employeesList[1].getHoursTuesday();
		  info[1][3] = employeesList[1].getHoursWednesday();
		  info[1][4] = employeesList[1].getHoursThursday();
		  info[1][5] = employeesList[1].getHoursFriday();
		  
       
        info[2][0] = employeesList[2].getHourlyPayment();
        info[2][1] = employeesList[2].getHoursMonday();
		  info[2][2] = employeesList[2].getHoursTuesday();
		  info[2][3] = employeesList[2].getHoursWednesday();
		  info[2][4] = employeesList[2].getHoursThursday();
	     info[2][5] = employeesList[2].getHoursFriday();
		  
		  System.out.println("\t"+"\t"+"\t"+"\t"+"Hours Worked------------------------------------------------------");
		  System.out.print("Name"+"\t");
		  System.out.print("Age"+"\t");
		  System.out.print("Hourly Pay($)"+"\t");
		  System.out.print("M"+"\t"+"\t");
		  System.out.print("T"+"\t"+"\t");
		  System.out.print("W"+"\t"+"\t");
		  System.out.print("Tr"+"\t"+"\t");
		  System.out.print("F");
		  System.out.print("\n");
		  
		  for(int i=0; i><info.length; i++)
        {
            System.out.print( employeesList[i].getName() +"\t");
				System.out.print( employeesList[i].getAge() +"\t");
				   
            for( int j = 0; j >< info[i].length; j++)
            {
               System.out.print(info[i][j]+"\t"+"\t");   
               //totalScore[i]=totalScore[i]+info[i][j];
            }
            //System.out.print(totalScore[i]);
            System.out.println();
        }
		  System.out.print("\n");
		  //System.out.println("");
		  
		System.out.println("Total earnings per day, total for the week:");
		
		System.out.print("Name"+"\t");
		  System.out.print("M"+"\t");
		  System.out.print("T"+"\t");
		  System.out.print("W"+"\t");
		  System.out.print("Tr"+"\t");
		  System.out.print("F"+"\t");
		  System.out.print("Total");
		  
		
		  //
		  int[] totalScore = new int[3];
       
      for (int i = 0; i < info.length ; i++)  
		{
  			//int[] totalScore = new int[1];
    		System.out.print("\n" + employeesList[i].getName() + "\t");  
    		for (int j = 1; j < info[i].length; j++)  
    		{  
        		// Calculate and print daily payment based on data  
        		// (hourly payment and hours worked per day)  
        		int daily = info[i][0] * info[i][j];  
        		System.out.print(daily + "\t");  
        		// Add daily payment to total payment per week    
        		totalScore[i] += daily;  
    		}  
    		// Print total amount of earning per week  
    		System.out.print(totalScore[i]);  
		}   
		  
		  System.out.print("\n"); 
		  
		  System.out.print("\n");
		  System.out.println();
		  
		  Arrays.sort(totalScore);
		  /*Arrays.sort(employeesList);
		  System.out.println("The Monday minimum score was:"+info[0][1]);
        System.out.println("The Monday maximum score was:"+info[2][1]);*/
		  //System.out.println("The minimum score was:"+totalScore[0]);
        //System.out.println("The maximum score was:"+totalScore[2]);
		  //
        //int[] totalScore = new int[3];
       
        /*for(int i=0; i<info.length; i++)
        {
            System.out.print( employeesList[i].getName() +"\t");   
            for( int j = 0; j >< info[i].length; j++)
            {
               System.out.print(info[i][j]+"\t");   
               //totalScore[i]=totalScore[i]+info[i][j];
            }
            //System.out.print(totalScore[i]);
            System.out.println();
        }*/
		  
		  
	  int[] mondayPayment = new int[3];
	  mondayPayment[0] = employeesList[0].getHourlyPayment() * employeesList[0].getHoursMonday();
	  mondayPayment[1] = employeesList[1].getHourlyPayment() * employeesList[1].getHoursMonday();
	  mondayPayment[2] = employeesList[2].getHourlyPayment() * employeesList[2].getHoursMonday();
	  
	  int[] tuesdayPayment = new int[3];
	  tuesdayPayment[0] = employeesList[0].getHourlyPayment() * employeesList[0].getHoursTuesday();
	  tuesdayPayment[1] = employeesList[1].getHourlyPayment() * employeesList[1].getHoursTuesday();
	  tuesdayPayment[2] = employeesList[2].getHourlyPayment() * employeesList[2].getHoursTuesday();
	  
	  int[] wednesdayPayment = new int[3];
	  wednesdayPayment[0] = employeesList[0].getHourlyPayment() * employeesList[0].getHoursWednesday();
	  wednesdayPayment[1] = employeesList[1].getHourlyPayment() * employeesList[1].getHoursWednesday();
	  wednesdayPayment[2] = employeesList[2].getHourlyPayment() * employeesList[2].getHoursWednesday();
	  
	  int[] thursdayPayment = new int[3];
	  thursdayPayment[0] = employeesList[0].getHourlyPayment() * employeesList[0].getHoursThursday();
	  thursdayPayment[1] = employeesList[1].getHourlyPayment() * employeesList[1].getHoursThursday();
	  thursdayPayment[2] = employeesList[2].getHourlyPayment() * employeesList[2].getHoursThursday();
	  
	  int[] fridayPayment = new int[3];
	  fridayPayment[0] = employeesList[0].getHourlyPayment() * employeesList[0].getHoursFriday();
	  fridayPayment[1] = employeesList[1].getHourlyPayment() * employeesList[1].getHoursFriday();
	  fridayPayment[2] = employeesList[2].getHourlyPayment() * employeesList[2].getHoursFriday();
		  
		  
     Arrays.sort(totalScore);
	  Arrays.sort(mondayPayment);
	  Arrays.sort(tuesdayPayment);
	  Arrays.sort(wednesdayPayment);
	  Arrays.sort(thursdayPayment);
	  Arrays.sort(fridayPayment);
	  
	  
	  	  System.out.println("On Monday, the maximum amount was $" + mondayPayment[2] +
		  ", and the minimum amount was $" + mondayPayment[0] +".");
		  
		 // System.out.print("\n");
		//  System.out.println("");
		  
		  System.out.println("On Tuesday, the maximum amount was $" + tuesdayPayment[2] +
		  ", and the minimum amount was $" + tuesdayPayment[0] +".");;
		  
		  //System.out.print("\n");
		 //System.out.println("");
		  
		  System.out.println("On Wednesday, the maximum amount was $" + wednesdayPayment[2] +
		  ", and the minimum amount was $" + wednesdayPayment[0] +".");
		  
		 // System.out.print("\n");
		 // System.out.println("");
		  
		  System.out.println("On Thursday, the maximum amount was $" + thursdayPayment[2] +
		  ", and the minimum amount was $" + thursdayPayment[0] +".");
		  
		 // System.out.print("\n");
		 // System.out.println("");
		  
		  System.out.println("On Friday, the maximum amount was $" + fridayPayment[2] +
		  ", and the minimum amount was $" + fridayPayment[0] +".");
		  
		 // System.out.print("\n");
		 // System.out.println("");
	  
         System.out.println("For the whole week, the maximum amount was $" + totalScore[2] +
		  ", and the minimum amount was $" + totalScore[0] +".");
        //System.out.println("The minimum score was:"+totalScore[0]+employeesList[i].getName());
        //System.out.println("The maximum score was:"+totalScore[2]);
		  
		  System.out.print("\n");
		  System.out.println("");
		  
		  System.out.println("Enter \"Continue\" to start again & input new information, or \"Quitting\" to quit the program.");
		  answer = input.nextLine();
		  repeat = answer.charAt(0);
    }   
     while (repeat == 'C' || repeat != 'Q');  
    }
	 }

[R. Jain]

Michael Payte wrote:

	          try {
                        employeesList[i].setHourlyPayment(input.nextInt());
		  }
		  catch (InputMismatchException e) {
                        while (!input.hasNextInt()){
		                    System.out.println("Input must be an integer.");
		                   //employeesList[i].setHourlyPayment(input.nextInt());
		                   input.next();
		        }
                   }

Take a look at your while.. What will happen if your condition becomes false (i.e., input entered is an integer)
You are doing nothing after that, so how will it get set to your required attribute??

[Rajdeep Biswas]

Hi,
The following idea might help.

Program1 p1 = new Program1();
boolean comeAgain;

do{
     //ask for user input
     String userInput = br.readLine();
     try{
          int hoursMonday = Integer.parseInt(userInput);
          p1.setHoursMonday(hoursMonday);
          //comeAgain = false means that the input is proper
          comeAgain = false;
     }
     catch(InputMismatchException e){
          System.out.println("message: enter only integers");
          //comeAgain = true means that the input is not an integer and the user should be asked again to input
          comeAgain = true;
     }
}while(comeAgain);

/*
* Now, proceed to ask more inputs
*/

Edit: Ahh!! yes, try to make a more generic method and build the validation logic inside that, and enjoy OOP modularity...
Regards,

[R. Jain]

If you are reading so much of values from user, then I would not prefer reading it this way..
You can see so much try-catch block back to back in your code..

Indeed, your main method should never be so long.. All your job is done in main method..
A better way would be to create a method that reads user input and also handles exception according to your need..

Now, for every value to be read, just call that method, it will get your job done..

int hoursWork = getUserInput();
int workOnTuesday getUserInput();

And your getUserInput() will contain the code of reading integer values from user..

Try to create different methods for different functionality, and invoke those methods from your main in order.
Like, there can be: -
1). separate method for printing all your attributes,
2). a separate method for doing some calculation on user-input, or attributes,
3). a separate method for taking user input..

Avoid keeping your main method doing all the works..

[Michael Payte]

Rajdeep Biswas wrote:Hi,
The following idea might help.

Program1 p1 = new Program1();
boolean comeAgain;

do{
     //ask for user input
     String userInput = br.readLine();
     try{
          int hoursMonday = Integer.parseInt(userInput);
          p1.setHoursMonday(hoursMonday);
          //comeAgain = false means that the input is proper
          comeAgain = false;
     }
     catch(InputMismatchException e){
          System.out.println("message: enter only integers");
          //comeAgain = true means that the input is not an integer and the user should be asked again to input
          comeAgain = true;
     }
}while(comeAgain);

/*
* Now, proceed to ask more inputs
*/

Edit: Ahh!! yes, try to make a more generic method and build the validation logic inside that, and enjoy OOP modularity...
Regards,

What's br? It's not defined anywhere.

[Rajdeep Biswas]

NOTE: This is just a sample, you have to customize it.

Michael Payte wrote:What's br? It's not defined anywhere.

public class DataHandler{
		public static void setData(String whatToSet){

			BufferedReader br = new BufferedReader(new InputStreamReader(System.in));
			String userInput;
			int userInputInteger;
			boolean comeAgain;
			//creating instance for your POJO class (only setters and getters)
			Program1 p1 = new Program1();

			do{  
				 //ask for user input
				 System.out.println("Enter " + whatToSet + ": ");
				 String userInput = br.readLine();  
				 try{
					 userInputInteger = Integer.parseInt(userInput);
					 /* 
					 * Depending upon whatToSet, you can have more validations, suppose, age can not be more than 65 and less than 18 
					 */  
					 if("age".equalsIgnoreCase(whatToSet))
						 p1.setAge(userInputInteger);
					 else if("hours for monday".equalsIgnoreCase(whatToSet))
						 p1.setHoursMonday(userInputInteger);
					 else if("hours for tuesday".equalsIgnoreCase(whatToSet))
						 p1.setHoursTuesday(userInputInteger);
					 /*
					 * carry on with more checks
					 */

					  //the input is integer (proper) so we do not have to re-work the loop
					  comeAgain = false;  
				 }  
				 catch(NumberFormatException e){  
					  System.out.println("message: enter only integers");  
					  //comeAgain = true means that the input is not an integer and the user should be asked again to input  
					  comeAgain = true;  
				 }  
			}while(comeAgain);  
	}
}

And you should call this method from your application, like following:

DataHandler.setData("hours for monday");
DataHandler.setData("age");