Creating a 2d square matrix from a 2d integer arraylist

[Vic Hood]

Hello Folks,

Ive written the following code that converts a 2d arraylist into a 2d matrix, but now I need to check that the matrix created is also square(num of rows = num of columns).

Could anyone explain how I could possibly modify my code to acheive that?


My code is

	
int[][] input2DArray = null;
		ArrayList<ArrayList<Integer>> dynamicInputMatrix = new ArrayList<ArrayList<Integer>>();
		
		try {
			
			Scanner input;
			input = new Scanner(new File(textFileName));
			while (input.hasNextLine()) {
				Scanner colReader = new Scanner(input.nextLine());
				ArrayList<Integer> col = new ArrayList<Integer>();
				while (colReader.hasNextInt()) {
					col.add(colReader.nextInt());
					col.trimToSize();
					
				}
				dynamicInputMatrix.add(col);
			}
			input2DArray = new int[dynamicInputMatrix.size()][dynamicInputMatrix.size()];
			System.out.println(input2DArray.length+" "+input2DArray[0].length);
			int row = 0;
			int column = 0;
			for (ArrayList<Integer> l : dynamicInputMatrix) {
				column = 0;
				while (column < l.size()) {
					for (Integer value : l) {

					 if (value!=null) {
						input2DArray[row][column] = value;
					 }
						column++;
					}
					row++;
				}
			}
			if (input2DArray.length!=input2DArray[0].length) {
			    throw new  IllegalStateException("The input needs to be a square matrix!"); // This code is never accessed!
			}

			
					

		} catch (FileNotFoundException e) {
			e.printStackTrace();
			System.err.println("File not found! Please place it in the right place.");
		}
		return input2DArray;
		
	
	}

[Campbell Ritchie]

What’s a 2D list?     Is there such a thing? I think there isn’t, only a List of Lists.
What’s a 2D array? Is there such a thing? I think there isn’t, only an array of arrays.

That may appear pedantic, but arrays of arrays are better than 2D arrays. For example, the outermost array has a length field, which you doubtless already know about. And the element arrays also have a length field. So you can iterate the outer array with a for‑each loop and check that all the lengths are the same.
You can do the same sort of thing with the size() method of your Lists. It might be quicker to do that validation at as early a stage as possible.

[Campbell Ritchie]

Please look for methods which can turn Lists into arrays. You might find them in the java.util.Collections class.