This week's book giveaway is in the OO, Patterns, UML and Refactoring forum.
We're giving away four copies of Five Lines of Code and have Christian Clausen on-line!
See this thread for details.
Win a copy of Five Lines of Code this week in the OO, Patterns, UML and Refactoring forum!
  • Post Reply Bookmark Topic Watch Topic
  • New Topic
programming forums Java Mobile Certification Databases Caching Books Engineering Micro Controllers OS Languages Paradigms IDEs Build Tools Frameworks Application Servers Open Source This Site Careers Other all forums
this forum made possible by our volunteer staff, including ...
Marshals:
  • Campbell Ritchie
  • Bear Bibeault
  • Ron McLeod
  • Jeanne Boyarsky
  • Paul Clapham
Sheriffs:
  • Tim Cooke
  • Liutauras Vilda
  • Junilu Lacar
Saloon Keepers:
  • Tim Moores
  • Stephan van Hulst
  • Tim Holloway
  • fred rosenberger
  • salvin francis
Bartenders:
  • Piet Souris
  • Frits Walraven
  • Carey Brown

Code review

 
Greenhorn
Posts: 2
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Can someone please test/review this code. I apologize if the code is unconventional as I am new to JAVA and learning as I go, but I would appreciate any constructive critisism.

The application is working as expected, however I have a bug which eludes me. If you add 2 records and delete record 1, the program will fail with the following:


Here is the full code, any help or tips would be greatly appreciated:
 
Ranch Hand
Posts: 178
2
Netbeans IDE MySQL Database Java
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I think you are trying to delete a object in JComboBox.
You deleting command is fine. But there is a problem.

After you have deleted a object in JComboBox, the selected item is changing implicitly. That's because JComboBox cannot find that previously selected item as it has been deleted. Therefore JComboBox select the previous item.
But you have override itemStateChanged() method. As the previously selected item is deselected and new item is selected, overridden method is called twice. (But it is not the problem here)


Here the variable 'selected' is the problem. If you select 2nd item selected=1. After you delete 2nd item, JVM calls itemStateChanged() method. Then comboBox.getItemAt(selected) will give runtime error as 'selected = 1'.
 
Gareth Billett
Greenhorn
Posts: 2
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Thanks Ramesh I see the issue.
 
There is no "i" in denial. Tiny ad:
Thread Boost feature
https://coderanch.com/t/674455/Thread-Boost-feature
    Bookmark Topic Watch Topic
  • New Topic