Problem with "Timer"...don't respect the speed....

[paul beppe]

hello to all! I have a problem with the "Timer" ... when I click again on "buttonImage1"
does not respect the speed indicated to me ... increases the speed! always...Why???

this is the code:

import java.awt.BorderLayout;
import java.awt.Color;
import java.awt.Graphics;
import java.awt.Graphics2D;
import java.awt.Image;
import java.awt.Toolkit;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.AbstractAction;
import javax.swing.ImageIcon;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JPanel;
import javax.swing.JScrollPane;
import javax.swing.Timer;

public class Animation extends JFrame  {
  Timer timer;
  Image animation;
  Immagine currentAnimation = new Immagine();
  ImageIcon img;
  JScrollPane scroll = new JScrollPane();
  JFrame frame = new JFrame("Animation");
  JPanel panelMenu = new JPanel();
  JButton buttonPause = new JButton("Pause");
  JButton buttonPlay = new JButton("Play");
  JButton buttonImage1 = new JButton("Image1");
  JButton buttonImage2 = new JButton("Image2");
	
  public Animation () {
    
    panelMenu.add(buttonPlay);
    buttonPlay.addActionListener(new ActionListener() {					
		public void actionPerformed(ActionEvent evt) {
		    timer.start();
		}
	});
    
    panelMenu.add(buttonPause);
    buttonPause.addActionListener(new ActionListener() {					
		public void actionPerformed(ActionEvent evt) {
			timer.stop();
		}
	});
    
    panelMenu.add(buttonImage1);
    buttonImage1.addActionListener(new ActionListener() {					
		public void actionPerformed(ActionEvent evt) {
			img = new ImageIcon("c://db/testi/moda.jpg");
			animation = img.getImage();
			prepareImage(animation, null);
			currentAnimation.setX(30);
			currentAnimation.setY(+250);	
		    timer = new Timer(100, (ActionListener) paintTimer);
		    timer.start();
		}
    
    });
    panel.add(new JLabel(img));
	scroll = new JScrollPane(panel);
    frame.getContentPane().add(scroll, BorderLayout.CENTER);
    frame.add(panelMenu, BorderLayout.NORTH);
    frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    frame.setSize(800, 600);
    frame.setLocationRelativeTo(null);
    frame.setVisible(true);
  }
  javax.swing.Action paintTimer = new AbstractAction() { 
	public void actionPerformed(ActionEvent e) {			
		currentAnimation.setY(currentAnimation.getY() - 1);
		scroll.repaint();					
	}
  };
  JPanel panel = new JPanel() {
	  public void paint(Graphics g) {
		  super.paint(g);
		  Graphics2D g2d = (Graphics2D) g;
		  g.setColor(Color.WHITE);
		  g.fillRect(0, 0, 6600, 6600);
		  g2d.drawImage(animation, currentAnimation.getX(), currentAnimation.getY(), this);			
		  Toolkit.getDefaultToolkit().sync(); 
		  g.dispose();  
	  }
  };
  public static void main(String[] args) {
	  new Animation ();
  }

}
class Immagine {

	private int x;
	private int y;

	Immagine() {
		;
	} 

	public int getX() { 
		return x;
	}

	public void setX(int x2) {
		x = x2;
	}

	public int getY() {
		return y;
	}

	public void setY(int y2) {
		y = y2;
	}
}

where is the error???

[Piet Souris]

Paul,

this is (at least?) the third thread you open about your not-working-properly-code.

Just stick to one thread. Let us know what you did with all the advises given to you, what you did to test your results and what efforts you made trying to find out what was causing the problem.

The way you do it now shows no respect to all the people who tried to help, in my view. You just present us with code, and then simply ask us what's wrong with it.

Greetings,
Piet

[Campbell Ritchie]

Piet Souris wrote: . . . Just stick to one thread. . . .

Thank you for noticing. Closing thread.