Image does not appear?

[Wilson Cash]

Hi,

I was trying to load an image and print it out on the screen, but for some reason it does not seem to appear. The path is correct (the file is in a res folder), but even with an image that is elsewhere on my computer with the correct file path it still does not work.

Game.java

import javax.swing.JFrame;

import com.desecrationstudios.twilight.gfx.Screen;

public class Game extends JFrame{

	private static final long serialVersionUID = 1L;
	
	public static final int WIDTH = 500;
	public static final int HEIGHT = 350;
	public static final String NAME = "Game";
	
	public Game(){
		setSize(WIDTH, HEIGHT);
		setResizable(false);
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		setLocationRelativeTo(null);
		setTitle(NAME);
		
		add(new Screen());
		setVisible(true);
	}
	
	public static void main(String[] args){
		new Game();
	}
}

Screen.java

import java.awt.Graphics;
import java.awt.Graphics2D;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;

import javax.swing.JPanel;
import javax.swing.Timer;

public class Screen extends JPanel implements ActionListener, KeyListener{

	private static final long serialVersionUID = 2791049993836372036L;

	private Background background;
	
	public Screen(){
		background = new Background();
		
		Timer tick = new Timer(20, this);
		tick.start();
		
		this.addKeyListener(this);
		this.setDoubleBuffered(true);
		this.setFocusable(true);
	}
	
	private void update(){
		
	}
	
	public void PaintComponent(Graphics g){
		super.paintComponent(g);
		
		//Background, will have its own function soon.
		Graphics2D g2d = (Graphics2D)g;
        g2d.drawImage(background.getImage(), background.getX(), background.getY(), this);
	}
	
	public void actionPerformed(ActionEvent arg0) {
		update();
		repaint();
	}
		
	public void keyPressed(KeyEvent arg0) {
	
	}


	public void keyReleased(KeyEvent arg0) {

	}

	public void keyTyped(KeyEvent arg0) {

	}
}

Background.java

import java.awt.Image;
import javax.swing.ImageIcon;

public class Background {
	
	public int x = 0;
	public int y = 0;
	
	private Image background;
	
	public Background(){
		 ImageIcon i = new ImageIcon("/background_night_1.png");
	     background = i.getImage();
	}
	
	public int getX() {
		return x;
	}

	public int getY() {
		return y;
	}

	public Image getImage() {
		return background;
	}
}

Thanks!

Also, another question I have, is how would I define the drawImage function in the background class, so that in the screen.paintComponent method I just have to call background.paint(g) and it prints it out on the screen?
Something like this:

public void paint1(Graphics g){
		g.setColor(Color.RED);
		g.fillRect(x, y, height, width);
	}

and then I just have to call player.paint(g) in screen.paintComponent method

but instead with an image like so:

	public void paint(Graphics g){
		 ImageIcon i = new ImageIcon("/background_night_1.png");
	     background = i.getImage();
	     Graphics2D g2d = (Graphics2D)g;
	     g2d.drawImage(background, x, y, this);

	}

but that does not work because "The method drawImage(Image, int, int, ImageObserver) in the type Graphics is not applicable for the arguments (Image, int, int, Background)"

[Rob Camick]

There is no need to create a custom component to display an image. Just add the ImageIcon to a JLabel and add the label to the frame.

You have several problems with your painting code:

1) Don't override or invoke the update() method. This is only done in AWT and not in Swing.
2) Your "PaintComponent" method name is wrong. Methods don't start with an upper case character. Use @Override before the method name and the compiler will catch the error. Ie try the following to see what the compiler error is, then fix the error:

@Override
protected void PaintComponent(Graphics g)

3) You are using the drawImage() method invorrectly. The second/third parameters should be the location of the image, not the size.