JSF problem with form (update user)

[Oleksandr Hubachov]

Hi, all. I'm new in JSF and hope on your help. My task is to write simple CRUD application (JSF+Hibernate). I have a problem with Update operation. On page I choose user to update, than click button Update. Opens page with form, where all field filled of user information. Than I change something and click Update. But form become clean and method update() in bean does not calls. When I click to this button second time, this method is called, but i need to write user information manually. Why method does not calls first time? Code:
List of users:
<h:form> <p:dataTable value="#{user.list()}" var="item" selectionMode="single" rowKey="#{item.id}" selection="#{user.selected}"> <p:column headerText="Id"> <h:outputText value="#{item.id}" /> </p:column> <p:column headerText="First Name"> <h:outputText value="#{item.firstName}" /> </p:column> <p:column headerText="Gender"> <h:outputText value="#{item.gender}" /> </p:column> <p:column headerText="Birthday"> <h:outputText value="#{item.birthday}" /> </p:column> </p:dataTable> <p:commandButton id="updateButton" value="Update" action="#{user.load()}" /> </h:form>

Page of update:
<h:form> <h:panelGrid border="1" columns="2"> <h:outputText value="Id"></h:outputText> <h:outputText value="#{user.id}" /> <h:outputText value="First Name"></h:outputText> <h:inputText value="#{user.firstName}"></h:inputText> <h:outputText value="Gender"></h:outputText> <p:selectOneMenu value="#{user.gender}"> <f:selectItem itemLabel="Male" itemValue="MALE" /> <f:selectItem itemLabel="Female" itemValue="FEMALE" /> </p:selectOneMenu> <h:outputText value="Birthday"></h:outputText> <p:calendar value="#{user.birthday}" /> <h:commandButton action="#{user.update()}" value="Update"></h:commandButton> </h:panelGrid> <h:inputHidden value="#{user.id}"/> </h:form>


Bean class

public class UserBean {
    private Integer id;
    private String firstName;
    private Date birthday;
    private Gender gender;
    private User selected;
 
            // getters and setters
 
    public List<User> list() {
        Session session = getSession();
        return session.createCriteria(User.class).list();
    }
 
    public String update() {
        System.out.println(id);
        Session session = getSession();
        Transaction tx = session.beginTransaction();
        session.update(constructUser());
        tx.commit();
        return "current";
    }
 
    public String load() {
        fillBean();
        return "update";
    }
 
    private void fillBean() {
        this.id = selected.getId();
        this.firstName = selected.getFirstName();
        this.gender = selected.getGender();
        this.birthday = selected.getBirthday();
    }
 
    private user constructUser() {
        User user = new User();
        user.setId(id);
        user.setFirstName(firstName);
        user.setBirthday(birthday);
        user.setGender(gender);
        return user;
    }
 
    private Session getSession() {
        return HibernateUtil.getSessionFactory().openSession();
    }
}

Thanks for your answers

[K. Tsang]

Why does your update() method call "update(contructUser())"? And in your constructUser() method, you are doing new User()... so when you call update, it will create a new instance of User making the original data lost.

In your JSF page you can call update(user) directly and pass in the user object to your bean. That way you can simply do session.update(user).

[Oleksandr Hubachov]

It does not matter. Method does not calls at any case.

[Tim Holloway]

The following constructs are incorrect:

value="#{user.list()}"

action="#{user.load()}"

The primary purpose of EL is not to act as a programming language, it is to permit specifying bean property or method references. So, for example, your commandButton should be coded like this:

         <p:commandButton id="updateButton" value="Update"  
            action="#{user.load}" />  

You did not indicate how (or even if) you associated class UserBean with the EL object named "user". So we need to see the bean annotations or faces-config.xml entry that defines the UserBean as a JSF Managed Bean.

[Oleksandr Hubachov]

Thanks for your answers. I find an error. This method working correctly (even action="#{user.load()}" and action="#{user.load()}"). Problem is in p:calendar and p:selectOneMenu . I need to write right converter, but i don't know how. If i delete from page information about gender, nationality and birthday, all will be ok. I will google and post here a solution.