<Terminated, exit value: 0>, but no output from println command

[Jw Riggs]

I'm as green as they come, so be gentle...

I'm trying to capture some MIDI events and throw them into an ArrayList so that our other program can then iterate through them and display the notes using Batik. I have the following code, but when I run or debug it, I just get the following message:

<terminated, exit value: 0>C:\Program Files\Java\jre7\bin\javaw.exe (Sep 5, 2013, 1:51:50 PM)

which, from what I can gather, means that everything ran according to plan. Unfortunately I'm not seeing any of the output from my System.out.println commands. Here's the code:

import java.io.File;
import java.io.InputStream;
import java.util.ArrayList;

import javax.sound.midi.MidiSystem;
import javax.sound.midi.Sequence;
import javax.sound.midi.ShortMessage;
import javax.sound.midi.Track;


public class MIDILoader {
	/**
	*loads a midi file from disk and stores all notes in a nested Array List, using the Helper class "Note"
	* needs some cleanup though
	*/
	public static void main(String[] args){}
	
	  ArrayList<ArrayList<Note>> tracks;
	  long maxTicks = 0;
	  final boolean DO_PRINT = false;

	  MIDILoader(String fileName) {

	    //Notes are stored in this nested array list to mirror the track-note structure (depending on type of midi file)
		tracks = new ArrayList<ArrayList<Note>>();
	    Track[] trx;

	    try {
	      
	      fileName = "C:\\Users\\jriggs\\Desktop\\Give.mid";
	      File myMidiFile = new File(fileName);
	      Sequence mySeq = MidiSystem.getSequence(myMidiFile);
	      trx = mySeq.getTracks();

	      for (int i = 0; i < trx.length; i++) {
	        ArrayList<Note> trackAsList = new ArrayList<Note>();
	        tracks.add(trackAsList);
	        Track t = trx[i];
	        if (DO_PRINT) {
	          System.out.println("track ");
	          System.out.println("length:"+ t.ticks());
	          System.out.println("num events:" + t.size());
	        }
	        int counter = 0;
	        //iterate over the vector, and remove each handled event.
	        while (t.size () > 0 && counter < t.size()) {
	          counter ++;
	          if (t.get(0).getMessage() instanceof ShortMessage) {

	            ShortMessage s = (ShortMessage)(t.get(0).getMessage());
	            //find note on events
	            if (s.getCommand() == ShortMessage.NOTE_ON) {
	              if (DO_PRINT)System.out.println(s.getCommand() + " " + s.getChannel() +" " + s.getData1() + " " + s.getData2());              
	              //store all the values temporarily in order to find the associated note off event
	              long startTime = t.get(0).getTick();
	              long endTime = 0;
	              int ch = s.getChannel();
	              int pitch = s.getData1();
	              int vel = s.getData2();
	              
	              //if the first note has zero velocity (== noteOff), remove it
	              if (vel == 0) {
	                t.remove(t.get(0));
	              } 
	              
	              else {
	                //start to look for the associated note off
	                for (int j = 0; j < t.size(); j++) {
	                  if (t.get(j).getMessage() instanceof ShortMessage) {
	                    ShortMessage s2 = (ShortMessage)(t.get(j).getMessage());
	                    //two types to send a note off... either as a clean command or as note on with 0 velocity
	                    if ((s2.getCommand() == ShortMessage.NOTE_OFF) || s2.getCommand() == ShortMessage.NOTE_ON) {
	                      //compare to stored values, sending a note off with same channel and pitch means to stop the note
	                      if (s2.getChannel() == ch && s2.getData1() == pitch && s2.getData2() == 0) {
	                        //calculate note duration
	                        endTime = t.get(j).getTick();
	                        //extend maxticks, so we know when the last midi event happened (sometimes tracks are much longer than the last note
	                        if (endTime > maxTicks)maxTicks = endTime;
	                        //create a new "Note" instance, store it
	                        Note n = new Note(startTime, endTime-startTime, ch, vel, pitch);
	                        trackAsList.add(n);
	                        t.remove(t.get(0));
	                        break;
	                      }
	                    }
	                  }
	                }
	              }
	              //remove event when done
	              t.remove(t.get(0));
	            }
	            else {
	              //remove events which are shortmessages but not note on (e.g. control change)
	              t.remove(t.get(0));
	            }
	          } 
	          else {
	            //remove events which are not of type short message
	            t.remove(t.get(0));
	          }
	        }
	      }
	    }
	    catch (Exception e) {
	      e.printStackTrace();
	    }
	  }

	ArrayList<Note> trackAsArrayList(int i) {
	    return tracks.get(i);
	    // return null;
	  }
	  int numTracks() {
	    return tracks.size();
	  }
	}



	/**
	*Helper Class Note, stores start time, end time, channel, pitch and duration
	*/
	class Note {
	  long start;
	  long duration;

	  int channel;
	  int velocity;
	  int pitch;

	  Note(long theStart, long theDuration, int theChannel, int theVelocity, int thePitch) {
	    start = theStart;
	    channel = theChannel;
	    pitch = thePitch;
	    velocity = theVelocity;
	    duration = theDuration;
	  }	
}

Does anyone see what's going on here? I've verified the path for the fileName variable, so I'm pretty sure I'm good there. I'd debug it, but when I set a breakpoint, it doesn't get far enough to check for the values of my variables.

Thanks for the help!

Justin

[Henry Wong]

Jw Riggs wrote:I'm as green as they come, so be gentle...

I'm trying to capture some MIDI events and throw them into an ArrayList so that our other program can then iterate through them and display the notes using Batik. I have the following code, but when I run or debug it, I just get the following message:

<terminated, exit value: 0>C:\Program Files\Java\jre7\bin\javaw.exe (Sep 5, 2013, 1:51:50 PM)

which, from what I can gather, means that everything ran according to plan. Unfortunately I'm not seeing any of the output from my System.out.println commands. Here's the code:


Does anyone see what's going on here? I've verified the path for the fileName variable, so I'm pretty sure I'm good there. I'd debug it, but when I set a breakpoint, it doesn't get far enough to check for the values of my variables.

Thanks for the help!

Justin

All the System.out.println() calls are wrapped in a conditional, using the DO_PRINT variable. And the boolean variable is set to false.

Henry

[Jw Riggs]

Henry Wong wrote:
All the System.out.println() calls are wrapped in a conditional, using the DO_PRINT variable. And the boolean variable is set to false.

Thanks Henry,

Changed the value to true, and am still getting nothing but the <terminated> message in the console when I run or debug...

[Henry Wong]

Jw Riggs wrote:
Changed the value to true, and am still getting nothing but the <terminated> message in the console when I run or debug...

Did you try to run this from the command line instead? This way, you can tell if it is a problem with the java program, or the code that is calling your java program.

Henry

[Jw Riggs]

Henry Wong wrote:

Jw Riggs wrote:
Changed the value to true, and am still getting nothing but the <terminated> message in the console when I run or debug...

Did you try to run this from the command line instead? This way, you can tell if it is a problem with the java program, or the code that is calling your java program.

Henry

Well, I fixed the issue. Like I said, I'm brand new to this, so I'm not sure I can explain why what I did worked, but here's the gist of it. While playing around I saw a tooltip that said that MIDILoader was the name of a constructor. I googled how to call an instance of a constructor in the main class, and did that. Suddenly, *poof*, everything worked. Here's the code:

import java.io.BufferedWriter;
import java.io.File;
import java.io.FileWriter;
import java.io.Writer;
//import java.io.InputStream;
import java.util.ArrayList;
//import java.util.Collections;
import javax.sound.midi.MidiSystem;
import javax.sound.midi.Sequence;
import javax.sound.midi.ShortMessage;
import javax.sound.midi.Track;
import javax.swing.JOptionPane;

public class MIDILoader {
	/**
	*loads a midi file from disk and stores all notes in a nested Array List, using the Helper class "Note"
	* needs some cleanup though
	*/
	public static void main(String[] args){
		new MIDILoader();
		}
	
	  ArrayList<ArrayList<Note>> tracks;
	  long maxTicks = 0;
	  final boolean DO_PRINT = true;

	  MIDILoader() {

	    //Notes are stored in this nested array list to mirror the track-note structure (depending on type of midi file)
		tracks = new ArrayList<ArrayList<Note>>();
	    Track[] trx;

	    try {
	      
	      String fileName = "C:\\Users\\jriggs\\Desktop\\mac.mid";
	      File myMidiFile = new File(fileName);
	      Sequence mySeq = MidiSystem.getSequence(myMidiFile);
	      trx = mySeq.getTracks();
	      System.out.println("number of tracks:"+ trx.length);
	      

	      for (int i = 0; i < trx.length; i++) {
	        ArrayList<Note> trackAsList = new ArrayList<Note>();
	        tracks.add(trackAsList);
	        Track t = trx[i];
	        if (DO_PRINT) {
	          System.out.println("track");
	          System.out.println("length:"+ t.ticks());
	          System.out.println("num events:" + t.size());
	        }
	        int counter = 0;
	        //iterate over the vector, and remove each handled event.
	        while (t.size() > 0 && counter < t.size()) {
	          counter ++;
	          if (t.get(0).getMessage() instanceof ShortMessage) {

	            ShortMessage s = (ShortMessage)(t.get(0).getMessage());
	            //find note on events
	            if (s.getCommand() == ShortMessage.NOTE_ON) {
	              if (DO_PRINT)System.out.println(s.getCommand() + " " + s.getChannel() +" " + s.getData1() + " " + s.getData2());   
	              //store all the values temporarily in order to find the associated note off event
	              long startTime = t.get(0).getTick();
	              long endTime = 0;
	              int ch = s.getChannel();
	              int pitch = s.getData1();
	              int vel = s.getData2();
	              //if the first note has zero velocity (== noteOff), remove it
	              if (vel == 0) {
	                t.remove(t.get(0));
	              } 
	              
	              else {
	                //start to look for the associated note off
	                for (int j = 0; j < t.size(); j++) {
	                  if (t.get(j).getMessage() instanceof ShortMessage) {
	                    ShortMessage s2 = (ShortMessage)(t.get(j).getMessage());
	                    //two types to send a note off... either as a clean command or as note on with 0 velocity
	                    if ((s2.getCommand() == ShortMessage.NOTE_OFF) || s2.getCommand() == ShortMessage.NOTE_ON) {
	                    	if (DO_PRINT)System.out.println(s2.getCommand() + " " + s2.getChannel() +" " + s2.getData1() + " " + s2.getData2());
	                      //compare to stored values, sending a note off with same channel and pitch means to stop the note
	                      if (s2.getChannel() == ch && s2.getData1() == pitch && s2.getData2() == 0) {
	                        //calculate note duration
	                        endTime = t.get(j).getTick();
	                        //extend maxticks, so we know when the last midi event happened (sometimes tracks are much longer than the last note
	                        if (endTime > maxTicks)maxTicks = endTime;
	                        //create a new "Note" instance, store it
	                        Note n = new Note(startTime, endTime-startTime, ch, vel, pitch);
	                        trackAsList.add(n);
	                        t.remove(t.get(0));
	                        try {
		          	            File outputFile = new File("C:\\Users\\jriggs\\Desktop\\trackAsListOutput.txt");
		          	            FileWriter fw = new FileWriter(outputFile);
		          	    	    Writer output = new BufferedWriter(fw);
		          	    	    int sz = trackAsList.size();
		          	    	    for (int k = 0; k < sz; k++) {
		          	    	    	output.write(s2.getCommand() + " " + s2.getChannel() +" " + s2.getData1() + " " + s2.getData2());
		          	            }
		          	            output.close();
		          	            }
		          	            catch (Exception e) {
		          	            	JOptionPane.showMessageDialog(null, "Cannot create file");
		          	            }
	                        break;
	                      }
	                    }
	                  }
	                }
	              }
	              //remove event when done
	              t.remove(t.get(0));
	            }
	            else {
	              //remove events which are shortmessages but not note on (e.g. control change)
	              t.remove(t.get(0));
	            }
	          } 
	          else {
	            //remove events which are not of type short message
	            t.remove(t.get(0));
	          }
	        }
	      }
	    }
	    catch (Exception e) {
	      e.printStackTrace();
	    }
	    try {
            File outputFile = new File("C:\\Users\\jriggs\\Desktop\\ArrayListOutput.txt");
            FileWriter fw = new FileWriter(outputFile);
    	    Writer output = new BufferedWriter(fw);
    	    int sz = tracks.size();
    	    for (int k = 0; k < sz; k++) {
    	    	output.write(tracks.get(k).toString());
            }
            output.close();
            }
            catch (Exception e) {
            	JOptionPane.showMessageDialog(null, "Cannot create file");
            }
	  }
	  
	ArrayList<Note> trackAsArrayList(int i) {
	    return tracks.get(i);
	  }
	
	  int numTracks() {
	    return tracks.size();
	  }
	}

	/**
	*Helper Class Note, stores start time, end time, channel, pitch and duration
	*/
	class Note {
	  long start;
	  long duration;

	  int channel;
	  int velocity;
	  int pitch;

	  Note(long theStart, long theDuration, int theChannel, int theVelocity, int thePitch) {
	    start = theStart;
	    channel = theChannel;
	    pitch = thePitch;
	    velocity = theVelocity;
	    duration = theDuration;
	  }	
}

Now I'm working on outputting the values I see from the println command to a text file. I have the right code to do it (the files are being generated and a single value is in the file), but I'm obviously not putting it in the right part of the loop. If I can't figure that out, I suppose I'll start a new topic; I just hate to ask such simple questions. Makes me feel, well, sloooooow...

Thanks for your help!!

[Winston Gutkowski]

Jw Riggs wrote:Well, I fixed the issue. Like I said, I'm brand new to this, so I'm not sure I can explain why what I did worked...

And I suspect that the reason for that is that you've written so much code.
I can't remember the last time I wrote a method that was more than about 30 lines, except when I was writing Swing code.

My advice: StopCoding (←click) and rationalise some of the main steps of that wall of code into methods.
You'll thank me later.

Oh, and it's probably way too late now, but please DontWriteLongLines. It makes your thread very hard to follow;
and it's actually a very bad coding habit to get into.

Winston