Custom validator not validating all properties defined in Validation.xml

[Pan Jain]

Hi,
I have written a custom validation class to validate special character. Problem I am facing is that custom class is just validating first form property defined in validation.xml
It is skipping all other property defined.
Here is code snippet:



Validation.xml: <form-validation> <formset> <form name="HrmPersonalDtlsForm"> <field property="placeOfBirth[0]" depends="maxlength,textFieldValidate"> <arg0 key="hrm.HrmEmpPersonalDetails.placeOfBirth"/> <arg1 name="maxlength" key="${var:maxlength}" resource="false"/> <var> <var-name>maxlength</var-name> <var-value>20</var-value> </var> </field> </form> <form name="HrmPersonalDtlsForm"> <field property="dateOfBirth[0]" depends="maxlength,textFieldValidate"> <arg0 key="hrm.HrmEmpPersonalDetails.dateOfBirth"/> <arg1 name="maxlength" key="${var:maxlength}" resource="false"/> <var> <var-name>maxlength</var-name> <var-value>20</var-value> </var> </field> </form> </formset> </form-validation>

Validator-rules.xml: <form-validation> <global> <validator name="textFieldValidate" classname="wenrgise.hrms.util.FieldValidator" method="validateFormTextFields" methodParams="java.lang.Object, org.apache.commons.validator.ValidatorAction, org.apache.commons.validator.Field, org.apache.struts.action.ActionMessages, javax.servlet.http.HttpServletRequest" msg="errors.specialCharacter"> </validator> <validator name="maxlength" classname="org.apache.struts.validator.FieldChecks" method="validateMaxLength" methodParams="java.lang.Object, org.apache.commons.validator.ValidatorAction, org.apache.commons.validator.Field, org.apache.struts.action.ActionMessages, org.apache.commons.validator.Validator, javax.servlet.http.HttpServletRequest" msg="errors.maxlength"/> </global> </form-validation>

FieldValidator class:

public class FieldValidator {
	
	public static boolean validateFormTextFields(Object bean,
		    ValidatorAction action,
		    Field field,
		    ActionMessages errors,
		    HttpServletRequest request) throws EnrgiseApplicationException
		  {
		    String value = ValidatorUtil.getValueAsString(bean, field.getProperty());
		    
			String[] illegalChars = {"!", "@", "#", "$","^", "&", "*","{", "}", "|",":", "<", ">", "?", "`", "=", ";"};
			
			for(int i = 0; i < illegalChars.length; i++ ){
		        if (value != null && value.contains(illegalChars[i])) {
		        	if (errors != null) {
		        		errors.add(field.getKey(), Resources.getActionMessage(request, action, field));
		        	}
		        	return false;
		        }
		    }
			return true;
			
		  }

}

It is validating placeOfBirth[0] property correctly, but some how skipping other defined property. No idea why. Any help will be appreciated !

[Pan Jain]

Did a small change in validation.xml and it is resolved, kept properties under same form name instead of creating a separate form tag for each property:

<form-validation> <formset> <form name="HrmDtlsForm"> <field property="placeOfBirth[0]" depends="maxlength,textFieldValidate"> <arg0 key="hrm.placeOfBirth"/> <arg1 name="maxlength" key="${var:maxlength}" resource="false"/> <var> <var-name>maxlength</var-name> <var-value>20</var-value> </var> </field> <field property="dateOfBirth[0]" depends="maxlength,textFieldValidate"> <arg0 key="hrm.dateOfBirth"/> <arg1 name="maxlength" key="${var:maxlength}" resource="false"/> <var> <var-name>maxlength</var-name> <var-value>20</var-value> </var> </field> </form> </formset> </form-validation>

[Pan Jain]

<NA>

[Pan Jain]

<NA>