Forum:

error is coming in file variable

Megha Singhal

Ranch Hand

Posts: 225

I like...

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

i am making program for uploading file in the database and i am facing error

input.jsp

inputcon.jsp

<%@ page language="java" contentType="text/html; charset=ISO-8859-1"
    pageEncoding="ISO-8859-1"%>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
<title>Insert title here</title>
</head>
<body>
<%@page import="java.sql.*"%>
//<%@page import="java.io.InputStream"%>
<%@page import="java.io.DataInputStream"%>
<%@page import="java.io.FileInputStream"%>
<%   FileInputStream fIn=null;

Connection conn = null;

PreparedStatement ps=null;

String filename=request.getParameter("fileName");

File f= new File(fileName);

String filepath=f.getAbsolutePath();

try

{
fIn = new FileInputStream(filepath);

Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
 conn=DriverManager.getConnection("jdbc:odbc:staffing");

ps=conn.prepareStatement("insert into J_C_File values(?)");

ps.setBinaryStream(1,fIn,(int)f.length());

ps.executeUpdate();

conn.close();

out.println("file submitted sucessfully");

}

catch(SQLException e)
                  {

out.println(e);
                  }

%>
</body>
</html>

error is coming @ following line

please help me in solving this

Maneesh Godbole

Bartender

Posts: 11497

I like...

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Megha Singhal wrote:error is coming @ following line

So you want to tell us what the error is or is it top secret? Please read =>TellTheDetails

[How to ask questions] [Donate a pint, save a life!] [Onff-turn it on!]

E Armitage

Rancher

Posts: 989

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

1.) Did you import the java.io.File class first before using it?
2.) You should the error message if you get an error and only post if you didn't understand the error.
3.) Do not write Java processing logic in JSPs. Use a servlet for that. JSPs should only be used for presentation.
4.) Do not use the odbc driver. Find a jdbc driver from your database manufacturer and use that.
5.) Always close statements and connections in the finally block of a try/catch.

Megha Singhal

Ranch Hand

Posts: 225

I like...

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

error is "fileName cannot be resolved".

E Armitage

Rancher

Posts: 989

posted 8 years ago

1
Number of slices to send:

Optional 'thank-you' note:

Send

So check in the code. Java is case sensitive so filename is not the same as fileName. Also see the other suggestions above.

Pramod Kumar Pandey

Ranch Hand

Posts: 52

I like...

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

actually in your code File f=new File(request.getParameter("fileName")); the value of argument is null.
when you use <input type="file"> you will not able to get the data from that page using request.getParameter(String) otherwise you will get null . you have to follow some instruction as follows :
1.> you will have to write enctype="multipart/form-data" as an attribute in your <form > tag.
2. when you will have to get tha data first you will have to check that field was type file or type text, because now there are two type of data is coming from that page text & file.
3. you will have to add two jars to your project Library named commons-fileupload-1.2.2.jar and commons-io-2.4.jar jars version may be changed.

may be following code would help.

/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */
package com.image;

import java.io.File;
import java.io.IOException;
import java.io.PrintWriter;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.commons.fileupload.FileItem;
import org.apache.commons.fileupload.FileItemFactory;
import org.apache.commons.fileupload.disk.DiskFileItemFactory;
import org.apache.commons.fileupload.servlet.ServletFileUpload;

/**
 *
 * @author pramod
 */
public class UploadImage extends HttpServlet {

//  other type  would be handled here 
                       String name=item.getFieldName();
                        value=item.getString();
                         al=new ArrayList<String> ();
                        al.add(value);
                       // we can add This value to an ArrayList. 
                   }
                   else{

// whose type is file would be haldled like this 
                       String name=item.getName();
                       
                   }
               }
        }catch(Exception e){
            out.print(e.getMessage());
        }
        finally {            
            
        }
    }

// <editor-fold defaultstate="collapsed" desc="HttpServlet methods. Click on the + sign on the left to edit the code.">
    /** 
     * Handles the HTTP <code>GET</code> method.
     * @param request servlet request
     * @param response servlet response
     * @throws ServletException if a servlet-specific error occurs
     * @throws IOException if an I/O error occurs
     */
    @Override
    protected void doGet(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        processRequest(request, response);
    }

/** 
     * Handles the HTTP <code>POST</code> method.
     * @param request servlet request
     * @param response servlet response
     * @throws ServletException if a servlet-specific error occurs
     * @throws IOException if an I/O error occurs
     */
    @Override
    protected void doPost(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        processRequest(request, response);
    }

/** 
     * Returns a short description of the servlet.
     * @return a String containing servlet description
     */
    @Override
    public String getServletInfo() {
        return "Short description";
    }// </editor-fold>
}

and my jsp page was as follow :

Megha Singhal

Ranch Hand

Posts: 225

I like...

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

following error is coming for the above code

HTTP Status 500 -

--------------------------------------------------------------------------------

type Exception report

message

description The server encountered an internal error () that prevented it from fulfilling this request.

exception

javax.servlet.ServletException: Wrapper cannot find servlet class upload.UploadImage or a class it depends on
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
java.lang.Thread.run(Unknown Source)

root cause

java.lang.ClassNotFoundException: upload.UploadImage
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1360)
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1206)
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
java.lang.Thread.run(Unknown Source)

note The full stack trace of the root cause is available in the Apache Tomcat/6.0.16 logs.

--------------------------------------------------------------------------------

Apache Tomcat/6.0.16

How can i remove this?

E Armitage

Rancher

Posts: 989

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Make sure that the class upload.UploadImage (or the jar file containing that class) is part of the war file you are deploying.

Ulf Dittmer

Rancher

Posts: 43028

posted 8 years ago

1
Number of slices to send:

Optional 'thank-you' note:

Send

The above code does not have a class "upload.UploadImage" - did you make any changes to it?

Also note that that this bad example code, as it treats GET and POST interchangeably - which violates the HTTP specification. Don't ever do that, no matter how many servlet tutorials show that.

Megha Singhal

Ranch Hand

Posts: 225

I like...

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Ulf Dittmer wrote:The above code does not have a class "upload.UploadImage" - did you make any changes to it?

Also note that that this bad example code, as it treats GET and POST interchangeably - which violates the HTTP specification. Don't ever do that, no matter how many servlet tutorials show that.

ok i'll remove override methods. and i am doing programming in eclipse so upload is project name so that's why i am using "upload.UploadImage"

Pramod Kumar Pandey

Ranch Hand

Posts: 52

I like...

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Megha upload.UploadImage does not mean upload is your project Name and UploadImage is Servlet

but upload mean package name in which you'll put the UploadImage servlet. just try gud luck :thumbup:

Megha Singhal

Ranch Hand

Posts: 225

I like...

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

HTTP Status 500 -

--------------------------------------------------------------------------------

type Exception report

message

description The server encountered an internal error () that prevented it from fulfilling this request.

exception

javax.servlet.ServletException: Error instantiating servlet class UploadImage
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
java.lang.Thread.run(Unknown Source)

root cause

java.lang.NoClassDefFoundError: org/apache/commons/fileupload/FileItemFactory
java.lang.Class.getDeclaredConstructors0(Native Method)
java.lang.Class.privateGetDeclaredConstructors(Unknown Source)
java.lang.Class.getConstructor0(Unknown Source)
java.lang.Class.newInstance0(Unknown Source)
java.lang.Class.newInstance(Unknown Source)
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
java.lang.Thread.run(Unknown Source)

root cause

java.lang.ClassNotFoundException: org.apache.commons.fileupload.FileItemFactory
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1360)
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1206)
java.lang.Class.getDeclaredConstructors0(Native Method)
java.lang.Class.privateGetDeclaredConstructors(Unknown Source)
java.lang.Class.getConstructor0(Unknown Source)
java.lang.Class.newInstance0(Unknown Source)
java.lang.Class.newInstance(Unknown Source)
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
java.lang.Thread.run(Unknown Source)

note The full stack trace of the root cause is available in the Apache Tomcat/6.0.16 logs.

--------------------------------------------------------------------------------

Apache Tomcat/6.0.16

now i remove "upload" from UploadImage in web.xml now the above error is coming.

Ulf Dittmer

Rancher

Posts: 43028

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Apparently the jar files of the required libraries are not in WEB-INF/lib.

Megha Singhal

Ranch Hand

Posts: 225

I like...

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Ulf Dittmer wrote:Apparently the jar files of the required libraries are not in WEB-INF/lib.

jar files are in the library, i externally added both the jar files.

Ulf Dittmer

Rancher

Posts: 43028

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

To both the compile-time and runtime paths? If you're using an IDE, those can be different, and you need them in both.

Megha Singhal

Ranch Hand

Posts: 225

I like...

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Ulf Dittmer wrote:To both the compile-time and runtime paths? If you're using an IDE, those can be different, and you need them in both.

This code is running now.
but where is the file uploading?

Ulf Dittmer

Rancher

Posts: 43028

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

In whichever JSP/HTML page you implemented it. You already had such a page, and Pramod also posted one.

Pramod Kumar Pandey

Ranch Hand

Posts: 52

I like...

posted 8 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

hello Megha now i m giving you the whole code ...but before it you just clean and build your project ... and in the project directory on your disk...within the dist/web/ create an folder named images where your images will be uploaded ...and then run my full code.
my jsp is

and servlet is

/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */
package com.image;

/**
 *
 * @author pramod
 */
public class UploadImage extends HttpServlet {

/** 
     * Processes requests for both HTTP <code>GET</code> and <code>POST</code> methods.
     * @param request servlet request
     * @param response servlet response
     * @throws ServletException if a servlet-specific error occurs
     * @throws IOException if an I/O error occurs
     */
    protected void processRequest(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        response.setContentType("text/html;charset=UTF-8");
        PrintWriter out = response.getWriter();
        try {
               FileItemFactory fi=new DiskFileItemFactory();
               ServletFileUpload upload=new ServletFileUpload(fi);
               List list=null;
               try{
                   list=upload.parseRequest(request);
               }
               catch(Exception e){
                   out.print(e.getMessage());
               }
               Iterator it=list.iterator();
               ArrayList<String> al=null;
               while(it.hasNext()){
                   FileItem item=(FileItem)it.next();
                   String value=null;
                   
                   if(item.isFormField()){
                       String name=item.getFieldName();
                        value=item.getString();
                         al=new ArrayList<String> ();
                        al.add(value);
                       // we can add This value to an ArrayList. 
                   }
                   else{
                       String name=item.getName();
                       int index=name.lastIndexOf('.');
                       String domainName=name.substring(index);
                       domainName=al.get(0).trim().concat(domainName);
                       File file=new File(getServletContext().getRealPath("images/"+domainName));
                       item.write(file);
                       out.print("<html><body><img src='images/"+domainName+"' height='200px' width='200px'/></body></html>");
                   }
               }
        }catch(Exception e){
            out.print(e.getMessage());
        }
        finally {            
            
        }
    }

pie. tiny ad:

Building a Better World in your Backyard by Paul Wheaton and Shawn Klassen-Koop

https://coderanch.com/wiki/718759/books/Building-World-Backyard-Paul-Wheaton