Get ListView checkbox ID and item ID

[ibrahim yener]

Hello

I have a custom list and i want all checked items' ID, don't know why but all i have ordered number when onclicked item and non of checkbox id.

Thanks for any help.

This is my adapter :

public class CustomListAdapter extends ArrayAdapter<CustomListView>
{
	private Context			context;
	private int				resource;
	private CustomListView[]	data	= null;
	private int[] 			checkBoxState;

	public CustomListAdapter(Context context, int resource,
			CustomListView[] objects)
	{
		super(context, resource, objects);
		this.context	= context;
		this.resource	= resource;
		this.data		= objects;
	}

	@Override
	public View getView(final int position, View convertView, ViewGroup parent)
	{
		View row 			 = convertView;
		CustomObjects holder = null;
		
		if(row == null)
		{
			LayoutInflater inflater = ((Activity) context).getLayoutInflater();
			row = inflater.inflate(resource, parent, false);
			
			holder = new CustomObjects();
			
			holder.cb = (CheckBox) row.findViewById(R.id.listview_chkBox);
			holder.tw = (TextView) row.findViewById(R.id.listview_serverName);
			holder.dt = (TextView) row.findViewById(R.id.listview_checkDate);
			holder.im = (ImageView) row.findViewById(R.id.listview_chkResult);
			
			row.setTag(holder);
			
		}
		else
		{
			holder = (CustomObjects) row.getTag();
		}
		
		final CustomListView lists = data[position];
		
		holder.tw.setText(lists.getServername());
		holder.dt.setText(lists.getLastchecked());
		
		if(lists.isOk() == true)
		{
			holder.im.setImageDrawable(context.getResources().getDrawable(R.drawable.chk_ok));
		}
		else
		{
			holder.im.setImageDrawable(context.getResources().getDrawable(R.drawable.chk_ng));
		}
		
		holder.cb.setOnClickListener(new View.OnClickListener()
		{
			
			@Override
			public void onClick(View v)
			{
				if(((CompoundButton) v).isChecked())
				{
					// Add to checkbox array
				}
				else
				{
					// Remove from checkbox array
				}
			}
		});
		
		return row;
	}
	
	public class CustomObjects
	{
		CheckBox	cb;
		TextView 	tw;
		TextView	dt;
		ImageView 	im;
		String		id;
	}
}

And this is my activity :

@Override
	protected void onCreate(Bundle savedInstanceState)
	{
		super.onCreate(savedInstanceState);
		requestWindowFeature(Window.FEATURE_NO_TITLE);
		setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT);
		setContentView(R.layout.custom_list);
		
		lv = (ListView) findViewById(R.id.list_ListView);
		
		//	Hide Action Bar
		add 	= (ImageView) findViewById(R.id.btn_actionBarAdd);
		edit 	= (ImageView) findViewById(R.id.btn_actionBarEdit);
		delete 	= (ImageView) findViewById(R.id.btn_actionBarDelete);
		setting	= (ImageView) findViewById(R.id.btn_actionBar);
		
		add.setVisibility(View.INVISIBLE);
		edit.setVisibility(View.INVISIBLE);
		delete.setVisibility(View.INVISIBLE);
		setting.setVisibility(View.INVISIBLE);
		
		//	Set new Database Connection
		db = new DatabaseConnection(this).getReadableDatabase();
		c  = db.rawQuery("SELECT COUNT (_id) FROM dbItems", null);
		c.moveToFirst();
		
		if(c.getInt(0) > 0)
		{
			db.query("dbItems", tableCols, null, null, null, null, orderBy);
			c.moveToFirst();
			
			CustomListView lists[] = {
					new CustomListView("Test", 1, "2006/05/20 19:00", true), // DUMMY
					new CustomListView("Test2", 2, "1977/05/20 19:00", false), // DUMMY
					new CustomListView("Test3", 3, "1970/05/20 19:00", false) // DUMMY
			};
			
			CustomListAdapter adapter = new CustomListAdapter(this, R.layout.listview_rows, lists);
			lv.setAdapter(adapter);
			
			lv.setOnItemClickListener(new OnItemClickListener(){

				@Override
				public void onItemClick(AdapterView<?> arg0, View arg1,
						int arg2, long arg3)
				{
					Toast.makeText(getApplicationContext(), "" + arg2, Toast.LENGTH_SHORT).show();
					// Where is god damn ID ?
				}
				
			});
		}
		else
		{
			//	Show Error message
		}
	}

[Steve Luke]

ibrahim yener wrote:Hello

I have a custom list and i want all checked items' ID, don't know why but all i have ordered number when onclicked item and non of checkbox id.

I am having a hard time interpreting what this means. But here is what I think it means, based on the code:

"I have a custom view that has a checkbox in it and that I add to a ListView. I have an onItemListClick() listener attached to the ListView. When I get the event for onItemClicked, I get the position of the custom view the user clicked on, not the ID of the checkbox. How do I get the ID of the checkbox?"

Getting the position of the clicked-on row is what you are supposed to get, see the API: http://developer.android.com/reference/android/widget/AdapterView.OnItemClickListener.html. And if you think about it, it should make sense:
1- Your clicked on item in the ListView is the custom view - your custom view can have many ids. How is the framework supposed to know which view's id you want?
2- The item you are clicking on, relative to this event, is the custom view, not the checkbox
3- A ListView uses an adapter and the adapter often builds the view that gets displayed rather than getting from an XML file, so any given view in the ListView may not have an ID.
4- A ListView recycles its views, you may have multiple views on the screen with the same ID because they came from the same layout, and one instance of the view may be used to display multiple different rows as you scroll through the list (views that go invisible will be reused to view those rows that come into view). So providing just the View doesn't completely tell the story, you need to know the position in the greater context of the underlying data.

You can get the checkbox view for a given row by doing the findViewById() method on the view argument passed to the onItemClickListener(). But that is not (only) how you should track which items are checked and which ones are not since those checkboxes may be reused (they are not reliable datastorage, they are view). Rather, you should store the state inside the adapter and create a method which you can use to toggle the internal state of that row in the adapter (then update the view to reflect the state).

For example, in your adapter create a boolean array that defines the selected/not selected state for each data element. Create a method that takes the position of the element to toggle its state and the view for the row. In the method toggle the value inside the boolean array, then get the tag for the row's view, get the checkbox from the tag, and set its state to the same as in the boolean array. In your onItemClick() method, call this new method on your adapter.

ibrahim yener wrote:Thanks for any help.

This is my adapter :

public class CustomListAdapter extends ArrayAdapter<CustomListView>
{
	private Context			context;
	private int				resource;
	private CustomListView[]	data	= null;
	private int[] 			checkBoxState;

	public CustomListAdapter(Context context, int resource,
			CustomListView[] objects)
	{
		super(context, resource, objects);
		this.context	= context;
		this.resource	= resource;
		this.data		= objects;
	}

	@Override
	public View getView(final int position, View convertView, ViewGroup parent)
	{
		View row 			 = convertView;
		CustomObjects holder = null;
		
		if(row == null)
		{
			LayoutInflater inflater = ((Activity) context).getLayoutInflater();
			row = inflater.inflate(resource, parent, false);
			
			holder = new CustomObjects();
			
			holder.cb = (CheckBox) row.findViewById(R.id.listview_chkBox);
			holder.tw = (TextView) row.findViewById(R.id.listview_serverName);
			holder.dt = (TextView) row.findViewById(R.id.listview_checkDate);
			holder.im = (ImageView) row.findViewById(R.id.listview_chkResult);
			
			row.setTag(holder);
			
		}
		else
		{
			holder = (CustomObjects) row.getTag();
		}
		
		final CustomListView lists = data[position];
		
		holder.tw.setText(lists.getServername());
		holder.dt.setText(lists.getLastchecked());
		
		if(lists.isOk() == true)
		{
			holder.im.setImageDrawable(context.getResources().getDrawable(R.drawable.chk_ok));
		}
		else
		{
			holder.im.setImageDrawable(context.getResources().getDrawable(R.drawable.chk_ng));
		}
		
		holder.cb.setOnClickListener(new View.OnClickListener()
		{
			
			@Override
			public void onClick(View v)
			{
				if(((CompoundButton) v).isChecked())
				{
					// Add to checkbox array
				}
				else
				{
					// Remove from checkbox array
				}
			}
		});
		
		return row;
	}
	
	public class CustomObjects
	{
		CheckBox	cb;
		TextView 	tw;
		TextView	dt;
		ImageView 	im;
		String		id;
	}
}

And this is my activity :

@Override
	protected void onCreate(Bundle savedInstanceState)
	{
		super.onCreate(savedInstanceState);
		requestWindowFeature(Window.FEATURE_NO_TITLE);
		setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT);
		setContentView(R.layout.custom_list);
		
		lv = (ListView) findViewById(R.id.list_ListView);
		
		//	Hide Action Bar
		add 	= (ImageView) findViewById(R.id.btn_actionBarAdd);
		edit 	= (ImageView) findViewById(R.id.btn_actionBarEdit);
		delete 	= (ImageView) findViewById(R.id.btn_actionBarDelete);
		setting	= (ImageView) findViewById(R.id.btn_actionBar);
		
		add.setVisibility(View.INVISIBLE);
		edit.setVisibility(View.INVISIBLE);
		delete.setVisibility(View.INVISIBLE);
		setting.setVisibility(View.INVISIBLE);
		
		//	Set new Database Connection
		db = new DatabaseConnection(this).getReadableDatabase();
		c  = db.rawQuery("SELECT COUNT (_id) FROM dbItems", null);
		c.moveToFirst();
		
		if(c.getInt(0) > 0)
		{
			db.query("dbItems", tableCols, null, null, null, null, orderBy);
			c.moveToFirst();
			
			CustomListView lists[] = {
					new CustomListView("Test", 1, "2006/05/20 19:00", true), // DUMMY
					new CustomListView("Test2", 2, "1977/05/20 19:00", false), // DUMMY
					new CustomListView("Test3", 3, "1970/05/20 19:00", false) // DUMMY
			};
			
			CustomListAdapter adapter = new CustomListAdapter(this, R.layout.listview_rows, lists);
			lv.setAdapter(adapter);
			
			lv.setOnItemClickListener(new OnItemClickListener(){

				@Override
				public void onItemClick(AdapterView<?> arg0, View arg1,
						int arg2, long arg3)
				{
					Toast.makeText(getApplicationContext(), "" + arg2, Toast.LENGTH_SHORT).show();
					// Where is god damn ID ?
				}
				
			});
		}
		else
		{
			//	Show Error message
		}
	}

[ibrahim yener]

Dear Steve
Sorry for giving you hard time, also thanks for reply.

I have followed your suggestion and solved problem.
I am in the office now, i will post solution when i back to home.

Thank you for your help.