scrollPane not quite working as expected

[Jenn Terry]

Hi guys,

I am trying to get a scrollPane working correctly, but not having any luck. The picture drawn in the center panel is quite large and goes off the screen. I visited http://docs.oracle.com/javase/tutorial/uiswing/components/scrollpane.html but I am missing something vital. Both tracks show, but there is no knob to do the scrolling. What am I doing wrong?

public DViewer() {
		super();

		frame = new JFrame();

		frame.setSize(Toolkit.getDefaultToolkit().getScreenSize());
		frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
		

		dDPanel = new JPanel(new BorderLayout());
		dDPanel.add(new UDInput(), BorderLayout.NORTH);
		dDPanel.add(new USOptions(), BorderLayout.WEST);
		dDPanel.add(new SView(), BorderLayout.SOUTH);

		frame.add(dDPanel);
		frame.setVisible(true);

		DComponent centerComponent = new DComponent();
		Dimension preferredSize = centerComponent.getPreferredSize();
		JScrollPane scrollPane = new JScrollPane(centerComponent);
		scrollPane.setPreferredSize(preferredSize);
		scrollPane
				.setHorizontalScrollBarPolicy(JScrollPane.HORIZONTAL_SCROLLBAR_ALWAYS);
		scrollPane
				.setVerticalScrollBarPolicy(JScrollPane.VERTICAL_SCROLLBAR_ALWAYS);
		//Show no boarder around panel
		scrollPane.setBorder(BorderFactory.createEmptyBorder(20, 20, 20, 20));
		
        dDPanell.add(scrollPane, BorderLayout.CENTER);

		frame.revalidate();
		frame.repaint();
	}

}

[R. Ramage]

The only reason I can think of that you bars aren't showing is that the object inside isn't bigger than the scroll pane viewable area. If you mean the arrow buttons on the scroll bar aren't showing then that is a look and feel issue. Can you see the image in the scroll pane but you still aren't seeing the bars? I mocked up your code here:

public static void main(String[] args)
    {
        JFrame frame = new JFrame();
        frame.setSize(Toolkit.getDefaultToolkit().getScreenSize());
        frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
        frame.setLayout(new BorderLayout());

        frame.setVisible(true);
        JPanel centerComponent = new JPanel();
        //        panel.setPreferredSize(new Dimension(800, 800));
        centerComponent.setPreferredSize(new Dimension(10000, 10000));
        JScrollPane scrollPane = new JScrollPane(centerComponent);
        scrollPane.setPreferredSize(centerComponent.getPreferredSize());
        scrollPane.setHorizontalScrollBarPolicy(ScrollPaneConstants.HORIZONTAL_SCROLLBAR_ALWAYS);
        scrollPane.setVerticalScrollBarPolicy(ScrollPaneConstants.VERTICAL_SCROLLBAR_ALWAYS);
        scrollPane.setBorder(BorderFactory.createEmptyBorder(20, 20, 20, 20));
        frame.add(scrollPane, BorderLayout.CENTER);
        frame.validate();
        frame.repaint();
    }

If i change the panels size to 800 the scroll bars don't show. The only difference is I'm using ScrollPaneConstants for the scroll policy's instead of JScrollPane, and I don't have your other objects.

[Jenn Terry]

@R. Ramage: That has scrolling working, but is there a way getting the component size and creating a panel.setPreferredSize() based on those dimensions? The size of the item in the center pane is variable in size, leaving a lot of empty space at times.

[R. Ramage]

Since you're using BorderLayout setting the size of the scroll pane isn't going to do anything. Using border layout will base it's size on the container. If you use a different layout you can work with the sizing better.

[Rob Camick]

is there a way getting the component size and creating a panel.setPreferredSize() based on those dimensions?

You should NOT be playing with the preferred size of components. It is the job of each component to determine its own preferred size so that scrolling will work properly.

The idea of using a scrollpane is to let it adjust automatically as the user resizes the frame. As the frame is resized large the scrollbars shrink or disappear. As the frame is resized smaller the scrollbars appear or increase in size.

[R. Ramage]

Maybe I misread the question but I didn't think we were trying to reset the preferred size of the components within but the size of the scroll pane. Yes in my example I did change the preferred size of the component within but that was just to show the scroll bars appearing if it's too large for the viewport, and to try and diagnose why it wasn't working. It wasn't meant to be a suggested practice. Sorry if there was confusion on that.

[Jenn Terry]

So far, the only way this has worked was by manually setting the preferred sizes (I had to use both). If this is not recommended, I am back to my original question of what is wrong with the above code?

[Rob Camick]

what is wrong with the above code?

DComponent centerComponent = new DComponent();  

Above is the component that is added to the viewport of the scrollpane. Do NOT set its preferred size.

If this is a custom component then you should be overriding the getPreferredSize() method of the component to return an appropriate value.

If this is just a custom container holding other components, then use a proper layout manager and the layout manager will calculate the preferred size.

Post a proper SSCCE if you need more help because we can't guess what you are actually doing.

[Jenn Terry]

Unfortunately, I can not post the code in a public forum as it does not belong to me.

The center component dynamically changes depending depending on user input and can go anywhere from a small constructed set of rectangle that fits quite nicely without scroll bars to a quite huge set of rectangle of unknown quantity at least double the size of the viewable screen.

[R. Ramage]

The middle component, are you rendering an image to a JPanel? I guess the question is what does DComponent extend?

[Jenn Terry]

DComponent extends JComponent.

[R. Ramage]

Does the size vary based on things that a user is doing in the frame or does it depend on information given at startup? Based on your first post I kind of perceive this as an image viewer of sorts.

[Jenn Terry]

The DComponent is a series of rectangles put together to represent a floor plan. The initial drawing is based on a user inputed exterior dimensions located in the North panel. They can update the drawing at any time by entering new dimensions and hitting update located in the north panel. The west panel provides updated information. The south panel changes other items of the picture.

[R. Ramage]

After the user updates the dimensions and the new image is rendered try calling revalidate and repaint on the middle component. Also do away with setting its preferred size. Try that and let me know.

[Jenn Terry]

It made no difference.

[R. Ramage]

Sorry Jenn. Hopefully this will at least point you in the right direction. Without seeing the code for the component I can only really guess at this.

This has a button on top that increases the size of the rectangle drawn in the JComponent. Where ever it is that you're updating the number and sizes of rectangles added you just need to compute the new preferred size, revalidate, and repaint. As the size of the rectangle exceeds the scroll pane the bars show up.

public class ScrollTest extends JComponent
{
    private int width = 10;
    private int height = 10;

    public static void main(String[] args)
    {
        final JFrame frame = new JFrame();
        final ScrollTest comp = new ScrollTest();
        frame.setSize(Toolkit.getDefaultToolkit().getScreenSize());
        frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
        frame.setLayout(new BorderLayout());
        frame.setVisible(true);
        JButton button = new JButton();
        button.addActionListener(new ActionListener()
        {
            @Override
            public void actionPerformed(ActionEvent arg0)
            {
                comp.increaseSize();
            }
        });
        final JScrollPane scrollPane = new JScrollPane(comp);
        scrollPane.setHorizontalScrollBarPolicy(ScrollPaneConstants.HORIZONTAL_SCROLLBAR_ALWAYS);
        scrollPane.setVerticalScrollBarPolicy(ScrollPaneConstants.VERTICAL_SCROLLBAR_ALWAYS);
        scrollPane.setBorder(BorderFactory.createEmptyBorder(20, 20, 20, 20));
        frame.add(button, BorderLayout.NORTH);
        frame.add(scrollPane, BorderLayout.CENTER);
        frame.validate();
        frame.repaint();
        System.out.println(comp.getPreferredSize().width + " " + comp.getPreferredSize().height);
    }

    public void increaseSize()
    {
        width *= 5;
        height *= 5;
        setPreferredSize(new Dimension(width, height));
        revalidate();
        repaint();
    }

    @Override
    public void paintComponent(Graphics g)
    {
        super.paintComponent(g);
        g.drawRect(0, 0, width, height);
    }
}

I'm assuming the rectangles are preset sizes or that you can get the dimensions from user input.

[Jenn Terry]

I think I can make this, or a variation of this work. Thanks for your effort!

[R. Ramage]

Hopefully its enough to get you going. Good luck.

[Rob Camick]

No, that is NOT the way to solve the problem. Read all my comments.

You should NOT use the setPreferredSize() method. It is the responsibility of the component to determine its preferred size. This is done by overriding the getPreferredSize() method of the component. Only the component knows how many rectangles it need to paint etc. Therefore the getPreferredSize() method will use that information to return the appropriate size.

Also, it is the responsibility of the component to invoke revalidate() and repaint() whenever one of its properties changes.

When you invoke setText(...) on a JLabel or JTextField or JButton do you then change the preferred size and do revalidate() and repaint? No, because all that logic is part of the component so the application code doesn't have to remember to do it.

[Jenn Terry]

@Rob Camick: If you look at my line 19 from the original code, I was attempting to do the getPreferredSize(). I just didn't know how to apply it properly. Do you have any code suggestions to try? I've danced with this for about 5 hours. I've tried so many different things, I can't even remember what I've tried!

[Rob Camick]

I was attempting to do the getPreferredSize().

Where? I don't see where you are attempting to override the getPreferredSize() method? You override the getPreferredSize() method in your DComponent class since this is the class that does all the custom painting of your rectangles and whatever else it does.

I visited http://docs.oracle.com/javase/tutorial/uiswing/components/scrollpane.html

So did you download the demo code to see how it works? The ScrollablePanel class gives an example on overriding the getPreferredSize() method. Since you did not post a SSCCE showing what you are attempting to do, I can't give any advice on what the preferred size calculation should be for your component. The whole point of a SSCCE is to create a simple example. Unless you can learn to isolate problems you won't be able to debug your code.

[Jenn Terry]

If I didn't attempt to use it in the way you described, then I guess I do not understand what you are saying.

Yes I did look at the code. I crawled up and down it. Inside and out. tried what I seen, and got no where. That is when I came here looking for help. I'm obviously not getting it on my own. That was the whole purpose of asking for help, and telling the forum that I had explored the lessons prior to doing so.

I don't know how else to ask for help, but I am begging you, or some one else for it! I have tried so many things and spent so long on this one problem, that I am almost in tears. Never have I been stumped like this before.

Unless you can learn to isolate problems you won't be able to debug your code.

I guess I will be a crappy coder for the rest of my life then as I am totally stumped!

[Rob Camick]

I just told you where to specifically look for an example of how to override the getPOreferredSize() method. If was 7 minutes from my posting until your reply. You obviously did not take a second look at that code to try and understand it. You also have made no effort to post a SSCCE. I don't know what else I can do.

The basic rule of a scrollpane is that the scrollbars will appear automatically when the preferred size of the component added to the viewport of the scrollpane is greater than the size of the scrollpane. The original code you posted does not help us because the important part of the code is the getPreferredSize() method of your custom class which you did not post.

That is why I suggested you create a SSCCE. All you do is extend a JPanel and override the getPreferredSize() method to return a hard coded value. Then you add this component to a scrollpane and add the scrollpane to a frame. Then you resize the frame and see what happens as the frame grows/shrinks. Once you understand this basic concept, then you can implement a more complicated getPreferredSize() method that changes dynamically as properties of you component change. You have already been given a simple example of this approach although my comment was that the "increaseSize" methjod should be part of your component so that you update an internal variable to track the preferred size. Then the getPreferredSize() method can just return this variable.

Forget about your real program and create a SSCCE to learn the basics first.

[Jenn Terry]

I've gone back and played with various simple panel designs and had success getting the scrollPane to activate every time. As such, I deducted that the issue is specific to this particular program.

I removed all other panels to take those out of the mix, simplifying the program above as much as possible. I then removed the setSize() on the frame and switched to pack(). When I ran the program, the window that opened was as small as possible, only big enough to show the java icon, 2 resizing buttons, and the red x. When I stretched out the frame, the picture was there. That told me that Java was not seeing the size. I then decided it was time to pull up a console reading on that panel to confirm my suspicions. When I used System.out.println("Width: "+ centerComponent.getWidth()); and System.out.println("Height: "+ centerComponent.getHeight()); on the above program, I get the a dimension of the panel being height 0 by width 0.

So, I can now conclude that java jScrollPane will never work if it believes the panel is 0x0. That brings me to what ends up being the true issue. How do I get Java to see the drawn rectangles that are drawn from the constructor on another page?

[Rob Camick]

That brings me to what ends up being the true issue. How do I get Java to see the drawn rectangles that are drawn from the constructor on another page?

Already answered.

You override the getPreferredSize() method of your custom component.

Since you still refuse to post a SSCCE, that is a much help as we can give.

[Jenn Terry]

I will see if I can build something that simulates this issue. Everything else I have tried has always worked, so I will try to translate the code into a simulation of some sort.

[Jenn Terry]

Okay, this seems to recreate the error.

package design;

import java.awt.BorderLayout;

import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JScrollPane;

@SuppressWarnings("serial")
public class D_Viewer extends JFrame {

	public D_Viewer() {
		super();

		setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);

		JPanel panel = new JPanel(new BorderLayout());
		D_Component dDrawing = new D_Component();
		
		JScrollPane scrollPane = new JScrollPane(dDrawing);
		scrollPane.setPreferredSize(getPreferredSize());
		System.out.println("Width: " + dDrawing.getWidth());
		System.out.println("Height: " + dDrawing.getHeight());
		scrollPane
				.setHorizontalScrollBarPolicy(JScrollPane.HORIZONTAL_SCROLLBAR_AS_NEEDED);
		scrollPane
				.setVerticalScrollBarPolicy(JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED);
		
		panel.add(scrollPane, BorderLayout.CENTER);

		add(panel);
		pack();
		setVisible(true);
	}

	public static void main(String[] args) {
		D_Viewer panel = new D_Viewer();
		panel.isEnabled();
	}
}
}

package design;

import java.awt.Color;
import java.awt.Graphics;
import java.awt.Graphics2D;
import java.util.ArrayList;

import javax.swing.JComponent;

@SuppressWarnings("serial")
public class D_Component extends JComponent {

	private static final float lineThickness = 10;
	private static final int startY = 20;
	private static final int startX = 20;
	private static final int MULTIPLIER = 20;
	private ArrayList<Rectangle> stackedRectangles = new ArrayList<Rectangle>();
	private int newY = 0;
	private int currentNumberOfRows = 10;
	private int length1 = 8;
	private int bWidth = 6;
	private int drawWidth = (bWidth * MULTIPLIER);
	private Color dColor;

	public D_Component() {

		// Rectangles for stack
		for (int i = 0; i < currentNumberOfRows; i++) {
			// Rectangle(x, y, length, height, line thickness, boolean fill,
			// boolean dash line);
			stackedRectangles.add(new Rectangle(startX, (startY + newY),
					dimensionConv(length1), drawWidth, lineThickness, true,
					false));
			newY += drawWidth;
		}
	}

	private int dimensionConv(int dim1) {
		return ((dim1 * 15) * MULTIPLIER);
	}

	public void paintComponent(Graphics g) {
		Graphics2D g2 = (Graphics2D) g;

		for (Rectangle r : stackedRectangles) {
			dColor = Color.RED;
			r.setColor(dColor);
			r.draw(g2);
		}
	}
}

package design;

import java.awt.BasicStroke;
import java.awt.Color;
import java.awt.Graphics2D;
import java.awt.Stroke;
import java.awt.geom.Rectangle2D;

public class Rectangle {
	private double x;
	private double y;
	private double rectWidth;
	private double rectHeight;
	private float brushStroke;
	private boolean fill;
	private boolean dottedLine;
	private Color color;

	public Rectangle(double x, double y, double w, double h, float thick,
			boolean fill, boolean dotted) {
		this.x = x;
		this.y = y;
		this.rectWidth = w;
		this.rectHeight = h;
		this.brushStroke = thick;
		this.fill = fill;
		this.dottedLine = dotted;
		this.color = Color.BLACK;
	}

	public void setColor(Color aColor) {
		color = aColor;
	}

	public void draw(Graphics2D g2) {
		// check that sizes are above 0
		if ((rectWidth <= 0) || (rectHeight <= 0))
			return;

		g2.setColor(color);
		// draw the rectangle 
		Rectangle2D.Double rectangle = new Rectangle2D.Double(x, y, rectWidth,
				rectHeight);
		if (!dottedLine) {
			// set stroke width
			g2.setStroke(new BasicStroke(brushStroke));
		} else {
			Stroke dotted = new BasicStroke(brushStroke, BasicStroke.CAP_BUTT,
					BasicStroke.JOIN_BEVEL, 0, new float[] { 10, 4 }, 0);
			g2.setStroke(dotted);
		}

		g2.draw(rectangle);
		if (fill) {
			g2.fill(new Rectangle2D.Double(x, y, rectWidth, rectHeight));
			g2.setColor(Color.BLACK);
			g2.draw(rectangle);
		}
	}
}

[Paul Clapham]

        scrollPane.setPreferredSize(getPreferredSize());  

Here you try to set the scroll pane's preferred size to be the same as the JFrame's preferred size, if I'm not mistaken. But you do that before pack() is called, so at that point the JFrame doesn't have a preferred size.

And I don't see anything else with a preferred size, so (without trying to run your code and without going back to read the whole thread -- sorry!) I guess you're going to end up with a tiny JFrame with only a border and no contents. The JFrame just gets made large enough to contain the components you put in it, based on their preferred size. Don't you have a preferred size for anything? You don't have a choice for how big a D_Component ought to be, for example?

[Jenn Terry]

I tried moving pack() around and it is the same result. Originally, I had the program setting the frame to the size of the screen. The jScrolls still would not activate. Since the D_Component is reporting a size of 0x0, this would make sense. The problem with D_Component is, in the real program, the user is constantly changing the size of the rectangles (This is an extremely stripped version of the program that in reality is calling on 13 different constructor classes to draw out everything that must be drawn). I just used this as an example code that end up simulating accurately the conditions that were causing me problems.

[Rob Camick]

For the 3rd time, where do you implement the getPreferredSize() method in you D_Component method?

I have no idea if this is the only problem with your code but I sure am not going to take the time to test your code until you show you have made an effort to follow suggestions given.

What is the point of asking a question when you don't even make an effort to follow the suggestion?

[Jenn Terry]

Deleted

[Jenn Terry]

Deleted

[Jenn Terry]

Deleted

[Jenn Terry]

Deleted

[Jenn Terry]

Deleted

[Scotty Steven]

Rob Camick:

This girl is obviously not understanding what you are saying. It might be beyond her knowledge level. I think that is why she came here looking for help and asking questions. Would it really hurt you after a week to maybe put out a little extra effort and give her the answer that you obviously already know? Why would you ask her to post code if you were just going to tell her off after doing as you ask? I'd help, but I just started reading this forum trying to learn swing myself and for sure know less then her.

[Scotty Steven]

Jenn Terry: I reread this thread and if I understand what Rob is saying, you somehow have to create a way for the Component class to figure out it's own size and pass those sizes to the Viewer class. Maybe you could just add up all of the x and y axis starting and stop points and make them public variables? If you can't figure out how to make it work with Robs way, then you could manually set those values using the method that R. Ramage posted since you said it kind of worked. I hope this helps.

[Jenn Terry]

@Scotty Steven Yes, I was able to get @R. Ramage way to work before but @Rob Camick made it seem that this was the wrong thing to do. I thought it might be a good skill to learn. I just can't figure out how to make it work so I will probably just go back to @R. Ramage method. I don't know why @Rob Camick would ask me in almost every post he made to post SSCCE and then not be willing to work with it. There is no logic to it at all.

Thanks for trying to help.

[Scotty Steven]

What about adding the following to the D_Component class

public Dimension getPreferredSize() {
    return new Dimension(500, 500);//or whatever you need-->maybe set up a separate method to calculate these values as they change so that they are ready when called.
}

In the D_Viewer class change line 21 to

scrollPane.getPreferredSize();

or if that doesn't work,

dDrawing.getPreferredSize();

I haven't tried it on your code, but some research at this link makes me feel this could work.

[Jenn Terry]

@Scotty Steven

I tried both suggestions you made. The window now opens at 500x500 using either method, but the component console size printout is still showing 0x0 and the jScrollPane is still not there. At least something is happening. Here is where I am.

package design;

import java.awt.BorderLayout;

import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JScrollPane;

@SuppressWarnings("serial")
public class D_Viewer extends JFrame {

	public D_Viewer() {
		super();

		setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);

		JPanel panel = new JPanel(new BorderLayout());
		D_Component dDrawing = new D_Component();
		
		//pack();
		dDrawing.getPreferredSize();
		JScrollPane scrollPane = new JScrollPane(dDrawing);
		//scrollPane.getPreferredSize();
		System.out.println("Width: " + dDrawing.getWidth());
		System.out.println("Height: " + dDrawing.getHeight());
		scrollPane
				.setHorizontalScrollBarPolicy(JScrollPane.HORIZONTAL_SCROLLBAR_AS_NEEDED);
		scrollPane
				.setVerticalScrollBarPolicy(JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED);
		
		panel.add(scrollPane, BorderLayout.CENTER);

		add(panel);
		panel.getPreferredSize();
		pack();
		setVisible(true);
	}

	public static void main(String[] args) {
		D_Viewer panel = new D_Viewer();
		panel.isEnabled();
	}
}

package design;

import java.awt.Color;
import java.awt.Dimension;
import java.awt.Graphics;
import java.awt.Graphics2D;
import java.util.ArrayList;

import javax.swing.JComponent;

@SuppressWarnings("serial")
public class D_Component extends JComponent {

	private static final float lineThickness = 10;
	private static final int startY = 20;
	private static final int startX = 20;
	private static final int MULTIPLIER = 20;
	private ArrayList<Rectangle> stackedRectangles = new ArrayList<Rectangle>();
	private int newY = 0;
	private int currentNumberOfRows = 10;
	private int length1 = 8;
	private int bWidth = 6;
	private int drawWidth = (bWidth * MULTIPLIER);
	private Color dColor;

	public D_Component() {

		// Rectangles for stack
		for (int i = 0; i < currentNumberOfRows; i++) {
			// Rectangle(x, y, length, height, line thickness, boolean fill,
			// boolean dash line);
			stackedRectangles.add(new Rectangle(startX, (startY + newY),
					dimensionConv(length1), drawWidth, lineThickness, true,
					false));
			newY += drawWidth;
		}
	}

	private int dimensionConv(int dim1) {
		return ((dim1 * 15) * MULTIPLIER);
	}

	public void paintComponent(Graphics g) {
		Graphics2D g2 = (Graphics2D) g;

		for (Rectangle r : stackedRectangles) {
			dColor = Color.RED;
			r.setColor(dColor);
			r.draw(g2);
		}
	}
	
	public Dimension getPreferredSize() {
	    return new Dimension(500, 500);//or whatever you need-->maybe set up a separate method to calculate these values as they change so that they are ready when called.
	}
}