Pick four cards (GUI) Problems

[gabriel terry]

(Pick four cards) Write a program that lets the user click the Refresh button to display
four cards from a deck of 52 cards, as shown in Figure 16.21a. (Hint: See
Listing 6.2 on how to draw four cards randomly.)


I have a problem.The "refresh" button does nothing.Any ideea?

public class DeckOfCards extends JFrame
{
	

	private static ImageIcon image1 = new ImageIcon("images/1.png");
	private static ImageIcon image2 = new ImageIcon("images/2.png");
	private static ImageIcon image3 = new ImageIcon("images/3.png");
	private static ImageIcon image4 = new ImageIcon("images/4.png");
	private static ImageIcon image5 = new ImageIcon("images/5.png");
	private static ImageIcon image6 = new ImageIcon("images/6.png");
	private static ImageIcon image7 = new ImageIcon("images/7.png");
	private static ImageIcon image8 = new ImageIcon("images/8.png");
	private static ImageIcon image9 = new ImageIcon("images/9.png");
	private static ImageIcon image10 = new ImageIcon("images/10.png");
	private static ImageIcon image11 = new ImageIcon("images/11.png");
	private static ImageIcon image12 = new ImageIcon("images/12.png");
	private static ImageIcon image13 = new ImageIcon("images/13.png");
	private static ImageIcon image14 = new ImageIcon("images/14.png");
	private static ImageIcon image15 = new ImageIcon("images/15.png");
	private static ImageIcon image16 = new ImageIcon("images/16.png");
	private static ImageIcon image17 = new ImageIcon("images/17.png");
	private static ImageIcon image18 = new ImageIcon("images/18.png");
	private static ImageIcon image19 = new ImageIcon("images/19.png");
	private static ImageIcon image20 = new ImageIcon("images/20.png");
	
	//array to hold cards images
	ArrayList<ImageIcon> list = new ArrayList<ImageIcon>();
	
	JPanel cardsPanel = new JPanel();

	//generate numbers between 0-20
	static Random generator = new Random();
	private static int rand1 = generator.nextInt( 20 );
	private static int rand2 = generator.nextInt( 20 );
	private static int rand3 = generator.nextInt( 20 );
	
	
	private static JButton refresh = new JButton("Refresh");

	
	//constructor
	public DeckOfCards()
	{
		setLayout(new GridLayout(2, 1));
		
		add(cardsPanel);
		
		cardsPanel.setLayout(new FlowLayout(FlowLayout.LEFT,2,2));
		
		list.add(image1);
		list.add(image2);
		list.add(image3);
		list.add(image4);
		list.add(image5);
		list.add(image6);
		list.add(image7);
		list.add(image8);
		list.add(image9);
		list.add(image10);
		list.add(image11);
		list.add(image12);
		list.add(image13);
		list.add(image14);
		list.add(image15);
		list.add(image16);
		list.add(image17);
		list.add(image18);
		list.add(image19);
		list.add(image20);
		
			Collections.shuffle(list);
			cardsPanel.add(new JLabel(list.get(1)));
			Collections.shuffle(list);
			
			cardsPanel.add(new JLabel(list.get(1)));
			Collections.shuffle(list);
			cardsPanel.add(new JLabel(list.get(1)));
			Collections.shuffle(list);
			cardsPanel.add(new JLabel(list.get(1)));
			
			
		JPanel buttonPanel = new JPanel(new BorderLayout());
		
		buttonPanel.add(refresh,BorderLayout.CENTER);
		add(buttonPanel);
		refresh.addActionListener(new ButtonRefresh());
	}

	private class ButtonRefresh implements ActionListener
	{

		@Override
		public void actionPerformed(ActionEvent e) {
			// TODO Auto-generated method stub

			cardsPanel.removeAll();
			cardsPanel.add(new JLabel(list.get(1)));
			Collections.shuffle(list);
			
			cardsPanel.add(new JLabel(list.get(1)));
			Collections.shuffle(list);
			cardsPanel.add(new JLabel(list.get(1)));
			Collections.shuffle(list);
			cardsPanel.add(new JLabel(list.get(1)));
                       //test button to console
			System.out.println("aaa");
		}
		
	}
	
	
	public static void main(String[] args)
	{
		JFrame frame = new DeckOfCards();
		frame.pack();
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		frame.setLocationRelativeTo(null);
		frame.setVisible(true);
	}
}

[Tony Docherty]

After changing components you need to revalidate() the panel and call redraw().

BTW your random mechanism is flawed as you can get the same cards drawn multiple times in one hand which is illegal. Once you shuffle a pack it is randomised so you can just take any 4 consecutive cards you don;t need to shuffle again after every card is taken.

[gabriel terry]

It's working! Thank you!

[Tony Docherty]

My pleasure

[Emily Lim]

Can i please get the working codes?

[Campbell Ritchie]

Welcome to the Ranch

It is unlikely that the original poster will still be around to post the code.

[Steven Fraser]

Emily,
If you are having issues, why don't you either open a thread or post what you have done and where you are having problems?
We are all "Lifetime Learners"...
Thank you,
Steve